From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8O5xHXftNWEnBwAAgWs5BA (envelope-from ) for ; Mon, 06 Sep 2021 12:29:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id oNpXGXftNWHwKgAAB5/wlQ (envelope-from ) for ; Mon, 06 Sep 2021 10:29:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BC2F8E852 for ; Mon, 6 Sep 2021 12:29:10 +0200 (CEST) Received: from localhost ([::1]:60552 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNBsD-0005mW-Rr for larch@yhetil.org; Mon, 06 Sep 2021 06:29:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50644) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNBs6-0005mD-1J for guix-patches@gnu.org; Mon, 06 Sep 2021 06:29:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNBs5-0001qA-Mf for guix-patches@gnu.org; Mon, 06 Sep 2021 06:29:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mNBs5-0000Kh-JW for guix-patches@gnu.org; Mon, 06 Sep 2021 06:29:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50072] [PATCH WIP 0/4] Add upstream updater for git-fetch origins. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Sep 2021 10:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50072 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 50072@debbugs.gnu.org Received: via spool by 50072-submit@debbugs.gnu.org id=B50072.16309240911212 (code B ref 50072); Mon, 06 Sep 2021 10:29:01 +0000 Received: (at 50072) by debbugs.gnu.org; 6 Sep 2021 10:28:11 +0000 Received: from localhost ([127.0.0.1]:52043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNBrG-0000JU-Ux for submit@debbugs.gnu.org; Mon, 06 Sep 2021 06:28:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mNBrF-0000JH-QZ for 50072@debbugs.gnu.org; Mon, 06 Sep 2021 06:28:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34870) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNBrA-00015F-Kd; Mon, 06 Sep 2021 06:28:04 -0400 Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=47200 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNBqr-0000Yf-O9; Mon, 06 Sep 2021 06:27:46 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <8d1ae518b23fac5b15812a30b11df1c360ab3fbf.1629068119.git.iskarian@mgsn.dev> Date: Mon, 06 Sep 2021 12:27:42 +0200 In-Reply-To: <8d1ae518b23fac5b15812a30b11df1c360ab3fbf.1629068119.git.iskarian@mgsn.dev> (Sarah Morgensen's message of "Sun, 15 Aug 2021 16:25:27 -0700") Message-ID: <87fsui80dd.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630924150; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=UOlZHHhA0T4iaKthIzk0zoC3HmNlE1Z8rcPRzh2Ivio=; b=P4wf8An4pbwMEjsgQWnDUK/57OLZHcVglZ9AKZlQvTnEhR+JqAjuiGnTDM0oPl8xoqknu2 hGshahwDgp0RtMlrOCY+UvRR669p2aM3wuQOiLtIPOqbRDr0CDlw6WDF59jb5wIhjjdCRV 9SgfiCWgO8GwVHDkcIT1eCaSVuwzRKhVvyK7978sRM9xfVGD3A7GKZ+bnkWe95R9+KGhSl cq0ju90P470dfJfhtwjpjOGYgqkg9ueIB/Uto7wIpc/g64e3o3GNRwcvyHs5StpT43SsQ8 0TPzi+JQ6IgsHBgznAVAlHo69k8BZpgmFV1X7u5aQcAp+67J8UWKuvVUbbxdjA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630924150; a=rsa-sha256; cv=none; b=R+DMdO3GPZdj7XzeARa21XSok2pafbxTP92PnqUDgFNSlCZoWuVUwfuJlFwRCXkTmTKJ9A ABiHwwKtbv0e0KhQ+D65Ch5+2zlzyeXPLVKgaUvhF8SzRY+mgz+gCmqBHtfJSbilCh++Am p8s5SlqDYvNqm+dGCMuQtDgJyAigYuYbUUu7C1lOuSuu2mYKErvWl5HMRZoHE5mAGxZ5eh mLBpP0hyIpqXf3iE+KnE3wsDzVYcxXM95eupI6GVAVFrYzsZFG983SbzktDSu1K4nPjK2F Btnb3YwRzfJil0gqKaCG8FG2P5NSFnDfHIW8TrgVbR2JKQCuyI7gyz/WUMcP2g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -2.91 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BC2F8E852 X-Spam-Score: -2.91 X-Migadu-Scanner: scn0.migadu.com X-TUID: lOnFIpX4Sy4Y Hi Sarah, I like this patch series. :-) Sarah Morgensen skribis: > * guix/git-download.scm (checkout-to-store): New procedure. > * guix/upstream.scm (guess-version-transform) > (package-update/git-fetch): New procedures. > (%method-updates): Add GIT-FETCH mapping. This LGTM. Nitpick: > +(define* (checkout-to-store store ref #:key (log (current-error-port))) > + "Checkout REF to STORE. Write progress reports to LOG. RECURSIVE? ha= s the > +same effect as the same-named parameter of 'latest-repository-commit'." > + ;; XXX: (guix git) does not use shallow clones, so this will be slow > + ;; for long-running repositories. > + (match-record ref [...] > + ;; Only use the first element of URLS. > + (match-record source > + (version urls) I=E2=80=99d use the record acceesors in this cases rather than =E2=80=98mat= ch-record=E2=80=99; currently =E2=80=98match-record=E2=80=99 is not super efficient and I find = it slightly less readable when you=E2=80=99re just accessing a couple of fields. Thanks, Ludo=E2=80=99.