From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YG+3GXGjoWHvcQAAgWs5BA (envelope-from ) for ; Sat, 27 Nov 2021 04:18:09 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8BpxFXGjoWGbKAAA1q6Kng (envelope-from ) for ; Sat, 27 Nov 2021 03:18:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D050ED920 for ; Sat, 27 Nov 2021 04:18:08 +0100 (CET) Received: from localhost ([::1]:59164 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqoE3-0000sB-4G for larch@yhetil.org; Fri, 26 Nov 2021 22:18:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqoDy-0000rn-8x for guix-patches@gnu.org; Fri, 26 Nov 2021 22:18:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49350) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqoDy-0007pn-0E for guix-patches@gnu.org; Fri, 26 Nov 2021 22:18:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mqoDx-0004AZ-OU for guix-patches@gnu.org; Fri, 26 Nov 2021 22:18:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#52117] [core-updates-frozen] [PATCH 0/6] Fix Julia packages. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Nov 2021 03:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52117 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun Cc: 52117@debbugs.gnu.org Received: via spool by 52117-submit@debbugs.gnu.org id=B52117.163798303315962 (code B ref 52117); Sat, 27 Nov 2021 03:18:01 +0000 Received: (at 52117) by debbugs.gnu.org; 27 Nov 2021 03:17:13 +0000 Received: from localhost ([127.0.0.1]:60895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqoDB-00049O-1N for submit@debbugs.gnu.org; Fri, 26 Nov 2021 22:17:13 -0500 Received: from mail-qt1-f174.google.com ([209.85.160.174]:41953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqoD9-00049A-15 for 52117@debbugs.gnu.org; Fri, 26 Nov 2021 22:17:11 -0500 Received: by mail-qt1-f174.google.com with SMTP id v22so10679018qtx.8 for <52117@debbugs.gnu.org>; Fri, 26 Nov 2021 19:17:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dQgw0IZhOdtWMvSmDn56WhYDzER7xeeZbXpjLT3h6XQ=; b=DvUj7oeNkMiq5Qwa1qfShZPOD8s0SNirE75OIJNGy0TB6+gmNxXlBHAYAzbCvWb9WE 278EN7cGnEi1Q7QVKrvT22lsysxqW5lI0T0tyeBVCo+kR6iB45a89HClhF127SMBIDI/ wD30zcAwbCUCQB4phoDle2w5tPDgvFxOyqYKiB15NmTgRaSFTCpreP3f7guDlBYsFMlz hIzxug9CDeNWo6tWOd4uP5Xqsvvzyhq5g2DBOvpGx31eGVXziC0nzP5r0cl0kp8adK2n fZ2CuMjv9GdV8whVXhQOnNZzwWFhT3DcrVjtXx3mh6N1v2v44y8b4EXaZU5iwNPxvLGs vs7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dQgw0IZhOdtWMvSmDn56WhYDzER7xeeZbXpjLT3h6XQ=; b=ZkSnBiuyHL12NJCQtw2HlfQKlUWDcLsjWPWg9YWCEiX5tvqhcfFXX95KcXXg+AxdKa AfY4amwkp2tFd88N7a4a46XvXtNOzO08L/fkeq7g8gSBwFwfH3LyneeAd9aoLWkTvHfm jXyEzB8al4XlPfSvM9lGypBAZLFuVfRE0JyrtTjPjuOpHb40wCjxpsDzNHKVrvINfQmG //Qt0x4NNllRBMpGbddERy4/+o6wh5IyRZI/PTBCwDmZXbGAtIPHtl+YSI+YPBp9BrGw sc9nk/FS1eq3gUj8mTKFYQD63DSHkHKk618mAWeeu2DmLiRx6amLwWYz/NnrQRtTgWKy mTRA== X-Gm-Message-State: AOAM531MxQUpcu6OG0GocbTfOW1gkRZhJoJUgCH1Zza77f9BIXYEn6Do U1ToFuswuVhBRytwTvj9TLtOs8GEfT+c8A== X-Google-Smtp-Source: ABdhPJxscJoyhD2HKXDfmh9Sz37vK/gfW81K1tA5TBbBuP5faS3y8ad56hD0g9Q+6qbM1+GD/HA5Bw== X-Received: by 2002:ac8:5b90:: with SMTP id a16mr29257232qta.300.1637983024924; Fri, 26 Nov 2021 19:17:04 -0800 (PST) Received: from hurd (dsl-148-169.b2b2c.ca. [66.158.148.169]) by smtp.gmail.com with ESMTPSA id z13sm3999464qkj.1.2021.11.26.19.17.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Nov 2021 19:17:04 -0800 (PST) From: Maxim Cournoyer References: <20211125233559.34575-1-zimon.toutoune@gmail.com> <20211125233559.34575-2-zimon.toutoune@gmail.com> Date: Fri, 26 Nov 2021 22:17:02 -0500 In-Reply-To: <20211125233559.34575-2-zimon.toutoune@gmail.com> (zimoun's message of "Fri, 26 Nov 2021 00:35:55 +0100") Message-ID: <87fsri8ez5.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637983088; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=dQgw0IZhOdtWMvSmDn56WhYDzER7xeeZbXpjLT3h6XQ=; b=Xeo+rKPD4JlZUPn9n2EaJtTvBozeIcPGdNGw7lMtynjNvXBxJxDKoE1h5U/earA4ld9u5M 20LDbrsRZU3psLMrfRSz9Rsw9ePxqytM+os+OTk+EVHCKNvCVsOi9ZgYwySrp+4dRjv4a4 SNSHOeYfvFczQvl/jSDwbfVfU6ecr9ZgPP4zK2WSKx+/wvkoOQrELDWrT+IgpTpECbcTLn 4SdOAngYU8icyrT7A4kisxT/sVgXgc3AV3lO+ePNfNs3vvRprmJo0klr1pODk7exRoTy1S V2E5OJV22cTu0AHwx6bitmrjgMsTAiU4LK7kJCpPSOI15lGwAev+DHf0eCo3Uw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637983088; a=rsa-sha256; cv=none; b=pO3dQrIzUWSOvpHiFVhdTSPzVGU9IM5qPjOHeHP8eKo8mF9Gp4NGAhdR6XuSQAo21B7yf1 x3ZH506mUzzblfcR+f701BdOWCgmS9NPAH0NXWTxKr1BEP+9dJ5bqUtd/M9OJZnoRJq8ns ZdQRLlx/OdvULV1hHGhj6v1qIBbUEdqQMWzf9X9+Lcsg823epABOIEUyO6MsGe4WbcG/h2 82NstXl0DtuY8t2J8er9Kl6fImF5oV6KvCwEGdx33UKDoS+9Be1RijzUb/rLkjvIWhBvd7 wINA8aAk+q6KGY9J7h07e2GEXCcJa1WinFtKEBJ1Ri9/8QyroP/W5+7NWfDgkw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=DvUj7oeN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.80 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=DvUj7oeN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D050ED920 X-Spam-Score: -1.80 X-Migadu-Scanner: scn0.migadu.com X-TUID: s7FG6KVxHwki Hello Simon! zimoun writes: > Even providing '--procs=1' launches 2 workers which breaks some testsuite of ^ the > packages; therefore set '#:parallel-tests?' to '#false' was ineffective. ^ some ^ setting It's good to put the rationale here, as you did. > * guix/build/julia-build-system.scm (check): Fix unexpected behaviour from > 'julia' command line option. But in the changelog message I'd expect to see foremost *what* it does rather than a reformulation of *why* it does it :-). E.g., something like: do not pass the '--procs' argument when not running the tests in parallel. > --- > guix/build/julia-build-system.scm | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/guix/build/julia-build-system.scm b/guix/build/julia-build-system.scm > index f0dc419c17..af478fd4a3 100644 > --- a/guix/build/julia-build-system.scm > +++ b/guix/build/julia-build-system.scm > @@ -112,7 +112,10 @@ (define* (check #:key tests? source inputs outputs julia-package-name > (builddir (string-append out "/share/julia/")) > (jobs (if parallel-tests? > (number->string (parallel-job-count)) > - "1"))) > + "1")) > + (nprocs (if parallel-tests? > + (string-append "--procs=" jobs) > + ""))) > ;; With a patch, SOURCE_DATE_EPOCH is honored > (setenv "SOURCE_DATE_EPOCH" "1") > (setenv "JULIA_DEPOT_PATH" builddir) > @@ -122,8 +125,7 @@ (define* (check #:key tests? source inputs outputs julia-package-name > ""))) > (setenv "JULIA_CPU_THREADS" jobs) > (setenv "HOME" "/tmp") > - (invoke "julia" "--depwarn=yes" > - (string-append "--procs=" jobs) > + (invoke "julia" "--depwarn=yes" nprocs Here nprocs can be ""; is it really OK to pass an empty string argument to julia? > (string-append builddir "loadpath/" > package "/test/runtests.jl")))) > #t) Trailing '#t' are no longer required. Actually, looking at the output of julia --help: -p, --procs {N|auto} Integer value N launches N *additional* local worker processes The key is 'additional' :-). So to disable parallel processing it needs to be 0. I've modified it like so: --8<---------------cut here---------------start------------->8--- (define* (check #:key tests? source inputs outputs julia-package-name parallel-tests? #:allow-other-keys) (when tests? (let* ((out (assoc-ref outputs "out")) (package (or julia-package-name (project.toml->name "Project.toml"))) (builddir (string-append out "/share/julia/")) (job-count (if parallel-tests? (parallel-job-count) 1)) ;; The --proc argument of Julia *adds* extra processors rather than ;; specify the exact count to use, so zero must be specified to ;; disable parallel processing. (additional-procs (max 0 (1- job-count)))) ;; With a patch, SOURCE_DATE_EPOCH is honored (setenv "SOURCE_DATE_EPOCH" "1") (setenv "JULIA_DEPOT_PATH" builddir) (setenv "JULIA_LOAD_PATH" (string-append builddir "loadpath/" ":" (or (getenv "JULIA_LOAD_PATH") ""))) (setenv "JULIA_CPU_THREADS" (number->string job-count)) (setenv "HOME" "/tmp") (invoke "julia" "--depwarn=yes" "--procs" (number->string additional-procs) (string-append builddir "loadpath/" package "/test/runtests.jl"))))) --8<---------------cut here---------------start------------->8--- And took the liberty to remove trailing #f in other phases. Thank you! Maxim