From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kEayOia4mWIQzAAAbAwnHQ (envelope-from ) for ; Fri, 03 Jun 2022 09:28:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id sFmnOia4mWKPxQAA9RJhRA (envelope-from ) for ; Fri, 03 Jun 2022 09:28:38 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8C42DF112 for ; Fri, 3 Jun 2022 09:28:38 +0200 (CEST) Received: from localhost ([::1]:35664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nx1jZ-0003OW-Ob for larch@yhetil.org; Fri, 03 Jun 2022 03:28:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39932) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx1j0-0003MR-Vi for guix-patches@gnu.org; Fri, 03 Jun 2022 03:28:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nx1j0-0002wi-MR for guix-patches@gnu.org; Fri, 03 Jun 2022 03:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nx1j0-0006DF-FX for guix-patches@gnu.org; Fri, 03 Jun 2022 03:28:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55231] [PATCH v1] initrd: Allow extra search paths with =?UTF-8?Q?=E2=80=98initrd-extra-module-paths=E2=80=99?= Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 03 Jun 2022 07:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55231 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brian Cully Cc: 55231@debbugs.gnu.org, Brian Cully Received: via spool by 55231-submit@debbugs.gnu.org id=B55231.165424125923851 (code B ref 55231); Fri, 03 Jun 2022 07:28:02 +0000 Received: (at 55231) by debbugs.gnu.org; 3 Jun 2022 07:27:39 +0000 Received: from localhost ([127.0.0.1]:55156 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nx1ic-0006Cd-OJ for submit@debbugs.gnu.org; Fri, 03 Jun 2022 03:27:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nx1iY-0006CO-Fh for 55231@debbugs.gnu.org; Fri, 03 Jun 2022 03:27:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49002) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx1iS-0002uN-62; Fri, 03 Jun 2022 03:27:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=5GVo50Y8XZz3ZFdJF0muJvvyOJ+9nPClm1VG8Dn+77k=; b=pxjStEcGZSAbdQgJT8ut F/JNonKiQrencOseKfOJioWkaj5rK5zgaWJJLFs62GqxnWJLgSFFk9YjofaePOdc3Nz4VdRik15sB yGo2ZTQ55+cQwnxBE/4uHyQKfGa5vv1FQhzaHPGrAF+Ho+q6ObxRgbCGOPXhVdS6FbH9Uvyx5VSQc WgS9PbDkGOr3+h5ZjHbAfeFgFP39KxPwKqWrMAo7adENULVTJeP1nCByxlJecrG5CVc70qkG5efQH jHqAjte1XgLfMoj8fB/gA7tV3v2wZLx99+c6Jlb6xQlARA+2Dd3igMgNsWMRhBLz62gjNe5lJvF4+ 6mCrsQ35fhj8BA==; Received: from [193.50.110.183] (port=50992 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nx1iH-0006vL-VI; Fri, 03 Jun 2022 03:27:23 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87wnf3pv87.fsf@ditto.jhoto.spork.org> <2053c4ab42dfe2719cfc377934ac2fb9bcb500a9.1653160364.git.bjc@spork.org> <87ilpkwf8x.fsf_-_@gnu.org> <87a6aug4p2.fsf@ditto.jhoto.spork.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 15 Prairial an 230 de la =?UTF-8?Q?R=C3=A9volution, ?= jour de la Caille X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 03 Jun 2022 09:27:14 +0200 In-Reply-To: <87a6aug4p2.fsf@ditto.jhoto.spork.org> (Brian Cully's message of "Thu, 02 Jun 2022 16:40:36 -0400") Message-ID: <87fskmky0d.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654241318; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5GVo50Y8XZz3ZFdJF0muJvvyOJ+9nPClm1VG8Dn+77k=; b=oP75gHShKQgbYsu/GIB8H+bRvLwhqbdq2WMCNlJpfzuwYdFX0HaGSweDvZ1ECM3SfdJ/NJ NoCbb8FBHFHnnZ53hNaGWie+2knqOMMz/n1GHf6VanbuallNQMB7BIUwDK1J/GOrIrcBzr HrEKSIlxD9B9JYRI87MOxgK9X0MulpI3/OFgq51DyYkGeRd/pdYEMe2TjYQwj0/G1VQdKw QJ1LzjRzFb29+NlHWy3HvB7nMyJqaE5Udpbk5AjnL9tbY1FXNqIn1XQc6vfsMR+VU3lcNh m7L6GPnSIab4FXcROky8y7+hi6JX4FRz4fZOcE7rhX34zLh5QyvXnTBQBn18PA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654241318; a=rsa-sha256; cv=none; b=J2cPbPLt+V2fwp8Xe6dVZgqSpdGqObON642HvkjlmqDl9XQDsB9YcFycYQWvYT/DQOIpDr GJ+yBH1BbmWiuPKoaIeOQZafPwEs7bWlNJ0DCoyUtMmjBJz2KEHmEAl4gksT3AsllzmP8b 7J+hv1mTU7kSqhG7LGYg7gALOmOW9cUh87l7lJEbCpVAS1nM+ZK8MTvwYEvkdE8IeamgMK dFZPf8eBHmF5VIIo3xDf32gpSH99VHwwuCwdIgVRDXSXumHqhLwOHJ/D+y4/LICz70Y9fz z6pMgsxb8VwGIb5atheXqE3q7QboVXQlL5Ji0c4DLsrHFoLeFuJmly5O4HaOpg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pxjStEcG; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pxjStEcG; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 8C42DF112 X-Spam-Score: -3.92 X-Migadu-Scanner: scn1.migadu.com X-TUID: 0ieuISKjhtWK Hi, Brian Cully skribis: > Ludovic Court=C3=A8s writes: > >> I wonder if we could reuse the =E2=80=98kernel-loadable-modules=E2=80=99= field for >> this >> purpose instead of introducing a new field. We=E2=80=99d need to pass i= t to >> the >> initrd procedures and have them search in there in addition to the >> kernel package, pretty much like this patch already does actually. > > This sounds like it could be made to work as you suggest. My feeling > is that the two contexts are slightly different, though, as the Linux > modules are a superset of the initrd modules, Right. Here, we want the initrd machinery to search for modules in any place where they can be found, which is either =E2=80=98kernel=E2=80=99 or =E2=80=98kernel-loadable-modules=E2=80=99. One could define =E2=80=98initrd-extra-module-paths=E2=80=99 to be differen= t from =E2=80=98kernel-loadable-modules=E2=80=99, for example if you can be sure t= he module will be loaded from the initrd and not after, but in general both are likely to have the same value, no? >> Nitpick: the GNU convention is to use =E2=80=9Cpath=E2=80=9D to denote = =E2=80=9Csearch >> paths=E2=80=9D, >> and other =E2=80=9Cfile=E2=80=9D, =E2=80=9Cfile name=E2=80=9D, or simila= r. In this case, that=E2=80=99d be >> =E2=80=9Ckernel module=E2=80=9D or =E2=80=9CLinux module=E2=80=9D. > > I struggled with this a fair amount, actually. What these file-likes > actually represent is an element of a search path, even if they come > in the odd form of a file-like object, which is why I used > =E2=80=98path=E2=80=99. =E2=80=98file=E2=80=99 seems wrong, as it implies= (to me) that it=E2=80=99s the > =E2=80=98initrd-extra-module-files=E2=80=99 option itself that would incl= ude the > module, rather than the =E2=80=98initrd-modules=E2=80=99 option. Hmm right, you have a point! :-) > When I get some time (hopefully soon!) I=E2=80=99ll try to thread > =E2=80=98kernel-loadable-modules=E2=80=99 through instead and see how far= I can get > with that approach. Do you think the documentation for it will need to > be updated to specify that it=E2=80=99s also used as a search path for in= itrd > building? Or maybe the better option is to update the documentation > for =E2=80=98initrd-modules=E2=80=99 to say that it uses =E2=80=98kernel-= loadable-modules=E2=80=99 as > input? I think you should update the documentation in the commit that changes things, so that the patch is self-contained. It may be enough to state in the documentation of the =E2=80=98initrd-modul= es=E2=80=99 field that its value is a list of module names that are searched for in =E2=80=98kernel=E2=80=99 and =E2=80=98kernel-loadable-modules=E2=80=99. WDYT? Thanks, Ludo=E2=80=99.