unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Lars-Dominik Braun <lars@6xq.net>
Cc: john.kehayias@protonmail.com, 55948@debbugs.gnu.org
Subject: [bug#55948] [PATCH 0/2] gnu: Update rocm to 5.1.3.
Date: Thu, 16 Jun 2022 14:17:37 +0200	[thread overview]
Message-ID: <87fsk4ls4e.fsf@gnu.org> (raw)
In-Reply-To: <YqscOHyKZ/XpL8ZS@noor.fritz.box> (Lars-Dominik Braun's message of "Thu, 16 Jun 2022 14:04:08 +0200")

Hi,

Lars-Dominik Braun <lars@6xq.net> skribis:

>> Pushed!
> aw, I’m too late. I was going to propose the attached changes.

Oh sorry; it’s never too late though.

> diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm
> index 7b197bb67b..f5d3eac588 100644
> --- a/gnu/packages/llvm.scm
> +++ b/gnu/packages/llvm.scm
> @@ -1127,14 +1127,9 @@ (define-public llvm-for-rocm
>                 (search-patches "llvm-roc-5.0.0-linkdl.patch"
>                                 "llvm-roc-4.0.0-remove-isystem-usr-include.patch"))))
>      (arguments
> -     (substitute-keyword-arguments (package-arguments llvm-12)
> -       ((#:phases phases '%standard-phases)
> -        `(modify-phases ,phases
> -           (add-after 'unpack 'chdir
> -             (lambda _
> -               (chdir "llvm")))))
> +     (substitute-keyword-arguments (package-arguments llvm-14)
>         ((#:configure-flags flags)
> -        ''("-DLLVM_ENABLE_PROJECTS=llvm;clang;lld"
> +        #~(list"-DLLVM_ENABLE_PROJECTS=llvm;clang;lld"
>             "-DLLVM_TARGETS_TO_BUILD=AMDGPU;X86"
>             "-DCMAKE_SKIP_BUILD_RPATH=FALSE"
>             "-DCMAKE_BUILD_WITH_INSTALL_RPATH=FALSE"

John, WDYT?

> -(define-public rocclr-4
> -  (package
> -    (name "rocclr-4")
> -    (version "4.3.0")

Fine with me; John?

Lars, feel free to push these if John agrees.

Ludo’.




  reply	other threads:[~2022-06-16 12:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13 17:23 [bug#55948] [PATCH 0/2] gnu: Update rocm to 5.1.3 John Kehayias via Guix-patches via
2022-06-13 17:25 ` [bug#55948] [PATCH 1/2] gnu: Update llvm-for-rocm " John Kehayias via Guix-patches via
2022-06-13 17:26 ` [bug#55948] [PATCH 2/2] gnu: rocm: Update " John Kehayias via Guix-patches via
2022-06-16 11:35 ` bug#55948: [PATCH 0/2] gnu: Update rocm " Ludovic Courtès
2022-06-16 12:04   ` [bug#55948] " Lars-Dominik Braun
2022-06-16 12:17     ` Ludovic Courtès [this message]
2022-06-16 15:43       ` John Kehayias via Guix-patches via
2022-06-28 11:22         ` Lars-Dominik Braun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsk4ls4e.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=55948@debbugs.gnu.org \
    --cc=john.kehayias@protonmail.com \
    --cc=lars@6xq.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).