From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id pe86AF6ar2IKBgEAbAwnHQ (envelope-from ) for ; Sun, 19 Jun 2022 23:51:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id sFfXOV2ar2IvYQAAG6o9tA (envelope-from ) for ; Sun, 19 Jun 2022 23:51:25 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 502AE3E748 for ; Sun, 19 Jun 2022 23:51:25 +0200 (CEST) Received: from localhost ([::1]:34632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o32pI-0002y4-FA for larch@yhetil.org; Sun, 19 Jun 2022 17:51:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o32ow-0002wv-Gp for guix-patches@gnu.org; Sun, 19 Jun 2022 17:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59461) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o32ow-0006Bu-8V for guix-patches@gnu.org; Sun, 19 Jun 2022 17:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o32ow-0002mA-76 for guix-patches@gnu.org; Sun, 19 Jun 2022 17:51:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55997] [PATCH staging 1/4] gnu: Add ruby-hydra-minimal. Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Jun 2022 21:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55997 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tom Fitzhenry Cc: 55997@debbugs.gnu.org Received: via spool by 55997-submit@debbugs.gnu.org id=B55997.165567544910651 (code B ref 55997); Sun, 19 Jun 2022 21:51:02 +0000 Received: (at 55997) by debbugs.gnu.org; 19 Jun 2022 21:50:49 +0000 Received: from localhost ([127.0.0.1]:53358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o32oi-0002lj-QC for submit@debbugs.gnu.org; Sun, 19 Jun 2022 17:50:49 -0400 Received: from mx.kolabnow.com ([212.103.80.155]:8808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o32og-0002lU-HV for 55997@debbugs.gnu.org; Sun, 19 Jun 2022 17:50:47 -0400 Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 39161E04; Sun, 19 Jun 2022 23:50:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:in-reply-to:date:date:subject:subject:from:from :references:received:received:received; s=dkim20160331; t= 1655675439; x=1657489840; bh=225W+qNmS4q8WiniZZvPWqwcJt1hey2hgQr C4br1/pU=; b=IeTagrZAAgZYq5rtyj/ZRCo4zFAiKXRlMPvMpDc6dQtOuL/q2FD JxrRhCyJf5HPaoxnKXYXaf1ukGy0YJCUqvQw5k9RGDkICBAjbi5DIkojVI3Ogmes x01C4r6WY9zXY19zdZUpb/pMd1Sk4M8T8y6Cp+zPUSJjUke7OcX+0F7/mUPJJ3Ss 2YLekdAj5/5ovk9s0R8kM9/cwKu5mya6FIl3SFgNZap3vdoW7Gc3zH1pdVkeTs5g RJ/Z0k8oJlL3gSZxr2CsThHbKb0z1tDrsMgQ3CZJSd4shlOHXao7g0iNN4JnzO9A MDKT5edB/oyEPoEa43lsHUYD5tyQFD720kfnp6zbVsuB3704HX9H5fApS9m/845b R3/mK2jJt9FDBdd1m/raDngFEBclwY/0rB7IHFSm0PpzFQlOJ7ELeZr0qHBwMQL8 phYlGH1ym45XKbIfAfN72BGhfEiFEr271/KFFzAZoFXbe1nX+iiBwiv+2BteoHqd NiohWAyHPr45lqQKL7Wg2TL5CU4yKe1cFnw2oai+4zmoe+MGjXoIMsN0h2Ut7xSx z0kdslvB8dEJ6OO1jwjK1agS5OafpLFdJ6lBr8bbdigvADi6Zh7nnGsdOcByJXut fNWh8BvXN+8WN49Xfh6VwgPTqDd5gkAjf8hYVHORKwYTkITgwOzH3s2k= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1jgr0Z8hgh1e; Sun, 19 Jun 2022 23:50:39 +0200 (CEST) Received: from int-mx002.mykolab.com (unknown [10.9.13.2]) by mx.kolabnow.com (Postfix) with ESMTPS id 10A3DC08; Sun, 19 Jun 2022 23:50:38 +0200 (CEST) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx002.mykolab.com (Postfix) with ESMTPS id 9EB2529E3; Sun, 19 Jun 2022 23:50:38 +0200 (CEST) References: <20220615145805.3189-1-tom@tom-fitzhenry.me.uk> <20220615150434.11604-1-tom@tom-fitzhenry.me.uk> Date: Sun, 19 Jun 2022 18:36:21 -0300 In-reply-to: <20220615150434.11604-1-tom@tom-fitzhenry.me.uk> Message-ID: <87fsk0qq57.fsf@kolabnow.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches From: Thiago Jung Bauermann via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655675485; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=225W+qNmS4q8WiniZZvPWqwcJt1hey2hgQrC4br1/pU=; b=pzoaNUxeoowzSx3Q/DnPBxTLLVpRgsfNfjg17+3RQVnyqp1aHCXRqz/d0+rt6lexUMMR3/ FZGcoHc/z53qG73hdiEYLmgJo8H4yJ6H/w949RKmwAneNXwVOBmQTtLy1OJYP1QjkPIDli 8Qv6BdjaQODP+bNtTe4Mpvwr5nIRVdzpV1ICsQsHAwr6iq2eskCdp6rjsRnhaeInyKksKa y2531qjygtkmOD9UvMIwCWCBFF62gKengG9RwzqxbpGl/IRTnwC5y+3auQ0sNYa6YGgpnK xOqmI7oc1GJpn/ODhDznsSPi24wgKIsnGck9bkd8xYy+x7khirxz6JGA7iOBbg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655675485; a=rsa-sha256; cv=none; b=XToMoEVy9sgTmbozYIEgUcsg+Wyi5S6FJmYXBxlVRB31B369fgb+9YU93yQ7fXlUgH8Oms 0WUx5bcWOwVpVcAnMXCUB+Tl99+xat743oOVx5NMnQVZcXE1DHy2PRx5ujAWLwT20gykBi Alqv1mxn7J+QPHzvekPBIRX5jfkBpeBs7LgliCoEm+EEQO7liz4aFRfBzWAaHyLJdeqye9 t0G+iWJVMH3hWL/hSbbL7VrK/utoGlRfxec5Zk234rsKn4oycocbQGZm1bTZaQ0IJRBMZi 7QGaZ6AxmiMCXbRj+9G9zZy6Eh0THM+HjmjG2KFreCxgnAzi73fRJQFqEveXwQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=IeTagrZA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.98 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=kolabnow.com header.s=dkim20160331 header.b=IeTagrZA; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 502AE3E748 X-Spam-Score: -3.98 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3EaJWj7abapc Hello Tom, Nice series! Thanks for tackling this issue. I read all patches, and have only one minor suggestion about this one, apart from what Maxime already mentioned. Tom Fitzhenry writes: > --- a/gnu/packages/ruby.scm > +++ b/gnu/packages/ruby.scm > @@ -3124,24 +3124,39 @@ (define-public ruby-hashdiff > (home-page "https://github.com/liufengyun/hashdiff") > (license license:expat))) >=20=20 > -(define-public ruby-hydra > +(define-public ruby-hydra-minimal > ;; No releases yet. > (let ((commit "5abfa378743756ae4d9306cc134bcc482f5c9525") > (revision "0")) > (package > - (name "ruby-hydra") > + (name "ruby-hydra-minimal") > (version (git-version "0.0" revision commit)) > (home-page "https://github.com/hyphenation/hydra") > (source (origin > (method git-fetch) > (uri (git-reference (url home-page) (commit commit))) > (file-name (git-file-name name version)) > + ;; byebug is a non-essential debugging utility that brin= gs in > + ;; many dependencies. > + (patches (search-patches "ruby-hydra-no-byebug.patch")) > (sha256 > (base32 > "1cik398l2765y3d9sdhjzki3303hkry58ac6jlkiy7iy62nm529f"= )))) > (build-system ruby-build-system) > (arguments > - '(#:phases (modify-phases %standard-phases > + ;; Avoid rspec dependency. > + '(#:tests? #f)) > + (synopsis "Ruby hyphenation patterns") > + (description > + "ruby-hydra-minimal is a Ruby library for working with hyphenatio= n patterns. It is a low-dependency variant of ruby-hydra.") guix lint has two complaints about this description: gnu/packages/ruby.scm:3151:7: ruby-hydra-minimal@0.0-0.5abfa37: sentences in description should be followed by two spaces; possible infraction at 74 gnu/packages/ruby.scm:3151:0: ruby-hydra-minimal@0.0-0.5abfa37: line 3151 is way too long (131 characters) One suggestion to solve both is to put the second sentence in its own line. > + (license license:expat)))) > + > +(define-public ruby-hydra > + (package > + (inherit ruby-hydra-minimal) > + (name "ruby-hydra") > + (arguments > + '(#:phases (modify-phases %standard-phases > (add-after 'unpack 'make-files-writable > (lambda _ > (for-each make-file-writable (find-files ".")) When I saw this patch I thought that ruby-hydra would also inherit the =E2=80=9C#:tests? #f=E2=80=9D argument from its parent, but this constructi= on overrides the whole arguments list instead. Nice, I learned something new today. :-) --=20 Thanks Thiago