From: Christopher Rodriguez <yewscion@gmail.com>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Christopher Rodriguez <yewscion@gmail.com>, 56989@debbugs.gnu.org
Subject: [bug#56989] [PATCH v2] gnu: bqn: Add bqn.scm and dbqn package.
Date: Fri, 05 Aug 2022 21:47:32 -0400 [thread overview]
Message-ID: <87fsiam8aa.fsf@gmail.com> (raw)
In-Reply-To: <5bffe66896dbebfe4716b924eb3d7a13e8e6344b.camel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1635 bytes --]
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> You should let-bind revision and commit. You should nt let-bind tag,
> version and hash. Use git-version like (git-version "0.2.1" revision
> commit).
Copy that, I've implemented this change in the upcoming patch.
> That isn't really a good argument not to have tests though. While
> package maintainers should check that dependant packages still build,
> having early failure for a broken package (courtesy of the check phase)
> goes a long way.
>
I agree with this.
I did check each test, and there were three failing in the cloned repo
on my local machine… Until I ran them inside the package build
environment, where they all passed 100%. I have run this with --check
--rounds=20 and have not seen a failure inside of the build environment,
so I will leave them enabled.
> Ah, yes, the infamous flip :)
> (cons* #:options your-options rest) ?
I've left these as (#:outputs (list outputs)), as that is less
characters than the above and I'm just passing in a single variable
(inside a list, as that is what the procedure is expecting) without any
(other) modifications.
> If there is no *variable* named "openjdk", I'd suggest using the lowest
> one that works. If people are so inclined to use a newer jdk they can
> modify the package graph (which is easier than walking back to the
> earliest supported version), plus it's lower bootstrap for those of us
> building from source.
I've successfully built it using icedtea-8 (icedtea-7 failed), so I've
switched the patch over to that.
--
Christopher Rodriguez
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2022-08-06 2:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 2:20 [bug#56989] [PATCH v1 1/5] gnu: bqn: Add bqn.scm and dbqn package Christopher Rodriguez
2022-08-05 2:20 ` [bug#56990] [PATCH v1 2/5] gnu: bqn: Add bqn-bytecode-sources Christopher Rodriguez
2022-08-05 2:20 ` [bug#56992] [PATCH v1 3/5] gnu: bqn: Add cbqn-bootstrap Christopher Rodriguez
2022-08-05 2:20 ` [bug#56991] [PATCH v1 4/5] gnu: bqn: Add singeli-bootstrap Christopher Rodriguez
2022-08-05 2:20 ` [bug#56993] [PATCH v1 5/5] gnu: bqn: Add cbqn Christopher Rodriguez
2022-08-05 5:46 ` [bug#56989] [PATCH v2] gnu: bqn: Add bqn.scm and dbqn package Christopher Rodriguez
2022-08-05 7:15 ` Liliana Marie Prikler
2022-08-05 15:12 ` Christopher Rodriguez
2022-08-05 15:37 ` ( via Guix-patches via
2022-08-05 15:50 ` Christopher Rodriguez
2022-08-05 15:50 ` Christopher Rodriguez
2022-08-05 22:33 ` Liliana Marie Prikler
2022-08-06 1:47 ` Christopher Rodriguez [this message]
2022-08-06 2:20 ` [bug#56989] [PATCH v3] gnu: Add dbqn Christopher Rodriguez
2022-08-07 16:28 ` Liliana Marie Prikler
2022-08-08 9:19 ` Maxime Devos
2022-08-08 13:54 ` Christopher Rodriguez
2022-08-08 21:09 ` Maxime Devos
2022-08-09 8:58 ` Maxime Devos
2022-08-09 9:02 ` Maxime Devos
2022-08-07 14:43 ` [bug#56989] [PATCH v2] gnu: bqn: Add bqn.scm and dbqn package Christopher Rodriguez
2022-08-08 9:20 ` [bug#56989] [PATCH v1 1/5] " Maxime Devos
2022-08-09 1:22 ` [bug#56989] [PATCH v4] gnu: Add dbqn Christopher Rodriguez
2022-08-10 17:27 ` [bug#56989] [PATCH v5 1/5] gnu: Add dbqn package Christopher Rodriguez
2022-08-10 17:27 ` [bug#56989] [PATCH v5 2/5] gnu: Add bqn-sources Christopher Rodriguez
2022-08-10 17:27 ` [bug#56989] [PATCH v5 3/5] gnu: Add cbqn-bootstrap Christopher Rodriguez
2022-08-10 17:27 ` [bug#56989] [PATCH v5 4/5] gnu: Add singeli-sources Christopher Rodriguez
2022-08-10 17:28 ` [bug#56989] [PATCH v5 5/5] gnu: Add cbqn Christopher Rodriguez
2022-08-31 21:10 ` bug#56989: bug#56993: [PATCH v1 5/5] gnu: bqn: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsiam8aa.fsf@gmail.com \
--to=yewscion@gmail.com \
--cc=56989@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).