From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wP5pLKMPQmMRbgAAbAwnHQ (envelope-from ) for ; Sun, 09 Oct 2022 02:02:43 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id COaALKMPQmPBGQEA9RJhRA (envelope-from ) for ; Sun, 09 Oct 2022 02:02:43 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 300A5AB9F for ; Sun, 9 Oct 2022 02:02:42 +0200 (CEST) Received: from localhost ([::1]:41878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ohJmD-0005md-57 for larch@yhetil.org; Sat, 08 Oct 2022 20:02:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45562) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohJla-0005mC-PW for guix-patches@gnu.org; Sat, 08 Oct 2022 20:02:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42557) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohJla-0001De-Dv for guix-patches@gnu.org; Sat, 08 Oct 2022 20:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohJla-0006wF-1v for guix-patches@gnu.org; Sat, 08 Oct 2022 20:02:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58386] [PATCH 2/2] gnu: Add passage. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 09 Oct 2022 00:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58386 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Graves Cc: 58386@debbugs.gnu.org X-Debbugs-Original-Cc: guix-patches@gnu.org, 58386@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166527367226614 (code B ref -1); Sun, 09 Oct 2022 00:02:02 +0000 Received: (at submit) by debbugs.gnu.org; 9 Oct 2022 00:01:12 +0000 Received: from localhost ([127.0.0.1]:41635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohJkm-0006vC-Bi for submit@debbugs.gnu.org; Sat, 08 Oct 2022 20:01:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:58990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohJkk-0006v3-90 for submit@debbugs.gnu.org; Sat, 08 Oct 2022 20:01:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51534) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohJkj-0005jr-Lb for guix-patches@gnu.org; Sat, 08 Oct 2022 20:01:10 -0400 Received: from tobias.gr ([80.241.217.52]:40212) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohJkd-00013Q-8t for guix-patches@gnu.org; Sat, 08 Oct 2022 20:01:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=DMdF38DG16Che /6A/C+2ucn2tQLPixqU68UECxeDjIU=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=jDaRzJyOeBP3pHEh6cu+dgd59HR8eJr683jlj6 +Llxof5EuqKUylqdxWJlRL1uuZeKkqxppQvK7GIxqKEKbK6Rw4ExP1A+C19iyyuJEEoscr uwIx3/C2Gf4a+Ej8k3jJiUJ2Fe3mWdEnnepZAtFsFQraPB0ePwPuPUWkuRZ+PlvBTIIMct aYMPP1dCNi568khBQwjubx8gWX7IK357vgfty49dkePFSH5DwnZ0G+wgtZOFV/knRrdmeZ O2IKQChfHXQtLkRqUMMCr55XiIlO6DG1o4KAgQs5dIjZJKXNH0ZPX+7xWb6iudYtFDwGJ6 v1EQZ7pp0VHikYye/0qveDIA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 24bcf328 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Sun, 9 Oct 2022 00:00:50 +0000 (UTC) References: <20221008224453.8634-1-ngraves@ngraves.fr> <20221008224453.8634-2-ngraves@ngraves.fr> Date: Sun, 09 Oct 2022 01:05:44 +0200 In-reply-to: <20221008224453.8634-2-ngraves@ngraves.fr> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87fsfxdfwk.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=80.241.217.52; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice X-ACL-Warn: , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665273763; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=DMdF38DG16Che/6A/C+2ucn2tQLPixqU68UECxeDjIU=; b=i5MGdTDR5QxfLkT/+NV0huptv4xnYBm8pluLS5Nq1aQaS190ZJnBAwyDLBqwupHcOXU3lw nEmOGtlKpsNLD1VnMHgP8o6YgkTMrC3rRtcg54vglNQ8Xp3EdvfGZ76O2yG8s/6nUKL6fe 9UTqCApMeq9dqFokcQxIT5mjhkD31aywBPpbbCFIsOPGsvvo1XlPuwhsNBECivG2/5phU7 tptd+Hsro8MUf1soquqL+GZKd9QVsPqFfBBrzgZu9UJk5QxkP/z5/UKID6lGyCEtoN5uhj +G3I4TU1u+VksCATZdYjG3V690P4qdUAw/JSkD/TwBriumTlllLcMyrUqvJEtQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665273763; a=rsa-sha256; cv=none; b=jFGaPs6Xn4+L1b1Wjp2E6KDJ0nj8s3e64htkWt8lAsT/a2XPIsVjU6Fuoyi70XP7iCtx8q I3xiqu1OC4oDvppnOTPRVEOcGEKBUldek5xMGhTnF2fwn/Ah6PiqGQ0cmjlTjfwv41hu24 uysrkiONiXgO6Y4ReG+qkc9DyGcHRRtp4KbJmsdUZjbZDrk1Lh9MbO9vM2LNFLVor9T2/Z XBEPUIviYyJsx+2VCY3/w6LnGlQXg0NdhAEmxw9r/i2ctkxtdcK4cNgPrq3/xf/v22WnxE QSIWrGgfNDcbjN9ie2xhFj461mjXeUUo1k8PXqGYC/xNSwy0Uco9vQ1h9fF/6w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=jDaRzJyO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.69 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tobias.gr header.s=2018 header.b=jDaRzJyO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 300A5AB9F X-Spam-Score: -3.69 X-Migadu-Scanner: scn1.migadu.com X-TUID: oT4I57loOCPw --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Heyo, Nicolas Graves via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > +(define-public passage Thanks! Most points below can be fixed up by a committer, including the=20 description, but those tend to sound better when written by an=20 actual user. If you'd like to give it a try. > + (build-system copy-build-system) > + (propagated-inputs > + (list util-linux git qrencode sed tree age)) Super-nitpick: inputs conventionally hang out a bit lower, under=20 the arguments field. > + (build-system copy-build-system) Duped. > + (arguments > + '(#:phases (modify-phases %standard-phases > + (add-after 'unpack 'rename-exe s/exe/script/ (or sure, executable). > + (lambda _ > + (rename-file "src/password-store.sh" > + "src/passage")))) > + #:install-plan > + (list '("src/passage" "/bin/") > + '("src/completion/pass.bash-completion" > + "/share/bash-completion/completions/") OK, I've been looking at this for an embarrasingly long time=20 trying to figure out what you're trying to communicate with '(=E2=80=A6=20 (list '(=E2=80=A6))). It seems very deliberate. Any hints? :-p > + (home-page "https://github.com/FiloSottile/passage") > + (synopsis "A fork of the password-store encrypted password=20 > manager") Another nitpic^Wcool tip: @command{} & friends work here just as=20 well as in the description. There's no difference. The text should describe the package, not its ancestry. > + (description "This package provides a fork of the=20 > @code{password-store} > +encrypted password manager. It relies on @code{age} instead of > +@code{gnupg}.") Same here. I know all of these words but what do they mean? > + (license license:gpl2+))) Checked. > + > (define-public pass-otp > (package > (name "pass-otp") > I've made the choice to rename the existing passage game to > passage-game in a first commit, I hope it's OK.=20 No, I don't think it is. Adding this script need not affect other=20 packages. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY0IPOw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15qNMA/3egSLheCIye/AweO5qOG4+VMUUIHcvnpN+kW0dd OVEkAP0bsl9mLTn3bwGEigBLmPhvtlG8K15ULQNbf6vJyi87BQ== =07kZ -----END PGP SIGNATURE----- --=-=-=--