unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: pronaip@riseup.net
To: 59152@debbugs.gnu.org
Subject: [bug#59152] disable failing test in earlyoom
Date: Sun, 06 Nov 2022 00:34:00 +0100	[thread overview]
Message-ID: <87fsexynvn.fsf@riseup.net> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: multipart/mixed; boundary="=-=-=", Size: 2204 bytes --]

--=-=-=
Content-Type: text/plain

Wrote this completely on my netbook without compiling Guix, since that
takes literal hours on this machine, but it's a small patch so it should
work.
Also I wanted to see how well one can contribute from limited hardware.

--=-=-=
Content-Type: text/x-patch; charset=utf-8
Content-Disposition: attachment;
 filename=0001-gnu-Disable-failing-test-in-earlyoom.patch
Content-Transfer-Encoding: quoted-printable
Content-Description: disable failing test in earlyoom

From 3963439e518115e379a3726c9290c9f51f7b1c1b Mon Sep 17 00:00:00 2001
From: Csepp <raingloom@riseup.net>
Date: Sun, 6 Nov 2022 00:26:48 +0100
Subject: [PATCH] gnu: Disable failing test in earlyoom.

* gnu/packages/linux.scm (earlyoom)[arguments]: Disable failing test.
---
 gnu/packages/linux.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index cf11a7fc1b..4254cf54cd 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -66,6 +66,7 @@
 ;;; Copyright =C2=A9 2022 muradm <mail@muradm.net>
 ;;; Copyright =C2=A9 2022 Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.or=
g>
 ;;; Copyright =C2=A9 2022 Hunter Jozwiak <hunter.t.joz@gmail.com>
+;;; Copyright =C2=A9 2022 Csepp <raingloom@riseup.net>
=20
 ;;;
 ;;; This file is part of GNU Guix.
@@ -3829,10 +3830,14 @@ (define-public earlyoom
                (setenv "HOME" (getcwd))))
            (add-before 'check 'disable-failing-test
              (lambda _
-               ;; This test relies on writing to /proc/%d/oom_score_adj.
                (substitute* "testsuite_cli_test.go"
+                 ;; Relies on writing to /proc/%d/oom_score_adj.
                  (("TestI" match)
-                  (string-append "skipped" match))))))
+                  (string-append "skipped" match))
+                 ;; Relies on setting niceness to -20.
+                 (("^.*\"-p\".*$" match)
+                  ;; comment out the whole line
+                  (string-append "// skipped: " match))))))
        #:make-flags
        #~(list (string-append "CC=3D" #$(cc-for-target))
                (string-append "VERSION=3Dv" #$version)
--=20
2.38.0


--=-=-=--

             reply	other threads:[~2022-11-09 17:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05 23:34 pronaip [this message]
2022-11-20 10:45 ` bug#59152: disable failing test in earlyoom Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsexynvn.fsf@riseup.net \
    --to=pronaip@riseup.net \
    --cc=59152@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).