On 2023-01-18, Maxim Cournoyer wrote:
> Vagrant Cascadian <vagrant@reproducible-builds.org> writes:
>> Subject: [PATCH 2/2] gnu: diffoscope: Update to 232.
>>
>> * gnu/packages/diffoscope.scm (diffoscope): Update to 232.
>>   [native-inputs]: Add lzip and python-pdf, drop python-pypdf2.
>>   [phases]: Add lzip-external-tool and remove-mono-external-tool.
>
> Nitpick: GNU Change Logs style doesn't use a hanging indent in the left
> margin (see: info '(standards) Style of Change Logs').

Wow, I think every single one of my commits to date has that issue... hah!


>> diff --git a/gnu/packages/diffoscope.scm b/gnu/packages/diffoscope.scm
>> index f730d976fe..59875c2e8e 100644
>> --- a/gnu/packages/diffoscope.scm
>> +++ b/gnu/packages/diffoscope.scm
...
>> +                  (add-after 'unpack 'remove-mono-external-tool
>> +                    ;; Fixed upstream, remove this phase when updating to
>> +                    ;; diffoscope 233
>> +                    (lambda _
>> +                      (substitute* "diffoscope/external_tools.py"
>> +                        ;; "guix": "mono",
>> +                        ((".guix.: .mono.,")
>> +                         ""))))
>>                    (add-after 'build 'build-man-page
>>                      (lambda* (#:key (make-flags '()) #:allow-other-keys)
>
> There are no #:make-flags argument for the python or pyproject build
> systems, so that's useless.

I would welcome a fix for that... I could not figure out how to make it
build successfully without it, but that does not say a whole lot. :)

live well,
  vagrant