unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: 61226@debbugs.gnu.org
Subject: [bug#61226] Decouple w3m from xdg-utils test suite
Date: Wed, 08 Feb 2023 23:06:29 -0500	[thread overview]
Message-ID: <87fsbfiit6.fsf_-_@gmail.com> (raw)
In-Reply-To: <935e58c604d205cf0178cefb04e5508b8530422c.1675437676.git.leo@famulari.name> (Leo Famulari's message of "Fri, 3 Feb 2023 16:21:17 +0100")

Hi,

Leo Famulari <leo@famulari.name> writes:

> * gnu/packages/freedesktop.scm (xdg-utils)[native-inputs]: Replace w3m with
> w3m-for-tests.
> [arguments]: Use #:disallowed-references to prevent keeping a reference to
> w3m-for-tests.
> ---
>  gnu/packages/freedesktop.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/freedesktop.scm b/gnu/packages/freedesktop.scm
> index a986c8c350..677ab5fdf2 100644
> --- a/gnu/packages/freedesktop.scm
> +++ b/gnu/packages/freedesktop.scm
> @@ -482,7 +482,7 @@ (define-public xdg-utils
>               "1nai806smz3zcb2l5iny4x7li0fak0rzmjg6vlyhdqm8z25b166p"))))
>      (build-system gnu-build-system)
>      (native-inputs
> -     (list docbook-xsl docbook-xml-4.1.2 libxslt w3m xmlto))
> +     (list docbook-xsl docbook-xml-4.1.2 libxslt w3m-for-tests xmlto))
>      (inputs
>       `(("awk" ,gawk)
>         ;; TODO(staging): Make this unconditional, to avoid canonical packages,
> @@ -501,7 +501,9 @@ (define-public xdg-utils
>         ("xprop" ,xprop) ; for Xfce detecting
>         ("xset" ,xset))) ; for xdg-screensaver
>      (arguments
> -     `(#:tests? #f   ; no check target
> +     `(; Ensure we don't keep a reference to this old version of w3m

I was confused by the "old version".  Perhaps rephrase to "[...] this
potentially old version [...]" ?

> +       #:disallowed-references (,w3m-for-tests)
> +       #:tests? #f   ; no check target
>         #:modules ((srfi srfi-26)
>                    ,@%gnu-build-system-modules)
>         #:phases

Otherwise, LGTM!

-- 
Thanks,
Maxim




  reply	other threads:[~2023-02-09  4:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02 11:32 [bug#61226] Decouple w3m from xdg-utils test suite Leo Famulari
2023-02-02 11:38 ` [bug#61226] [PATCH 1/5] gnu: linux-libre: Update to 6.1.9 Leo Famulari
2023-02-02 11:38   ` [bug#61226] [PATCH 2/5] gnu: linux-libre 5.15: Update to 5.15.91 Leo Famulari
2023-02-02 11:38   ` [bug#61226] [PATCH 3/5] gnu: linux-libre 5.10: Update to 5.10.166 Leo Famulari
2023-02-02 11:38   ` [bug#61226] [PATCH 4/5] gnu: Add a pinned-version variant of w3m Leo Famulari
2023-02-02 11:38   ` [bug#61226] [PATCH 5/5] gnu: xdg-utils: Use a pinned version " Leo Famulari
2023-02-03 15:22   ` [bug#61226] [PATCH 1/5] gnu: linux-libre: Update to 6.1.9 Leo Famulari
2023-02-03  4:18 ` [bug#61226] Decouple w3m from xdg-utils test suite André Batista
2023-02-05 13:11   ` Leo Famulari
2023-02-03 15:21 ` [bug#61226] [PATCH v2 1/2] gnu: Add a pinned-version variant of w3m Leo Famulari
2023-02-03 15:21   ` [bug#61226] [PATCH v2 2/2] gnu: xdg-utils: Use a pinned version " Leo Famulari
2023-02-09  4:06     ` Maxim Cournoyer [this message]
2023-02-09  4:05   ` [bug#61226] Decouple w3m from xdg-utils test suite Maxim Cournoyer
2023-03-26 20:04 ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fsbfiit6.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=61226@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).