unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#62712] [PATCH 0/2] Disable keyword expansion for Subversion downloads
@ 2023-04-07 14:05 Ludovic Courtès
  2023-04-07 14:07 ` [bug#62712] [PATCH 1/2] svn-download: Disable keyword expansion Ludovic Courtès
  0 siblings, 1 reply; 18+ messages in thread
From: Ludovic Courtès @ 2023-04-07 14:05 UTC (permalink / raw)
  To: 62712; +Cc: Ludovic Courtès, Timothy Sample, zimoun

Hello Guix!

As discussed in <https://issues.guix.gnu.org/43442>, SVN keyword
expansion during checkout is problematic because it depends on local
timezone.  This in itself isn't really a problem in Guix because
the timezone in the environment of fixed-output derivations is
always UTC.  However, SWH disables keyword expansion (for this
reason), and thus it makes sense to follow suit.

Disabling keyword expansion entails many rebuilds.  However, these
are "safe", so I'd like to have them on a branch (or simply handled
by qa.guix) that we'd merge as soon as it's built.

The second patch makes ‘recursive?’ default to #f, which AFAICS
is what all the SVN-using packages that were not explicit expected
(no changes required).

Thoughts?

Ludo’.

Ludovic Courtès (2):
  svn-download: Disable keyword expansion.
  svn-download: Default to non-recursive checkouts.

 gnu/packages/java.scm             |  2 +-
 gnu/packages/machine-learning.scm |  2 +-
 gnu/packages/tex.scm              | 16 ++++++++--------
 gnu/packages/video.scm            |  4 ++--
 guix/build/svn.scm                |  9 ++++++++-
 guix/svn-download.scm             |  6 +++---
 6 files changed, 23 insertions(+), 16 deletions(-)


base-commit: 47fe66586e0fbc177288ec91cc88ea0b081505b0
-- 
2.39.2





^ permalink raw reply	[flat|nested] 18+ messages in thread

end of thread, other threads:[~2023-06-18 21:22 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-07 14:05 [bug#62712] [PATCH 0/2] Disable keyword expansion for Subversion downloads Ludovic Courtès
2023-04-07 14:07 ` [bug#62712] [PATCH 1/2] svn-download: Disable keyword expansion Ludovic Courtès
2023-04-07 14:07   ` [bug#62712] [PATCH 2/2] svn-download: Default to non-recursive checkouts Ludovic Courtès
2023-04-07 16:54   ` [bug#62712] [PATCH 0/2] Disable keyword expansion for Subversion downloads Timothy Sample
2023-04-08 21:23     ` Ludovic Courtès
2023-04-09 21:31       ` Christopher Baines
2023-04-12 13:49         ` Christopher Baines
2023-04-20  9:57           ` Ludovic Courtès
2023-04-25 12:41             ` Simon Tournier
2023-05-05 14:09             ` Simon Tournier
2023-05-06  0:22               ` Nicolas Goaziou
2023-05-09 12:22                 ` Simon Tournier
2023-05-10 16:22                   ` Ludovic Courtès
2023-05-11 21:40                     ` Nicolas Goaziou
2023-05-12 11:45                       ` Christopher Baines
2023-05-15 15:50                         ` Nicolas Goaziou
2023-05-16  9:54                           ` Christopher Baines
2023-06-18 21:21                             ` bug#62712: " Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).