From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id aFn+F78/Z2T9KAEASxT56A (envelope-from ) for ; Fri, 19 May 2023 11:22:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GIr/F78/Z2TyqAAA9RJhRA (envelope-from ) for ; Fri, 19 May 2023 11:22:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D1090AA8E for ; Fri, 19 May 2023 11:22:06 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzwJI-0006ve-Cs; Fri, 19 May 2023 05:22:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzwJG-0006p0-F8 for guix-patches@gnu.org; Fri, 19 May 2023 05:22:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzwJG-0004Jz-6W for guix-patches@gnu.org; Fri, 19 May 2023 05:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzwJG-0007pR-0q for guix-patches@gnu.org; Fri, 19 May 2023 05:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63527] [PATCH 0/3] Initial attempt at rumpdisk support for the Hurd. Resent-From: Janneke Nieuwenhuizen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 May 2023 09:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63527 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 63527@debbugs.gnu.org Received: via spool by 63527-submit@debbugs.gnu.org id=B63527.168448808730048 (code B ref 63527); Fri, 19 May 2023 09:22:01 +0000 Received: (at 63527) by debbugs.gnu.org; 19 May 2023 09:21:27 +0000 Received: from localhost ([127.0.0.1]:55443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzwIg-0007oa-Me for submit@debbugs.gnu.org; Fri, 19 May 2023 05:21:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzwIe-0007oL-3z for 63527@debbugs.gnu.org; Fri, 19 May 2023 05:21:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzwIX-00049u-Sf; Fri, 19 May 2023 05:21:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=81LjHlo76MO6afhBX0/ZS2pQrxbXcJqH81vJSDIWgCA=; b=kQeArzCf9w/gxDdx/Dwm +U7nCkcO1Y6USI8VtByFGI8JZ3ukauTbFbvZXALsGFEWBOn2AoqZNEr1AL/oeFn3+FObnckUqNOoC cwL4/Dbx1L0py9ik7R5/KjZ7Z3z2jclJWAGoJhnnuEtz51LABYFBGhpOf2xLr1wNJ7GswE2w4xgL7 HPxwa/PWXD3rydUK7F67vHhMnIDNx4AXwyth9XpQmTv1pLrspedDSeL+d0zrTu5fsiifZcdY/Ace3 6N1iF23t0/XayNqGKrJAO0kdQ6tf5LMiE98IzD1iDYSR9MBIPp+l/WxAQwO4nQauhWCk9yDtboh/N tW/GioYF90GWzw==; Received: from 2a02-a462-da03-1-2701-7f81-a736-4607.fixed6.kpn.net ([2a02:a462:da03:1:2701:7f81:a736:4607] helo=drakenpad.janneke.lilypond.org) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzwIM-0001vG-Am; Fri, 19 May 2023 05:21:17 -0400 From: Janneke Nieuwenhuizen Organization: AvatarAcademy.nl References: <87wn1536g8.fsf_-_@gnu.org> X-Url: http://AvatarAcademy.nl Date: Fri, 19 May 2023 11:21:01 +0200 In-Reply-To: <87wn1536g8.fsf_-_@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 18 May 2023 19:17:11 +0200") Message-ID: <87fs7sfzia.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684488127; a=rsa-sha256; cv=none; b=s41CHnSd+w9Qx//Y4uWKN3VOckbq2iHIsUC6wWLArp/wpTNLoHI3GYMtitSZKfMo1gqfSw lGul9eOjL+QfCGhDHctTJzeRKEipHW5Vnvq5fSMn8cC+tMAUAbAwEaHAl2whMl5LF/9Sh7 uZIXo7bmjHO6HMGvPEH0+6k+YfPsFvbHeTgR9fb5C1Y6bfO1FWe89kItazNzmSmTx3HsjV 0rqskfdOaQQ7rtw6vCD8MYHGaT+e0H1RXi5jd9OcCCKSomqwFF2v8k7/s8k5CPvXWQdjPH ksc2d/IrhoJuyTRgO1h5sCzxgaQP4zCmVmYKQ1Iwxvh8QiLvNkO9hSOMNzMoIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=kQeArzCf; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684488127; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=81LjHlo76MO6afhBX0/ZS2pQrxbXcJqH81vJSDIWgCA=; b=lBZohho2q1ur4azUWkzKp/lov9gbvyyPVcroqX625gBrpSQiTSwpyALsDYOw5XLao8D2Ox JtFmfqr8dMb4eiht0QKPF3SO/ETRLnoTvsNbQQI2DwKGMgna3gyPNyO4zEPolEtOpHFIvF kpt2oYVLSE3/7XLT1SfLp4d7T+27kKbW3FWrvmvCB/IMM/Gh9BqZlETitZuSwp032HyY9w ONUIO3UMN6PrrcAbbhg9f8ievhWQChejilvbiaSjdy8iT3DIF/wYKfaSj/mNsCxRcf+BJt /miPLoJmLF7Ml301vSpaFf8hbe+j19jSZDmXJxzFsjTpKRh6CG1vteY2wMzeTA== X-Migadu-Spam-Score: -2.11 X-Spam-Score: -2.11 X-Migadu-Queue-Id: D1090AA8E X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=kQeArzCf; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: UzfF36qWvMgE Ludovic Court=C3=A8s writes: > Janneke Nieuwenhuizen skribis: > >> This uses the Debian Salsa rumpkernel package git as upstream as that is= where >> delopment happens. Once things have stabalized upstream may change to t= he >> NetBSD git from where Debian takes their snapshots. > > Could you make it a comment close to the =E2=80=98origin=E2=80=99 form? That makes sense, so it doesn't get lost, done. >> * gnu/packages/hurd.scm (rumpkernel): New variable. > > [=E2=80=A6] > >> + #~(modify-phases %standard-phases > > You can tell from the phases that it took of lot of sweat to get there. > :-) > > Could you add a few comments while it=E2=80=99s fresh on your mind to exp= lain > the various tweaks? The =E2=80=98build=E2=80=99 phase is particularly in= timidating. I have added a general comment ;; As we are using the Debian package as upstream, we follow their ;; build: ;; * apply patches in debian/patches taken from the ;; debian/patches/series file ;; * for the configure, make, and install stages, follow ;; the code in debian/rules ;; The Debian patchset includes a cross build feature that we ;; use with two differences ;; * Debian uses a multiarch toolchain ;; * we use cross-mig #:phases #~(modify-phases %standard-phases a comment before 'build ;; The build has three toplevel entry points ;; * buildrump.sh/src/build.sh: create a NetBSD-compatible ;; toolchain and supports cross-compiling ;; * buildrump.sh/src/lib/librumpuser: the librump* libraries ;; * pci-userspace/src-gnu: the librumpdev_pci* libraries (replace 'build and a comment in install ;; Some libraries are duplicated/copied around in the ;; build system, do not fail trying to install one ;; a second time. (if (file-exists? dest) (format (current-error-port) "warning: skipping: ~a\n" file) >> + (native-inputs >> + (list >> + autoconf >> + automake >> + libgcrypt >> + (if (%current-target-system) >> + (let* ((cross-base (resolve-interface '(gnu packages cross-= base))) >> + (cross-mig (module-ref cross-base 'cross-mig))) >> + (cross-mig (%current-target-system))) >> + mig) > > I think you could #:use-module (gnu packages cross-base) and refer to > =E2=80=98cross-mig=E2=80=99 directly. Right. Weird, other packages do it like this and I copied without thinking. Possibly there was a circular dependency before? > Also, watch out the indentation. ;-) > > (native-inputs > (list autoconf > automake > =E2=80=A6)) Ah, changed. I need to remember this, I'm a sucker for M-x sort-lines. >> + (license (list >> + asl2.0 >> + boost1.0 > Could you add a comment above briefly stating what this list means? (I > suppose each license applies to a specific part of the source?) Changed to (license ;; The NetBSD rumpkernel code is a big hodgepodge of softwares many = of ;; which have their own different licensing terms, see also ;; https://salsa.debian.org/hurd-team/rumpkernel/-/blob/master/debia= n/copyright (list asl2.0 boost1.0 ... > Anyhow, well done! Yay! (A v5 patch series with this to follow once we have figured out the glibc/hurd patching problem.) Greetings, --=20 Janneke Nieuwenhuizen | GNU LilyPond https://LilyPond.org Freelance IT https://www.JoyOfSource.com | Avatar=C2=AE https://AvatarAcade= my.com