unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrew Tropin <andrew@trop.in>
To: jlicht@fsfe.org, 64155@debbugs.gnu.org
Cc: Jelle Licht <jlicht@fsfe.org>,
	Liliana Marie Prikler <liliana.prikler@gmail.com>
Subject: [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0.
Date: Mon, 19 Jun 2023 17:44:45 +0400	[thread overview]
Message-ID: <87fs6ntvle.fsf@trop.in> (raw)
In-Reply-To: <97c1eb6e58e07feaef29a1b10eeabb09f870bee1.1687117071.git.jlicht@fsfe.org>

[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]

On 2023-06-18 21:38, jlicht@fsfe.org wrote:

> From: Jelle Licht <jlicht@fsfe.org>
>
> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
> [propagated-inputs]: Add emacs-debbugs.
> ---
>
>  gnu/packages/emacs-xyz.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index f46af73aec..08ec87b94c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
>  (define-public emacs-piem
>    (package
>      (name "emacs-piem")
> -    (version "0.4.0")
> +    (version "0.5.0")
>      (source
>       (origin
>         (method git-fetch)
> @@ -8346,7 +8346,7 @@ (define-public emacs-piem
>               (commit (string-append "v" version))))
>         (file-name (string-append name "-" version "-checkout"))
>         (sha256
> -        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
> +        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
>      (build-system emacs-build-system)
>      (arguments
>       (list #:phases
> @@ -8359,7 +8359,8 @@ (define-public emacs-piem
>      (inputs
>       (list b4))
>      (propagated-inputs
> -     (list emacs-elfeed
> +     (list emacs-debbugs
> +           emacs-elfeed
>             emacs-notmuch))
>      (home-page "https://docs.kyleam.com/piem")
>      (synopsis "Glue for working with public-inbox archives")
>
> base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e

Hi Jelle!

Thank you very much for the patch.

IMHO, optional dependencies should not be propagated.  On user side
installing additional packages is easier than transforming existing
package and removing unneeded propagated deps.  Personally, I would
remove all the propagated inputs from piem and let the user install what
he needs for his particular use case.

Liliana, Jelle WDYT?

-- 
Best regards,
Andrew Tropin

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2023-06-19 13:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-18 19:38 [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0 jlicht
2023-06-19 13:44 ` Andrew Tropin [this message]
2023-06-19 15:39   ` Jelle Licht
2023-06-19 16:32     ` Andrew Tropin
2023-06-19 18:24   ` Liliana Marie Prikler
2023-06-19 19:35 ` [bug#64155] [PATCH v2 1/2] gnu: emacs-piem: Do not propagate any inputs jlicht
2023-06-19 19:35   ` [bug#64155] [PATCH v2 2/2] gnu: emacs-piem: Update to 0.5.0 jlicht
2023-06-20  3:23     ` Andrew Tropin
2023-06-20 19:10       ` bug#64155: " Jelle Licht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs6ntvle.fsf@trop.in \
    --to=andrew@trop.in \
    --cc=64155@debbugs.gnu.org \
    --cc=jlicht@fsfe.org \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).