unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#65088] [PATCH] gnu: emacs-helpful: Update to 0.21.
@ 2023-08-05 10:40 Cayetano Santos via Guix-patches via
  2023-08-05 11:22 ` Hilton Chain via Guix-patches via
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2023-08-05 10:40 UTC (permalink / raw)
  To: 65088; +Cc: Cayetano Santos

* gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
---
 gnu/packages/emacs-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ed3d89d51f..c01192b7b3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -24360,11 +24360,11 @@ (define-public emacs-download-region
       (license license:gpl3+))))
 
 (define-public emacs-helpful
-  (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
-        (revision "1"))
+  (let ((commit "ced07fe0d48ce1111d7a8376fdbfef34d927c967")
+        (revision "0"))
     (package
       (name "emacs-helpful")
-      (version (git-version "0.19" revision commit))
+      (version (git-version "0.21" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -24373,7 +24373,7 @@ (define-public emacs-helpful
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l"))))
+          (base32 "03afgdbs5nmhw833svrqky7fmfs1zlvqzcj7j5g29sakivs60xqc"))))
       (build-system emacs-build-system)
       (propagated-inputs
        (list emacs-dash emacs-elisp-refs emacs-f emacs-s))

base-commit: 42ae42cf41e8f5e88422e30d801251a3427d7f3b
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#65088] [PATCH] gnu: emacs-helpful: Update to 0.21.
  2023-08-05 10:40 [bug#65088] [PATCH] gnu: emacs-helpful: Update to 0.21 Cayetano Santos via Guix-patches via
@ 2023-08-05 11:22 ` Hilton Chain via Guix-patches via
  2023-08-05 17:25 ` [bug#65088] [PATCH v1] " Cayetano Santos via Guix-patches via
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Hilton Chain via Guix-patches via @ 2023-08-05 11:22 UTC (permalink / raw)
  To: Cayetano Santos; +Cc: 65088

Hi Cayetano,

On Sat, 05 Aug 2023 18:40:08 +0800,
Cayetano Santos via Guix-patches via wrote:
> 
> * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
> ---
>  gnu/packages/emacs-xyz.scm | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index ed3d89d51f..c01192b7b3 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -24360,11 +24360,11 @@ (define-public emacs-download-region
>        (license license:gpl3+))))
>  
>  (define-public emacs-helpful
> -  (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
> -        (revision "1"))
> +  (let ((commit "ced07fe0d48ce1111d7a8376fdbfef34d927c967")
> +        (revision "0"))
>      (package
>        (name "emacs-helpful")
> -      (version (git-version "0.19" revision commit))
> +      (version (git-version "0.21" revision commit))
>        (source
>         (origin
>           (method git-fetch)
> @@ -24373,7 +24373,7 @@ (define-public emacs-helpful
>                 (commit commit)))

Since it's a tagged release, we can remove the `let' form, use only
"0.21" for version, and `version' for commit.

Thanks




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#65088] [PATCH v1] gnu: emacs-helpful: Update to 0.21.
  2023-08-05 10:40 [bug#65088] [PATCH] gnu: emacs-helpful: Update to 0.21 Cayetano Santos via Guix-patches via
  2023-08-05 11:22 ` Hilton Chain via Guix-patches via
@ 2023-08-05 17:25 ` Cayetano Santos via Guix-patches via
  2023-08-07 11:42   ` Hilton Chain via Guix-patches via
  2023-08-07 12:11 ` [bug#65088] [PATCH v2] " Cayetano Santos via Guix-patches via
  2023-08-27  3:51 ` bug#65088: [PATCH] " Hilton Chain via Guix-patches via
  3 siblings, 1 reply; 6+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2023-08-05 17:25 UTC (permalink / raw)
  To: 65088; +Cc: Cayetano Santos

* gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
---
 gnu/packages/emacs-xyz.scm | 48 ++++++++++++++++++--------------------
 1 file changed, 23 insertions(+), 25 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ed3d89d51f..9ecc58d7d6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -24360,31 +24360,29 @@ (define-public emacs-download-region
       (license license:gpl3+))))
 
 (define-public emacs-helpful
-  (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
-        (revision "1"))
-    (package
-      (name "emacs-helpful")
-      (version (git-version "0.19" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/Wilfred/helpful")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l"))))
-      (build-system emacs-build-system)
-      (propagated-inputs
-       (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
-      (native-inputs
-       (list emacs-ert-runner emacs-undercover))
-      (arguments
-       `(#:tests? #t
-         #:test-command '("ert-runner")))
-      (home-page "https://github.com/Wilfred/helpful")
-      (synopsis "More contextual information in Emacs help")
-      (description "@code{helpful} is an alternative to the built-in Emacs help
+  (package
+    (name "emacs-helpful")
+    (version "0.21")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Wilfred/helpful")
+             (commit "0.21")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "03afgdbs5nmhw833svrqky7fmfs1zlvqzcj7j5g29sakivs60xqc"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
+    (native-inputs
+     (list emacs-ert-runner emacs-undercover))
+    (arguments
+     `(#:tests? #t
+       #:test-command '("ert-runner")))
+    (home-page "https://github.com/Wilfred/helpful")
+    (synopsis "More contextual information in Emacs help")
+    (description "@code{helpful} is an alternative to the built-in Emacs help
 that provides much more contextual information.
 
 @itemize

base-commit: 42ae42cf41e8f5e88422e30d801251a3427d7f3b
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#65088] [PATCH v1] gnu: emacs-helpful: Update to 0.21.
  2023-08-05 17:25 ` [bug#65088] [PATCH v1] " Cayetano Santos via Guix-patches via
@ 2023-08-07 11:42   ` Hilton Chain via Guix-patches via
  0 siblings, 0 replies; 6+ messages in thread
From: Hilton Chain via Guix-patches via @ 2023-08-07 11:42 UTC (permalink / raw)
  To: Cayetano Santos; +Cc: 65088

Hi Cayetano,

On Sun, 06 Aug 2023 01:25:57 +0800,
Cayetano Santos via Guix-patches via wrote:
>
> * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
> ---
>  gnu/packages/emacs-xyz.scm | 48 ++++++++++++++++++--------------------
>  1 file changed, 23 insertions(+), 25 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index ed3d89d51f..9ecc58d7d6 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -24360,31 +24360,29 @@ (define-public emacs-download-region
>        (license license:gpl3+))))
>
>  (define-public emacs-helpful
> -  (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
> -        (revision "1"))
> -    (package
> -      (name "emacs-helpful")
> -      (version (git-version "0.19" revision commit))
> -      (source
> -       (origin
> -         (method git-fetch)
> -         (uri (git-reference
> -               (url "https://github.com/Wilfred/helpful")
> -               (commit commit)))
> -         (file-name (git-file-name name version))
> -         (sha256
> -          (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l"))))
> -      (build-system emacs-build-system)
> -      (propagated-inputs
> -       (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
> -      (native-inputs
> -       (list emacs-ert-runner emacs-undercover))
> -      (arguments
> -       `(#:tests? #t
> -         #:test-command '("ert-runner")))
> -      (home-page "https://github.com/Wilfred/helpful")
> -      (synopsis "More contextual information in Emacs help")
> -      (description "@code{helpful} is an alternative to the built-in Emacs help
> +  (package
> +    (name "emacs-helpful")
> +    (version "0.21")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/Wilfred/helpful")
> +             (commit "0.21")))


The version specified in the `version' field is available as a
variable, so `(commit version)' can be used instead.


> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "03afgdbs5nmhw833svrqky7fmfs1zlvqzcj7j5g29sakivs60xqc"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
> +    (native-inputs
> +     (list emacs-ert-runner emacs-undercover))
> +    (arguments
> +     `(#:tests? #t
> +       #:test-command '("ert-runner")))
> +    (home-page "https://github.com/Wilfred/helpful")
> +    (synopsis "More contextual information in Emacs help")
> +    (description "@code{helpful} is an alternative to the built-in Emacs help
>  that provides much more contextual information.
>
>  @itemize
>
> base-commit: 42ae42cf41e8f5e88422e30d801251a3427d7f3b
> --
> 2.41.0


There's an extra parenthesis to remove ;)
--8<---------------cut here---------------start------------->8---
-      (license license:gpl3+))))
+    (license license:gpl3+)))
--8<---------------cut here---------------end--------------->8---

Thanks




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#65088] [PATCH v2] gnu: emacs-helpful: Update to 0.21.
  2023-08-05 10:40 [bug#65088] [PATCH] gnu: emacs-helpful: Update to 0.21 Cayetano Santos via Guix-patches via
  2023-08-05 11:22 ` Hilton Chain via Guix-patches via
  2023-08-05 17:25 ` [bug#65088] [PATCH v1] " Cayetano Santos via Guix-patches via
@ 2023-08-07 12:11 ` Cayetano Santos via Guix-patches via
  2023-08-27  3:51 ` bug#65088: [PATCH] " Hilton Chain via Guix-patches via
  3 siblings, 0 replies; 6+ messages in thread
From: Cayetano Santos via Guix-patches via @ 2023-08-07 12:11 UTC (permalink / raw)
  To: 65088; +Cc: Cayetano Santos

* gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
---
 gnu/packages/emacs-xyz.scm | 50 ++++++++++++++++++--------------------
 1 file changed, 24 insertions(+), 26 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ed3d89d51f..d03a9a91f4 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -24360,31 +24360,29 @@ (define-public emacs-download-region
       (license license:gpl3+))))
 
 (define-public emacs-helpful
-  (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
-        (revision "1"))
-    (package
-      (name "emacs-helpful")
-      (version (git-version "0.19" revision commit))
-      (source
-       (origin
-         (method git-fetch)
-         (uri (git-reference
-               (url "https://github.com/Wilfred/helpful")
-               (commit commit)))
-         (file-name (git-file-name name version))
-         (sha256
-          (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l"))))
-      (build-system emacs-build-system)
-      (propagated-inputs
-       (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
-      (native-inputs
-       (list emacs-ert-runner emacs-undercover))
-      (arguments
-       `(#:tests? #t
-         #:test-command '("ert-runner")))
-      (home-page "https://github.com/Wilfred/helpful")
-      (synopsis "More contextual information in Emacs help")
-      (description "@code{helpful} is an alternative to the built-in Emacs help
+  (package
+    (name "emacs-helpful")
+    (version "0.21")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/Wilfred/helpful")
+             (commit "0.21")))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "03afgdbs5nmhw833svrqky7fmfs1zlvqzcj7j5g29sakivs60xqc"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     (list emacs-dash emacs-elisp-refs emacs-f emacs-s))
+    (native-inputs
+     (list emacs-ert-runner emacs-undercover))
+    (arguments
+     `(#:tests? #t
+       #:test-command '("ert-runner")))
+    (home-page "https://github.com/Wilfred/helpful")
+    (synopsis "More contextual information in Emacs help")
+    (description "@code{helpful} is an alternative to the built-in Emacs help
 that provides much more contextual information.
 
 @itemize
@@ -24403,7 +24401,7 @@ (define-public emacs-helpful
 @item Trace, disassemble functions from inside Helpful.  This is discoverable
 and doesn't require memorisation of commands.
 @end itemize\n")
-      (license license:gpl3+))))
+    (license license:gpl3+)))
 
 (define-public emacs-logview
   (package

base-commit: 42ae42cf41e8f5e88422e30d801251a3427d7f3b
-- 
2.41.0





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#65088: [PATCH] gnu: emacs-helpful: Update to 0.21.
  2023-08-05 10:40 [bug#65088] [PATCH] gnu: emacs-helpful: Update to 0.21 Cayetano Santos via Guix-patches via
                   ` (2 preceding siblings ...)
  2023-08-07 12:11 ` [bug#65088] [PATCH v2] " Cayetano Santos via Guix-patches via
@ 2023-08-27  3:51 ` Hilton Chain via Guix-patches via
  3 siblings, 0 replies; 6+ messages in thread
From: Hilton Chain via Guix-patches via @ 2023-08-27  3:51 UTC (permalink / raw)
  To: Cayetano Santos; +Cc: 65088-done

Hi Cayetano,

On Sat, 05 Aug 2023 18:40:08 +0800,
Cayetano Santos via Guix-patches via wrote:
>
> * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.21.
> ---

I have applied v2 as 5476f79e41c843a7ee43f6fcf64039f527b9f21e, with
(commit "0.21") changed to (commit version).  Thanks!




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-08-27  4:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-05 10:40 [bug#65088] [PATCH] gnu: emacs-helpful: Update to 0.21 Cayetano Santos via Guix-patches via
2023-08-05 11:22 ` Hilton Chain via Guix-patches via
2023-08-05 17:25 ` [bug#65088] [PATCH v1] " Cayetano Santos via Guix-patches via
2023-08-07 11:42   ` Hilton Chain via Guix-patches via
2023-08-07 12:11 ` [bug#65088] [PATCH v2] " Cayetano Santos via Guix-patches via
2023-08-27  3:51 ` bug#65088: [PATCH] " Hilton Chain via Guix-patches via

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).