From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OHxcEh6F+GTlQQAAG6o9tA:P1 (envelope-from ) for ; Wed, 06 Sep 2023 15:56:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OHxcEh6F+GTlQQAAG6o9tA (envelope-from ) for ; Wed, 06 Sep 2023 15:56:46 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EB85A58FD1 for ; Wed, 6 Sep 2023 15:56:45 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=bvIm4vGp; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1694008606; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=QitFz2Q+mSIjhEZHG63i7ulr4RiBcFdQP649OBB0q6s=; b=WeBsqGIhe/RMm2JYSs4dtTZjvHHSsxUHOK/s4W98W7+t2jf4xE+tPaGxdwUA0kP9Jz4wXE NzuAuXwq6tYNw3lyw29AK49pK04cD443MSDblFyXr0NZZYFkJjv0waHK+6hS8GE+QJTPuq XKACa9sCgbFzT6+wlBbB460wIC6RFhxJSbKXZaPfQJfKpiQvh4p0Eobdmwym7PRezAj4sv ybeOmcHIuI78j2nV/QanOQlm5pP0qgLvCoVP10KTGGfxvkIBb5jfncZ4m5UP0bsEzILLys DpJdFp4WFExFBPJzDIq4vNo42/+Ry/1jPhRrJCnKvS4XyWyORT5gVItKkAH7zg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1694008606; a=rsa-sha256; cv=none; b=JYYsH7EINopM8ftZXf5vFV00Zn8QdPDgRhJzsXvbgDsooD/16sMpePMPz9H5JYgOfBaoxB uVdSLB0EQVGVjqZpxk05NlnmQthvFZFG+vDGUB5UMS4fko4xu3hAS2aFZAdpe2YAVDPyrM /ZybaLKbjdG319+NjO8Wp0vczoIM3VoQGIGiCOH7oJno03YEkhsfZIQX8jcGDHzSdvwY51 hxxFdOnPvIyswjPJ4gBoGbmID7oqrPY1qT3cxEIy9Um2RE85HJTmX3qbCz1o3/yLucyZD+ 07vVEEdkxuJAyw6GzseixqkEGnUyIHDyaCt6g/rauhumjegOerax3HfihO/E4w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=bvIm4vGp; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdt14-0006Py-Km; Wed, 06 Sep 2023 09:56:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdt0z-0006Ou-Kf for guix-patches@gnu.org; Wed, 06 Sep 2023 09:56:18 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdt0k-00066p-My for guix-patches@gnu.org; Wed, 06 Sep 2023 09:56:16 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdt0l-0002Wo-OU for guix-patches@gnu.org; Wed, 06 Sep 2023 09:56:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#64179] [PATCH] gnu: Add wasm-micro-runtime. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 06 Sep 2023 13:56:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64179 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Felix Lechner Cc: 64179@debbugs.gnu.org Received: via spool by 64179-submit@debbugs.gnu.org id=B64179.16940085599497 (code B ref 64179); Wed, 06 Sep 2023 13:56:03 +0000 Received: (at 64179) by debbugs.gnu.org; 6 Sep 2023 13:55:59 +0000 Received: from localhost ([127.0.0.1]:35034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdt0h-0002S1-BK for submit@debbugs.gnu.org; Wed, 06 Sep 2023 09:55:59 -0400 Received: from mail-oi1-x22d.google.com ([2607:f8b0:4864:20::22d]:55340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdt0e-0002MR-W2 for 64179@debbugs.gnu.org; Wed, 06 Sep 2023 09:55:57 -0400 Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3a812843f0fso2085722b6e.2 for <64179@debbugs.gnu.org>; Wed, 06 Sep 2023 06:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694008550; x=1694613350; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=QitFz2Q+mSIjhEZHG63i7ulr4RiBcFdQP649OBB0q6s=; b=bvIm4vGp6dFf128HDXmL19ezmt2QfUNLvVm67GQJHgkgi7L+n1H+CfswBibCoqP5Xs JpBi6Y13tUtfwp75cV58yg1pwX3zcOXna4BJ1S+5/z7ChNaxJbcFgo3CMRN5KKr8lnVT 86CH3C1E8F0uGY78eAJVaOdw+isnIRkePt/4QWYAQhY5f/LiCGaadEzHEsgncqUbboZF GfCi4I75uNt9LCZ3Si2wOu6ZOByWa4kS4t/5AkVQHAl7OJBvi1q1V0g6DPVg4HyXGkxX pT3V2BskEgsMLIxWK3MFukARz2HTE44YwfzMqh3t883gB2t2sdSm1qgC5YndUfwPgyRV wsVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694008550; x=1694613350; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QitFz2Q+mSIjhEZHG63i7ulr4RiBcFdQP649OBB0q6s=; b=LpOrMw+l/txMMNsrIQn9wuATfDRTNNTLk4O1pssMq/Jx+IydONrMg2d99Ij7HLZuES LnZn32QGBPjMK6dfK+4QCjMxdY/WYaZ43ieRSnt2p6YqvSwDpBrArqcrU5WiY8zYCvI2 w90gJozMsS5Pvj6JAsg+UsKXsxZm43ZHEEzn8o4iIoQKZuAL5nlXi+d1mkMzjp6HpQJ3 YdBgfTOqpTakMgzVkfA26EHPjx6shG6tBMLx7sHd6OGL8CO5o9bZ/sgYTTOBJWHspHf4 zC5nRduwsgXe6Rim5x/doVai8kzYICrdziO5We1ajcJ3NT/HYux/NYuxeVO6Cjw3D3E4 kY8g== X-Gm-Message-State: AOJu0YzxoWl4seUK4RHfBsM5XsrCmcKARNPyebj5h9MYNSdKPKMz9Ibn 7Deg2FB/w158vNdsjkUgeoD607uV/Rh6vg== X-Google-Smtp-Source: AGHT+IHnIFA94B2qOlSWReK9vYq9MckWqXyPI35m9ltT4yIsltYNcde8P/wkruFsYVHLgGmNqmR2fA== X-Received: by 2002:a05:6358:93a4:b0:134:c4dc:2c4e with SMTP id h36-20020a05635893a400b00134c4dc2c4emr3087615rwb.23.1694008549480; Wed, 06 Sep 2023 06:55:49 -0700 (PDT) Received: from hurd (dsl-153-125.b2b2c.ca. [66.158.153.125]) by smtp.gmail.com with ESMTPSA id f1-20020a0ccc81000000b0063f822dae2csm5493412qvl.54.2023.09.06.06.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 06:55:49 -0700 (PDT) From: Maxim Cournoyer References: <5d862d14705443a7898adf814a8a647f22df6d2b.1687211787.git.felix.lechner@lease-up.com> Date: Wed, 06 Sep 2023 09:55:47 -0400 In-Reply-To: <5d862d14705443a7898adf814a8a647f22df6d2b.1687211787.git.felix.lechner@lease-up.com> (Felix Lechner's message of "Mon, 19 Jun 2023 14:56:37 -0700") Message-ID: <87fs3r76e4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Spam-Score: -5.12 X-Migadu-Queue-Id: EB85A58FD1 X-Migadu-Spam-Score: -5.12 X-TUID: sKsrhrWxVHdg Hi Felix, Felix Lechner writes: > * gnu/packages/web.scm (wasm-micro-runtime): New variable. [...] > +(define-public wasm-micro-runtime > + (package > + (name "wasm-micro-runtime") > + (version "1.2.2") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/bytecodealliance/wasm-micro-runtime") > + (commit (string-append "WAMR-" version)))) > + (file-name (git-file-name "WAMR" version)) > + (sha256 > + (base32 > + "1mbwaj25798ilhg02447k3c2813xvxd70dwdlr4ha73xxbdgi54f")))) > + (build-system cmake-build-system) > + (arguments > + (list > + #:phases > + #~(modify-phases %standard-phases > + (delete 'check) Instead of deleting the check phase, uses #:tests? #f with an appropriate comment (e.g.: ';no test suite' if inline). > + (replace 'configure > + (lambda _ > + (chdir "product-mini/platforms/linux") > + (mkdir-p "build") > + (chdir "build") > + (invoke "cmake" "--install-prefix" #$output "..")))))) Instead of overriding configure, missing all the important CMake options that the default configure phase would use, did you try toa add a phase like --8<---------------cut here---------------start------------->8--- (add-after 'unpack 'chdir (lambda _ (chdir "product-mini/platforms/linux"))) --8<---------------cut here---------------end--------------->8--- It looks like this should do it. > + (native-inputs (list > + ccache > + gcc)) I'm pretty sure gcc is not necessary since it's already provided by cmake-build-system. ccache seems useless since we always build from scratch in a clean environment. Could you try the above suggestions and send a v2? -- Thanks, Maxim