unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: peter@polidoro.io
Cc: 66453@debbugs.gnu.org
Subject: [bug#66453] [PATCH 0/4] Three KiCad color themes
Date: Wed, 25 Oct 2023 10:11:37 +0200	[thread overview]
Message-ID: <87fs1znmti.fsf@gnu.org> (raw)
In-Reply-To: <cover.1696967309.git.peter@polidoro.io> (peter@polidoro.io's message of "Tue, 10 Oct 2023 15:57:39 -0400")


Hello,

Thanks for this patch, it seems to work fine! I think it is acceptable
to force extension installation through Guix.

As a general remark some lines are too long, this is reported by the
linter: https://qa.guix.gnu.org/issue/66453.

On Github the version is 2021-12-05, so the packages with the 1.2
version are flagged as updatable:

--8<---------------cut here---------------start------------->8---
gnu/packages/engineering.scm:1346:15: kicad-color-theme-solarized-dark@1.2: can be upgraded to 2021.12.05
--8<---------------cut here---------------end--------------->8---

You can also remove the '.git' suffix in `url` in git-reference:

--8<---------------cut here---------------start------------->8---
gnu/packages/engineering.scm:1378:7: kicad-color-theme-solarized-light@1.2: permanent redirect from https://github.com/pointhi/kicad-color-schemes.git to https://github.com/pointhi/kicad-color-schemes
--8<---------------cut here---------------end--------------->8---

Finally do you think it would be possible to package all the supported
color themes in a single package?

Thanks,

Mathieu




  parent reply	other threads:[~2023-10-25  8:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-10 19:57 [bug#66453] [PATCH 0/4] Three KiCad color themes peter
2023-10-10 20:05 ` [bug#66453] [PATCH 1/4] gnu: kicad: Add 3rdparty search path peter
2024-03-05 12:47   ` Steve George
2024-03-05 15:47     ` Peter Polidoro
2023-10-10 20:05 ` [bug#66453] [PATCH 2/4] gnu: Add kicad-color-theme-behave-dark peter
2023-10-10 20:05 ` [bug#66453] [PATCH 3/4] gnu: Add kicad-color-theme-solarized-dark peter
2023-10-10 20:05 ` [bug#66453] [PATCH 4/4] gnu: Add kicad-color-theme-solarized-light peter
2023-10-25  8:11 ` Mathieu Othacehe [this message]
2023-10-31 14:50   ` [bug#66453] [PATCH 0/4] Three KiCad color themes Peter Polidoro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs1znmti.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=66453@debbugs.gnu.org \
    --cc=peter@polidoro.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).