From: Josselin Poiret via Guix-patches via <guix-patches@gnu.org>
To: lgcoelho@disroot.org, 68012@debbugs.gnu.org
Subject: [bug#68012] [PATCH] thinkfan-service-type: Add thinkfan entry to thinkfan-configuration.
Date: Sat, 13 Jan 2024 17:31:58 +0100 [thread overview]
Message-ID: <87frz1gpoh.fsf@jpoiret.xyz> (raw)
In-Reply-To: <ed8a1cc6dad7fa297e3ce08171cad361@disroot.org>
[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]
lgcoelho--- via Guix-patches via <guix-patches@gnu.org> writes:
> (define-configuration/no-serialization thinkfan-configuration
> + (thinkfan
> + (package thinkfan)
> + "Thinkfan package to be used.")
> (pid-file
> (string "/var/run/thinkfan.pid")
> "Where to store the PID file.")
> @@ -491,17 +494,16 @@ (define-configuration/no-serialization thinkfan-configuration
>
> (define thinkfan-shepherd-service
> (match-record-lambda <thinkfan-configuration>
> - (pid-file config-file log-file extra-options)
> + (thinkfan pid-file config-file log-file extra-options)
> (list (shepherd-service
> (provision '(thinkfan))
> (documentation
> "Adjust fan level according to configured temperature limits.")
> (requirement '(user-processes))
> (start #~(make-forkexec-constructor
> - (list (string-append #$thinkfan-next
> - "/sbin/thinkfan")
> - "-n" #$@extra-options
> - "-c" #$config-file)
> + (list (string-append #$thinkfan "/sbin/thinkfan")
> + "-n" #$@extra-options
> + "-c" #$config-file)
That's a good idea, but can you squash this with the first commit?
Best,
--
Josselin Poiret
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 682 bytes --]
next prev parent reply other threads:[~2024-01-13 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 18:53 [bug#68012] [PATCH] services: Add thinkfan service lgcoelho--- via Guix-patches via
2023-12-25 23:59 ` [bug#68012] [PATCH] thinkfan-service-type: Place config-file in /etc/thinkfan.conf if file-like lgcoelho--- via Guix-patches via
2024-01-13 16:30 ` Josselin Poiret via Guix-patches via
2023-12-27 17:04 ` [bug#68012] [PATCH] thinkfan-service-type: Add thinkfan entry to thinkfan-configuration lgcoelho--- via Guix-patches via
2024-01-13 16:31 ` Josselin Poiret via Guix-patches via [this message]
2024-01-13 16:29 ` [bug#68012] [PATCH] services: Add thinkfan service Josselin Poiret via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frz1gpoh.fsf@jpoiret.xyz \
--to=guix-patches@gnu.org \
--cc=68012@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=lgcoelho@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).