From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id iBfUIjlR1mWgKQEAqHPOHw:P1 (envelope-from ) for ; Wed, 21 Feb 2024 20:38:33 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id iBfUIjlR1mWgKQEAqHPOHw (envelope-from ) for ; Wed, 21 Feb 2024 20:38:33 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm3 header.b=BkvGhAp6; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="e soiOhA"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708529734; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zh6y96hNnOsc7svfpxKXVkmTx7UnY3CeY0JGYepEOjU=; b=WXqQ/QByurAf/uZYNjpjEdmZWn0wKZVbKTADsnpSr1T8aBF+yUtUHhqeyhDfG2vdNnptM7 mLECPgysYF8q2UdYml+YAt3kqTprscChCgtFyU3eLmNU6hp4S/zENj/oQ0sVe31syBhRFM nLab71fW1OMSveFJ7lHPBH1c06oYmEePtCx3wTVjaTjtTo6aLBjZZcoSLMG1N9eBLEtDHt sg0CZTdNKoTrYnk3A7Ulq7rB9Nf6/E6zsrzgqCepsPiO2Wk98casov1mXR0YmkyOooUUDI GGD84Ahwc26WiJNrHsXkCsh1ekCXYelMDfdxjRrhc2jVewCSp+vVG2TG0XKODA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lassieur.org header.s=fm3 header.b=BkvGhAp6; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm1 header.b="e soiOhA"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708529734; a=rsa-sha256; cv=none; b=A72GnwCDzr9fvETTvyD9X3SUnzUYB6mFNBAnedq/8//bafgICptxYYGZV8nvhAKWgg05lO CkPCs2i2qGPM9PN7kTpAKWyk/RSjbMdulcK7BV1n9o+imntk1JQaABJBYTubeCkvZHg74/ THMu0+K6MHqCx6YMTGaXnE491rxycvdAs1qTYGw6Tt0yYFNby5gqcoNREQRSvk+sPkOE6k VKtEQBLgbDCBNiycGRwau9FFlGd48sgxFR0SQtJkxO4Fn0m8ZOVge4hkVxfzuAVOgGql79 4lHYaNafusPsWg3DtvlVKcbwGDDG4mtExbijdvjFs9kvI10qKkKzlSgqr4CdwQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 59AFE7CD25 for ; Wed, 21 Feb 2024 16:35:33 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcoaW-0008Sg-1v; Wed, 21 Feb 2024 10:32:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcoSx-0005H8-RT for guix-patches@gnu.org; Wed, 21 Feb 2024 10:25:00 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rcl3g-0008TP-DB for guix-patches@gnu.org; Wed, 21 Feb 2024 06:46:40 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rcl42-0002kC-An for guix-patches@gnu.org; Wed, 21 Feb 2024 06:47:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67512] [PATCH v4 3/4] gnu: Add wasm packages. Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 21 Feb 2024 11:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67512 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 67512@debbugs.gnu.org, Mark H Weaver , Ian Eure Received: via spool by 67512-submit@debbugs.gnu.org id=B67512.170851596210450 (code B ref 67512); Wed, 21 Feb 2024 11:47:02 +0000 Received: (at 67512) by debbugs.gnu.org; 21 Feb 2024 11:46:02 +0000 Received: from localhost ([127.0.0.1]:47961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcl34-0002iT-Cu for submit@debbugs.gnu.org; Wed, 21 Feb 2024 06:46:02 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:49463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcl31-0002hy-U7 for 67512@debbugs.gnu.org; Wed, 21 Feb 2024 06:46:01 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 91AF43200A24; Wed, 21 Feb 2024 06:45:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 21 Feb 2024 06:45:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lassieur.org; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1708515930; x=1708602330; bh=zh6y96hNnOsc7svfpxKXVkmTx7UnY3CeY0JGYepEOjU=; b= BkvGhAp6Z9GpLLbDn49Tz6dIS/InssgH02JmQ+fSrrNbdEgo0LFEbBTbpF3qHcqa ZCl9aoddwF7V/+lx6+HEmsBlv+ooVrch/fMiKw8z2iFftG1wo1++m4XQSsfntgxZ cZDEq8VYLvxBdVnrC2o9SMN6Y2tLW2fIOEsdLnkfEASlHN1znZ9Z0DaDvPKMAvs0 D0Yqzuo5ffPJ7P5pJYrRlpAMrmPNhRxdn/E4b5L9q68T++a4VQLUnA1FO7XY741Q 4k9IBwyqsnwirePn3QjvLZCbbud5p0emZdeS3NzlkeaUtJPJiDLuIEjGoIdLRLVQ PMl6KCHPswE69XNEivOOtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708515930; x= 1708602330; bh=zh6y96hNnOsc7svfpxKXVkmTx7UnY3CeY0JGYepEOjU=; b=e soiOhALc3rhBMUues6YBzVAQsijoC4x+zzZnqgnuPt07nWN6xD1jSwxAMxn06EOb +qUqPv9LbjH3M2bhWMCTlbGABRb9j/sNeHbwAllB8PcvggSNFPubTuiNsUyGDMQl ZW9VMrEQGTyoEmkje+l+87Ix2MuO4k7mk3cn8MTsHztQR1khTAbgvuRv6Cbkyyn8 pqm8xh0oSSQvNAN/tEL3Z4xtQAFEOZYJ2YqB16InbuXDts0X85uQQ+8u7UejVGtr LIKu91dqIUycWX2SrwjxdzvFXOb44MMvn5nWOz/KHNvxotUfCxVCla5K/9hNOyWF 77ZOlGEDLgrbmsbRwHDyg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedvgdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtgfesthhqredttderjeenucfhrhhomhepvehlrohm vghnthcunfgrshhsihgvuhhruceotghlvghmvghntheslhgrshhsihgvuhhrrdhorhhgqe enucggtffrrghtthgvrhhnpeegkeehfefftdefffeuveekgfffhfdtudfgudegueegvefg udetffdugfefhfejudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegtlhgvmhgvnhhtsehlrghsshhivghurhdrohhrgh X-ME-Proxy: Feedback-ID: i4c21472a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Feb 2024 06:45:28 -0500 (EST) From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-Reply-To: <7c457d6001344a781bd51e2716a295235d6ea755.camel@gmail.com> (Liliana Marie Prikler's message of "Wed, 21 Feb 2024 06:20:17 +0100") References: <39662eaab8ebb73981be67f42a0277c2013be76b.1707855137.git.ian@retrospec.tv> <1808da259ee4755731fade4507812fb3f9ba619e.camel@gmail.com> <87eddgx6y7.fsf@retrospec.tv> <877cj4fpo6.fsf@lassieur.org> <871q9bdpn3.fsf@retrospec.tv> <87ttm2wp84.fsf@lassieur.org> <87le7e4k3b.fsf@retrospec.tv> <7c457d6001344a781bd51e2716a295235d6ea755.camel@gmail.com> Date: Wed, 21 Feb 2024 12:45:24 +0100 Message-ID: <87frxmqbvv.fsf@lassieur.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -2.01 X-Spam-Score: -2.01 X-Migadu-Queue-Id: 59AFE7CD25 X-TUID: QFnTMs6CBXbk On Wed, Feb 21 2024, Liliana Marie Prikler wrote: > Am Dienstag, dem 20.02.2024 um 18:18 -0800 schrieb Ian Eure: >> Cl=C3=A9ment Lassieur writes: >>=20 >> > > Are you saying you want a process like: >> > >=20 >> > > 1a. Get wasm toolchain stuff merged. >> > > 1b. Get Librewolf merged without WASM sandboxing. >> > > 2. Update icecat, torbrowser, mullvad, and librewolf to use=20 >> > > WASM sandboxing. >> >=20 >> > Excatly.=C2=A0 1b can be done after 1a, or before 1a. >> >=20 >>=20 >> Is there a technical reason why landing WASM sandboxing support=20 >> for all browsers in the same patch is desirable?=C2=A0 I can intuit=20 >> none, and as I=E2=80=99m disinclined to either roll back portions of my= =20 >> existing patchset, or work on other browsers, the proposal is=20 >> disagreeable. > I think this ordering is w.r.t. *patch sets*, not patches. I wouldn't > suggest dropping four packages into one patch. Indeed I've never said it should be done in one patch. I said one-shot as in =E2=80=98symmetrical=E2=80=99: the work required to add Wasm to our b= rowsers should be more or less the same for all browsers, and code duplication should be avoided. >> I=E2=80=99m fine with splitting off the WASM toolchain stuff into a=20 >> separate patch, and then merging LibreWolf afterwards.=C2=A0 If others=20 >> would like to add WASM sandboxing to their Firefox-derived=20 >> browsers afterwards, they are, of course, welcome to. My point is that we need to understand the diff between a browser without wasm, and a browser with wasm. If you add librewolf with wasm already included, we don't have that diff info. And it's harder for us reviewers to understand what in your patch is wasm specific. And it's harder for us to include wasm to our firefox based browsers. I acknowledge it's more work for you, but it's a work that would have to be done otherwise by the reviewer, at least to test the wasm stuff. >> Is there further guidance on where the WASM toolchain packages=20 >> should be placed?=C2=A0 It seemed there was objection to having them in= =20 >> (gnu packages wasm), but nobody has proposed an alternate location=20 >> or engaged with the options I presented. > Unless there's a strong reason not to, I'd place them among the > existing ones in (gnu packages web). > > WDYT? Agreed.