unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Abhishek Cherath <abhi@quic.us>
To: Liliana Marie Prikler <liliana.prikler@gmail.com>
Cc: Vivien Kraus <vivien@planete-kraus.eu>,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>,
	70446@debbugs.gnu.org
Subject: [bug#70446] [PATCH v4] gnu: webkitgtk: Add access to system locale path and to paths from GUIX_LOCPATH, LOCPATH, and LIBVA_DRIVERS_PATH to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video.
Date: Sat, 20 Apr 2024 11:31:10 -0400	[thread overview]
Message-ID: <87frvg6og1.fsf@quic.us> (raw)
In-Reply-To: <1786c04febdba0477a2ec6270854a4ce7e4303f0.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 20 Apr 2024 16:59:53 +0200")

Hello,

>> Thanks [liliana.prikler@gmail.com] for all the help :D, I thought
>> about this a bit more and looked at all the utility stuff in
>> BubblewrapLauncher.cpp. I realized that the correct thing to do here
>> is to simply mount the LIBVA_DRIVERS_PATH paths. I'm wondering if
>> this shouldn't be part of the gstreamer default mounts even upstream?
>> along with the LOCPATH mount.
> This patch LGTM.  I think submitting it upstream sans GUIX_LOCPATH
> would be a great idea – that way, we'd have fewer things to patch.

Sweet! I'll get on that sometime next month.

> Is @localedir@ still needed with the bindPathVar in place?  Otherwise,
> as already said, LGTM, and I'll look into forwarding it to/cherry-
> picking it from gnome-team once I got new Webkit over there (still need
> to wait for CI on that).

Yes, it's still needed since Guix system doesn't generally set LOCPATH
(or GUIX_LOCPATH.)

Thanks again for the review and suggestions!

Yours sincerely,
Abhishek Cherath.




  reply	other threads:[~2024-04-20 15:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18  2:52 [bug#70446] [PATCH gnome-team] gnu: webkitgtk: Add system locale, dri access, and user profile access to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video, respectively Abhishek Cherath
2024-04-18  3:14 ` [bug#70446] Explanation Abhishek Cherath
2024-04-18  4:06 ` [bug#70446] [PATCH v2] gnu: webkitgtk: Add locale and dri access to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video, respectively. Adjust bubblewrap wrapper to add user profile Abhishek Cherath
2024-04-19 18:53   ` Liliana Marie Prikler
2024-04-19 20:24     ` Abhishek Cherath
2024-04-19 20:33       ` Abhishek Cherath
2024-04-19 21:19       ` Liliana Marie Prikler
2024-04-19 21:59         ` Abhishek Cherath
2024-04-18  5:02 ` [bug#70446] [PATCH gnome-team] gnu: webkitgtk: Add system locale, dri access, and user profile access to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video, respectively John Kehayias via Guix-patches via
2024-04-18 13:50   ` Abhishek Cherath
2024-04-19 15:24     ` Maxim Cournoyer
2024-04-19 21:55 ` [bug#70446] [PATCH v3] gnu: webkitgtk: Add locale and dri access to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video, respectively. Adjust bubblewrap wrapper to add user profile locale and dri directories Abhishek Cherath
2024-04-19 22:43   ` Liliana Marie Prikler
2024-04-20  0:22     ` Abhishek Cherath
2024-04-20  0:40       ` Liliana Marie Prikler
2024-04-20  1:52         ` Abhishek Cherath
2024-04-20  2:51           ` Liliana Marie Prikler
2024-04-20 21:39           ` Maxim Cournoyer
2024-04-20 13:44 ` [bug#70446] [PATCH v4] gnu: webkitgtk: Add access to system locale path and to paths from GUIX_LOCPATH, LOCPATH, and LIBVA_DRIVERS_PATH to gtk sandbox in order to silence gtk locale warnings and enable hardware accelerated video Abhishek Cherath
2024-04-20 14:59   ` Liliana Marie Prikler
2024-04-20 15:31     ` Abhishek Cherath [this message]
2024-04-20 21:42       ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frvg6og1.fsf@quic.us \
    --to=abhi@quic.us \
    --cc=70446@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=maxim.cournoyer@gmail.com \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).