From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id 4OdzAExOKWb11QAAqHPOHw:P1 (envelope-from ) for ; Wed, 24 Apr 2024 20:24:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 4OdzAExOKWb11QAAqHPOHw (envelope-from ) for ; Wed, 24 Apr 2024 20:24:12 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=eNA+auSq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713983051; a=rsa-sha256; cv=none; b=J3PTlPxxSHbMH+eZGsfoIPgiCBSJYOs4lrUptAa5YRWMXAJSXwCD8jbG1Efi0tgTFfcnhj r0pkfp5WUSOo4xAXy2Yu2NbP0XCkzjd51yUdujuYkj5EzGGnZYMxvxLegCwOIHakgseFhT TTLPhk3k3yo42kCCcbJ+vPh9kMODm9HGRt+mWisYubO/KLm64GtO4AP0/JN/3G6ZHUPulI EccAeOxIjvyFUHu9V2yIlgRxvge6V0NkWiqfoyIDI5gIgcYyowq4Ot+PJ8BdiI/rUoHwWs yb6/0o7vK/Ldx2stnJSS2jcp1HYInfFIRD0oTKr8fVCzUSznaTZp6N89yh1Q/w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=eNA+auSq; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713983051; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=rZj69MnE058MWBEfeTCLcYwbg4Swj6UUxAx5Q1U25Uo=; b=K98Lhun3asm9Vd3NdY/PipZ50f/IqGgKonn4RN/sYjRWLtmty6H1NpTKP0BABTG4wAwhqk eNVRbOOOiAnTCE8N5EjzDHh9UY1ZbyXckmB1jMHatr1UOUq+24QYWvmDcgiwj3dHvfUkEL AOaQUVl73iss5L4XebdXV2iXOrA/QjAo3+2dU6FjmNk5f1Rmfbn8Ir9tPUSymLSvr1aFGV capsQPgdbO1GLm2gf49VjP3FPQOeP54RJ4LmCp67BY8yciqyaMf8dGgacDZO/yBdr6G5wc MfyNwagJnznPa8J1Usm7fMfwuHRzYJcdUpcxgrj0U/MfQbYRvGl5RCdTbjHCDw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B888668ADB for ; Wed, 24 Apr 2024 20:24:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzhHe-00036j-Sd; Wed, 24 Apr 2024 14:23:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzhHY-00036X-Fz for guix-patches@gnu.org; Wed, 24 Apr 2024 14:23:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzhHY-00089L-5s for guix-patches@gnu.org; Wed, 24 Apr 2024 14:23:48 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rzhHp-00020w-6m for guix-patches@gnu.org; Wed, 24 Apr 2024 14:24:05 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70542] [PATCH 3/4] file-systems: Add support for mounting CIFS file systems Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Apr 2024 18:24:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70542 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler Cc: 70542@debbugs.gnu.org Received: via spool by 70542-submit@debbugs.gnu.org id=B70542.17139829907094 (code B ref 70542); Wed, 24 Apr 2024 18:24:05 +0000 Received: (at 70542) by debbugs.gnu.org; 24 Apr 2024 18:23:10 +0000 Received: from localhost ([127.0.0.1]:59770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhGu-0001q1-1v for submit@debbugs.gnu.org; Wed, 24 Apr 2024 14:23:09 -0400 Received: from mail-108-mta160.mxroute.com ([136.175.108.160]:35329) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzhGn-0001oP-ST for 70542@debbugs.gnu.org; Wed, 24 Apr 2024 14:23:06 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta160.mxroute.com (ZoneMTA) with ESMTPSA id 18f11586f9a0008ca2.001 for <70542@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 24 Apr 2024 18:22:39 +0000 X-Zone-Loop: 64d960423ed513b0d88a7a0cb06353ae2c5dc23e902b X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rZj69MnE058MWBEfeTCLcYwbg4Swj6UUxAx5Q1U25Uo=; b=eNA+auSqW6P7XyBCykifeXp5/N oG07xYkoysFT5cbdj2lVEVyDtDiqNKDfh8WjMllRx62omgip5bCoeCwjKsJ7R1E0L71/CTcuMN5F8 0LJ6wZwa4j2bNaDCOmy+MEwRkfz87NplOnrjYZzz6U2SR1KLXEBjjezxfqH5nhW5XmFqWz1AvHf8u uKj/frxGFQMYVZ7CbXZzzXtyw54+5LoOpeBgd89mCti79QMNzEMfzFyeZivj6LfmxbS8lyEhX3Mv5 zyfAURcS4tWT6D0RaagGN5Ui9nSN5gn/PseNQuMhLMTuE27tgFHK6rUHUcidxfvhWwCdnZzPFrtEe QjrevmOg==; From: Richard Sent In-Reply-To: <036dbbe1dc78d8c1e36f70caa5e5f2b6b21abc56.camel@gmail.com> (Liliana Marie Prikler's message of "Wed, 24 Apr 2024 19:29:11 +0200") References: <036dbbe1dc78d8c1e36f70caa5e5f2b6b21abc56.camel@gmail.com> Date: Wed, 24 Apr 2024 14:22:35 -0400 Message-ID: <87frvazklw.fsf@freakingpenguin.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: richard@freakingpenguin.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Spam-Score: -3.39 X-Migadu-Queue-Id: B888668ADB X-Migadu-Spam-Score: -3.39 X-Migadu-Scanner: mx10.migadu.com X-TUID: afrIWr/tXoqK Hi! Thanks for the feedback! :) > Any reason we ought to solve guest specially? Let's just assume that > user and pass are always (possibly empty) strings. If you need to > abstract over it, you could always make a procedure or something. My reason for handling guest specifically is to try and match the behavior of the userspace "mount.cifs" program as much as possible. That program will parse options, and if it encounters the option "guest", silently replace it with "user=,pass=" before initiating the mount system call. The kernel driver itself ignores the "guest" option, so unless we handle it ourselves by inserting blank user and pass options, it wouldn't have an effect. If I understand what you're saying, we could have user and pass variables that default to "" unless options includes e.g. user=foo,pass=bar. That would diverge from mount.cifs's behavior though, which is something I'm reluctant to do. I don't know if not passing user or pass is identical to passing user=,pass=, but if it's not then users would get confused reading mount.cifs's documentation and trying to apply the same logic to their OS declaration. -- Take it easy, Richard Sent Making my computer weirder one commit at a time.