From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id oJsGCXmTYGbSDwAAqHPOHw:P1 (envelope-from ) for ; Wed, 05 Jun 2024 18:34:01 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id oJsGCXmTYGbSDwAAqHPOHw (envelope-from ) for ; Wed, 05 Jun 2024 18:34:01 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=mjW3Nqty; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1717605238; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=eN+otJTdC+MWbfiHPgZIam+pjMFpliZ0TtmAtM9Zpts=; b=TuCATuMMkNPowp7LR4Vcddyx0VYuoogR3zWFXH6ueWQFAB1ohlaq8XrOUOnrfP7J84qNc9 1CnFZ/OsUk6D4O06ORyqk9gDC9P9QZzTmmGo26DOgUyD2Mgg3VAQH9TCM9nyj7MqyKJCQd 0HC0ZmtMmMzYZz9Gc9/wJ1evGrNZ/9eq1BLAoAbJnFi4cK6z8uz37DmYZSGCpcH9cdD3Wf OIWoqpRZGSKmxg1NyUhzi/D7C28olrlepRHNcuiqi1PP14NNbdBzJS0Si02qMJ5T0/mQzX rv/oSCqvCAB0v+/jUEz9wzIagttuom++O82EnQe/iOEcKntyYTWbjEETfBLTZQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=mjW3Nqty; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1717605238; a=rsa-sha256; cv=none; b=dUyuM3pcm8giedKE+KgedfK5+c0jNRtgZ2BEy/zO79iQdGU3wtUiHokvRp9bXVOg0yC490 4SX1vZjL5dEG15R3+ryHLqUIS+n9Ed+sbg3pXAtbQhvAEKH6mzuDGTSZ/I1EQ34sGedH5H hgSaI1iiA/2s5hOPCC7TPAGNjPvOY3jVY6zh7bUvkQ9MYtxuROa+eQTHkmgL3iBuYvdIdK dDB7JIxO2vZWspW6AJhCFhBofoKxCV/cT9mCnAxh/Se5U43AEfOAMRzvFfAzgWt52TOPrv VLCzBucUQoi6iIVsMzOdI7MQPrEA7oyTuRPbpDoIQ0RuftAgyGSehfOgxnRStg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 23CEF228B6 for ; Wed, 5 Jun 2024 18:33:58 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEta9-0007sQ-7M; Wed, 05 Jun 2024 12:33:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEta8-0007rN-Gq for guix-patches@gnu.org; Wed, 05 Jun 2024 12:33:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEta8-0007yu-8R for guix-patches@gnu.org; Wed, 05 Jun 2024 12:33:48 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEtaM-0006jp-3H for guix-patches@gnu.org; Wed, 05 Jun 2024 12:34:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71371] [PATCH] gnu: svn-fetch: Make revision field optional. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 05 Jun 2024 16:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71371 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 71371@debbugs.gnu.org Cc: Josselin Poiret , Maxim Cournoyer , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Florian Pelz , Ricardo Wurmus , Nicolas Goaziou , Christopher Baines , Matthew Trzcinski X-Debbugs-Original-To: Nicolas Goaziou via Guix-patches via , 71371@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171760521225818 (code B ref -1); Wed, 05 Jun 2024 16:34:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Jun 2024 16:33:32 +0000 Received: from localhost ([127.0.0.1]:47177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEtZs-0006iL-2f for submit@debbugs.gnu.org; Wed, 05 Jun 2024 12:33:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:46322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEtZq-0006iB-Ec for submit@debbugs.gnu.org; Wed, 05 Jun 2024 12:33:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEtZc-0007O4-0K for guix-patches@gnu.org; Wed, 05 Jun 2024 12:33:16 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEtZa-0007ph-Du; Wed, 05 Jun 2024 12:33:15 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4214b2c5d40so6185e9.1; Wed, 05 Jun 2024 09:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717605192; x=1718209992; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=eN+otJTdC+MWbfiHPgZIam+pjMFpliZ0TtmAtM9Zpts=; b=mjW3NqtyHZP2ZS0zLg6MHIrlzX/BtsolyFoAzlvIXHPfN975TKhWpW2pbA6hZA88ZM 6TRWIOOL5RynFBqaLYTdcnCQ+RKHvAbXqfc/AWU6ED7K8E7lrRqsfvSU05VC52XZrayA YahN5Ozzph8KsNSKLElT6VV9L4Bc4x9EMXo8HsvjCojQIn/RtutfNXcg+YuLodDupIyG mcTn1ZlD/7bC01ugdlaOBZGfZTfNsG0Zr+m5iXTXDS8fEiMZIcNOPMn9WWvItTKCIakG TCMqYqm6imfpiuLcQHlK6FJyw1XAT4NID/71reU97IzzukaQm3c1XWYVrzD/5bIvK1uC do4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717605192; x=1718209992; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eN+otJTdC+MWbfiHPgZIam+pjMFpliZ0TtmAtM9Zpts=; b=F/31SLq1AQ8wzsHhlZmLr+Chb2rQMqFUTKopFCVDj9N41g0T3/z2wQZNvlgpMOfMSZ UK3st1Yw7maD3h8OiyMDP/qlchDZCy63FU3AeEsuZLdafmZxyNDjMQWRwd9g2vcUeRAp ou3jI+DxJbRaE+OIOvkug8uNjrGCoVPz3WZ3AueEde+okzRQCZdb/HnyUgsOll5Qxvu0 z6uZ64tNIEpHak1jeLCgxLAog6tpuPkBod4Te1bQhcMoSioaG+j0l9ISHpBLL+Ul6iH7 emxMYOkF/N7bFjFJkl43Y2MhC0JCMhIFl/UVUzAYrVA79m9BSUO3MNWjeK4vsYLWnf5g A8Nw== X-Forwarded-Encrypted: i=1; AJvYcCXQCMWolPqAbeNoklfkHYW/Xz2dCUrLzFJ+Q3Jl+aqZOMMGA8DSWqvnhk4C8wJKPcjvTSGM59IjW/IhnqEtGsvvlYLbld+zlJH2PcpdYj8= X-Gm-Message-State: AOJu0YwkGx0bETGRtZqK9jAxIaVRvyAoxJZMo38gAkfk/sWrkW07LS0F JfGlaf2QBCk70sSZ36m82VgjQhSJj4Cap6re+1nzUKV2hMAbVx7e X-Google-Smtp-Source: AGHT+IGPAPLjSidrY/M67WqUqUXjHoolErG/vW54wlpRIxNfKql5DMIJ9yIGg1Q7TyX87ZRBVM11eA== X-Received: by 2002:a05:600c:3c93:b0:41b:e58c:e007 with SMTP id 5b1f17b1804b1-421563558d3mr22771025e9.4.1717605191568; Wed, 05 Jun 2024 09:33:11 -0700 (PDT) Received: from lili (roam-nat-fw-prg-194-254-61-45.net.univ-paris-diderot.fr. [194.254.61.45]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158102a9csm28383935e9.14.2024.06.05.09.33.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 09:33:11 -0700 (PDT) From: Simon Tournier In-Reply-To: References: Date: Wed, 05 Jun 2024 18:32:57 +0200 Message-ID: <87frtrnydi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=zimon.toutoune@gmail.com; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: 3.96 X-Migadu-Queue-Id: 23CEF228B6 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: 3.96 X-TUID: 54H7G6wYME0W Hi Nicolas, On Wed, 05 Jun 2024 at 07:52, Nicolas Goaziou via Guix-patches via wrote: > * guix/svn-download.scm (): Set default value for REVISION > field to #F. > (svn-fetch): > (svn-multi-fetch): Take into consideration the revision can be a number o= r #F. > * guix/build/svn.scm (svn-fetch): Skip "-r" argument when revision is #F. > * doc/guix.texi (origin Reference): Document changes about REVISION field. Does it make sense to have a Subversion reference without any specific revision? > - (string->number (getenv "svn revision")) > + (match (getenv "svn revision") > + ("#f" #f) > + (s (string->number s))) [...] > - (string->number (getenv "svn revision= ")) > + (match (getenv "svn revision") > + ("#f" #f) > + (s (string-to-number s))) I am probably missing something, why =E2=80=99string-to-number=E2=80=99 and= not =E2=80=99string->number=E2=80=99? Cheers, simon