From: Simon Tournier <zimon.toutoune@gmail.com>
To: 71371@debbugs.gnu.org
Cc: "Josselin Poiret" <dev@jpoiret.xyz>,
"Maxim Cournoyer" <maxim.cournoyer@gmail.com>,
"Mathieu Othacehe" <othacehe@gnu.org>,
"Ludovic Courtès" <ludo@gnu.org>,
"Tobias Geerinckx-Rice" <me@tobias.gr>,
"Florian Pelz" <pelzflorian@pelzflorian.de>,
"Ricardo Wurmus" <rekado@elephly.net>,
"Nicolas Goaziou" <mail@nicolasgoaziou.fr>,
"Christopher Baines" <guix@cbaines.net>,
"Matthew Trzcinski" <matt@excalamus.com>
Subject: [bug#71371] [PATCH] gnu: svn-fetch: Make revision field optional.
Date: Wed, 05 Jun 2024 18:32:57 +0200 [thread overview]
Message-ID: <87frtrnydi.fsf@gmail.com> (raw)
In-Reply-To: <d811c6461c7d653834c6a04290cacda5a72680b2.1717566375.git.mail@nicolasgoaziou.fr>
Hi Nicolas,
On Wed, 05 Jun 2024 at 07:52, Nicolas Goaziou via Guix-patches via <guix-patches@gnu.org> wrote:
> * guix/svn-download.scm (<svn-reference>): Set default value for REVISION
> field to #F.
> (svn-fetch):
> (svn-multi-fetch): Take into consideration the revision can be a number or #F.
> * guix/build/svn.scm (svn-fetch): Skip "-r" argument when revision is #F.
> * doc/guix.texi (origin Reference): Document changes about REVISION field.
Does it make sense to have a Subversion reference without any specific
revision?
> - (string->number (getenv "svn revision"))
> + (match (getenv "svn revision")
> + ("#f" #f)
> + (s (string->number s)))
[...]
> - (string->number (getenv "svn revision"))
> + (match (getenv "svn revision")
> + ("#f" #f)
> + (s (string-to-number s)))
I am probably missing something, why ’string-to-number’ and not
’string->number’?
Cheers,
simon
next prev parent reply other threads:[~2024-06-05 16:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 5:52 [bug#71371] [PATCH] gnu: svn-fetch: Make revision field optional Nicolas Goaziou via Guix-patches via
2024-06-05 16:09 ` Ludovic Courtès
2024-06-05 20:44 ` Nicolas Goaziou via Guix-patches via
2024-06-05 16:32 ` Simon Tournier [this message]
2024-06-18 8:30 ` [bug#71371] [PATCH v2] gnu: svn-fetch: Allow specifying revisions as strings Nicolas Goaziou via Guix-patches via
2024-06-18 12:11 ` Maxim Cournoyer
2024-06-18 13:26 ` Nicolas Goaziou via Guix-patches via
2024-06-18 18:26 ` Maxim Cournoyer
2024-06-19 7:27 ` bug#71371: " Nicolas Goaziou via Guix-patches via
2024-06-25 15:19 ` [bug#71371] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frtrnydi.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=71371@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=guix@cbaines.net \
--cc=ludo@gnu.org \
--cc=mail@nicolasgoaziou.fr \
--cc=matt@excalamus.com \
--cc=maxim.cournoyer@gmail.com \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=pelzflorian@pelzflorian.de \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).