From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id QOGqAamyd2YjGwEAe85BDQ:P1 (envelope-from ) for ; Sun, 23 Jun 2024 05:29:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id QOGqAamyd2YjGwEAe85BDQ (envelope-from ) for ; Sun, 23 Jun 2024 07:29:13 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="KcHzbe/i"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1719120552; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=HVkVrW8uF/rGBUuy04HfP4yninNXoCZvWqQKJwQuJ5k=; b=u+9w+YT5WPth5XizyQNo/350JrZHeRyUQ2ypk6OcYr5NiS54mJw1Iatdm7JZqoF3YENcGc VmVFoqHAKdd/Wj8XQ1nLHL5Vj5s6oAH4z6/Lnw+6/OB9znlcbxEw0eWpAiOrF85JiX6s// qPZj7UxaRgldFgN4kcG1eY/2W69m1rXmuVPwUTWVTK1yaaEWD3OkWCMp69MvrpHoySjoOd 1gBXKOm+hOY7k4qoRkjTU8eBfXSaz/3EGYUjZCxZ/ohq5p+Sy4PvJJ34R1+wNuT+ybX0k5 1MTnaXmOpPrxtrKhDCoaiYT3uUM91W7yvFwVMN1Yx03X91RCFzcbW/43+iGylw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1719120552; a=rsa-sha256; cv=none; b=k9Kwc2HAk33+DUIr/h5ZVGJ8SeyPJSMauI7HobPkeqPPrp/PO2N2OqHDMU/lZ9xvo9ddCp JCwFq5yJkHUkheKdWIx6NURCdlQ5Ajl8BiFwDvLOAe80ZPeHnQefXse2eI4sK7W5OuakB/ ixnrhNlUp0Kd6ubpb6h0QM0vKkORc21QUNxEavoYEx2xcsmMU2WZbawtkTAQNemFdZcqle zKo3k3tKXmb4dDtrfAb9FufS/Apy5xHRe4xmgUTdhSY+reDk2+yLGkKDg9wU+OLifCRJJc AWCQxgp5Rwp6cAqBp1RJZG82HGl6Mwb6DQDrkbI8disEx26tSauAg9ETvpPsJg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="KcHzbe/i"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 82B4764635 for ; Sun, 23 Jun 2024 07:29:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLFmi-0003ZF-40; Sun, 23 Jun 2024 01:29:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLFmg-0003Wp-LJ for guix-patches@gnu.org; Sun, 23 Jun 2024 01:29:02 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLFmg-0006Ta-C9 for guix-patches@gnu.org; Sun, 23 Jun 2024 01:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLFmg-0006TO-8l for guix-patches@gnu.org; Sun, 23 Jun 2024 01:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71592] [PATCH 0/3] gnu: emacs-org: Update to 9.7.4. Resent-From: Suhail Singh Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 23 Jun 2024 05:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71592 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Adam Porter Cc: 71592@debbugs.gnu.org, Suhail Singh Received: via spool by 71592-submit@debbugs.gnu.org id=B71592.171912049224765 (code B ref 71592); Sun, 23 Jun 2024 05:29:02 +0000 Received: (at 71592) by debbugs.gnu.org; 23 Jun 2024 05:28:12 +0000 Received: from localhost ([127.0.0.1]:45073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLFls-0006RN-4v for submit@debbugs.gnu.org; Sun, 23 Jun 2024 01:28:12 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:38991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLFlp-0006Qy-FG for 71592@debbugs.gnu.org; Sun, 23 Jun 2024 01:28:10 -0400 Received: by mail-qk1-f194.google.com with SMTP id af79cd13be357-7955b9fd39aso5140885a.0 for <71592@debbugs.gnu.org>; Sat, 22 Jun 2024 22:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719120423; x=1719725223; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=HVkVrW8uF/rGBUuy04HfP4yninNXoCZvWqQKJwQuJ5k=; b=KcHzbe/iTBrDJC97tbUfbAKrvr7qCJC/yVe6VTGRoM5OfWxtIamQMi+g3CbgI0cZia qFKhCxAtg7m0r16IZSn4b3Xi6QFkOq+Foye6ilDQ1o4vtAVdNYWBBJFNnqB6hrlR2BwT IwQ9wm5nFNOe3R9ae+H/SfMDgOXACAbdBfq8AN+yzciXGoj8NglGr0OTOrFfAdxXTka/ g8vuQqnvIF4dqNJUanmwI0qkZy6w+kjSWybb/dopSOZNEAAHf5NWBm6rn+8i8Mamozn7 /krqo1OGkLpxJ7jSBrH9B2//29L4ou6EzjbBOLzvGl8n8V/IKuakJC/fxVKEcGmxbBTd J6dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719120423; x=1719725223; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HVkVrW8uF/rGBUuy04HfP4yninNXoCZvWqQKJwQuJ5k=; b=PsAe84qGXVXMUy1++pH0o0vjsWvM6sNZOYVqhMTZIdM9nRxzISuBJRfHpeZZj/xyqk kwfmh0/6pR7iXTUVeoM8qrG/xr+J/vRGFaKtO2uS06eLh/HMQ4lLGgpV6RBRBUVvBJA0 g9NQzKKJEeHE1ArJc97kHJW/qoiYPzTVSKN2S+O6vAhDRr6XuuSBrSRNSO6e2FaGHR5t 28yC/HuONlSxRg8udWfLFM5XDejvbibtkQAKqk+Ia6Bou0oYcwUoRqVUDcHtnRz8AcaT sdVWSRrIv1hgZoXhtgcR4u2PGPPeiMz3i2tAzFtcrG3fx6JrH997VuJOPxEupz6dwT3i 0zrg== X-Gm-Message-State: AOJu0YzM3PPBr40eMICwiedRSFwzufuojHpzB1vA8rFlEVFHS7KFfmwp vsO5JF+Yyx2r6xD671KiSoy9CUgRbc/x53NOoHUzctcLXnO3UMReJ5pY64BS X-Google-Smtp-Source: AGHT+IEs6/nOh3eOA1PI9pC69nrPKf/BEETepTNfmhihfhULzwNx/M96JzhN4Dx/fUojdZCCRGlsQg== X-Received: by 2002:a05:620a:1a19:b0:79b:e7f0:e762 with SMTP id af79cd13be357-79be7f0f826mr146401185a.4.1719120423409; Sat, 22 Jun 2024 22:27:03 -0700 (PDT) Received: from gnus ([142.127.6.31]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79bce934b24sm211178485a.123.2024.06.22.22.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 22 Jun 2024 22:27:03 -0700 (PDT) From: Suhail Singh In-Reply-To: (Adam Porter's message of "Sat, 22 Jun 2024 16:39:49 -0500") References: Date: Sun, 23 Jun 2024 01:27:01 -0400 Message-ID: <87frt4ns9m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -2.26 X-Spam-Score: -2.26 X-Migadu-Queue-Id: 82B4764635 X-Migadu-Scanner: mx11.migadu.com X-TUID: Qfj5k3Q2XvQk Adam Porter writes: > Suhail, I appreciate your making the package build on Guix, Hello, Adam. Though I am not a user, I appreciate you authoring the package and releasing and supporting it for the benefit of others. > but have these failing tests been reported as bugs upstream? I have not made any bug reports regarding the failing tests yet. I don't know if others have (or rather didn't, before I started writing this email). I did try and see if a newer commit from org-super-agenda was immune from the test failures, but didn't have any luck. It's not clear to me whether the test failures point to bug(s) in org-super-agenda, bug(s) in its test suite, bug(s) in Org mode, or (less likely, but still possible) false positive(s) arising due to the tests not being designed necessarily to run on Guix. I was planning to look into it further, but since I don't personally use org-super-agenda it's not been a priority. Regardless, for the benefit of others, I am glad that you pay attention to this mailing list and are now aware. > You mention in a code comment an obsolete variable, but I don't know > anything about that, and I can't find a bug reported on the tracker > about it. The "obsolete" variable in question is `org-super-agenda-retain-sorting'. The tests making use of the older user option are `org-super-agenda-test--with-retained-sorting' and `org-super-agenda-test--without-retained-sorting'. In commit `27aa0db4243b835494f4836b82d0fbf3c5be7392' on 2021-09-28, it seems you renamed that option to `org-super-agenda-keep-order'. The tests were not updated. The FIXME comment in the former test notes: #+begin_src emacs-lisp ;; FIXME: This seems to be slightly broken on Org 9.6.6. Maybe ? #+end_src The bug #207 seems to have been first noted about 3 years ago, is currently open and assigned to you, and targeted for the 1.4 milestone. > Please, if you know about a bug, Not being a user of the package, my awareness is limited to the presence of test failures. I am not sure if you have CI configured for the project, but if you have and aren't seeing these failures, it may be worth your while to understand where those differences stem from. If you do and do see the same failures, your awareness and understanding of the issues probably exceeds my own limited understanding, so please excuse most of this email. If you don't have CI configured, you may want to consider doing so. Whether these failures are false positives or not, is not clear to me. If I had spent more time analyzing it, I am sure eventually I would have understood it and either added to the existing issues, or opened new ones, or submitted one or more patch/pull request upstream. Alas, there's only so much time in the day and we must all prioritize. > and especially if you know about a solution, As noted in my patch, my attempt to naively rename `org-super-agenda-retain-sorting' to `org-super-agenda-keep-order' did not fix the failures I observed. The actual fix, whatever it is, isn't one I'm aware of. > report it upstream so it can be fixed. That _is_ the general protcol ;) > I maintain a number of Emacs/Org packages, and keeping up with the > changes in Org, and trying to maintain compatibility across versions > which have incompatibilities, is trying, especially if users don't > report them (I don't always run the latest release of Org). I agree user reports are invaluable. In fact, I'd go further and say that user time is invaluable. However, given that their time is precious, it seems wasteful to rely on them for something that can be adequately addressed by a properly configured CI system (at least in this instance). In my candid opinion, their time is better served reporting on usability concerns that aren't (yet) covered by tests. Regards, -- Suhail