* [bug#74112] [PATCH] Fix determinism issue in guix package
@ 2024-10-30 18:06 ` Jakob Kirsch via Guix-patches via
2024-11-05 10:31 ` [bug#74112] bug#74204: Guix is not reproducible Hilton Chain via Guix-patches via
0 siblings, 1 reply; 2+ messages in thread
From: Jakob Kirsch via Guix-patches via @ 2024-10-30 18:06 UTC (permalink / raw)
To: 74112
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
I've recently noticed that `guix challenge guix` returns different hashes for each substitute server and also every build with `guix build --no-grafts guix` fails.
Running `guix build --no-grafts guix --cores=1` seems to reliably produce the same hash though. As someone pointed out on XMPP, Guile seems to have issues with parallel builds so this patch disables them for the guix package.
I think this has high importance because the main guix package should be reproducible in order to trust the whole chain of packages.
[-- Attachment #2: v1-0001-gnu-guix-Fix-determinism-issue.patch --]
[-- Type: text/plain, Size: 1292 bytes --]
From 0f3df56dd0c430c09ba2839c9e2d5b32948201ae Mon Sep 17 00:00:00 2001
Message-ID: <0f3df56dd0c430c09ba2839c9e2d5b32948201ae.1730311414.git.jakob.kirsch@web.de>
From: Jakob Kirsch <jakob.kirsch@web.de>
Date: Wed, 30 Oct 2024 19:02:15 +0100
Subject: [PATCH v1] gnu: guix: Fix determinism issue
* gnu/packages/package-management.scm (guix): Fix determinism issue by disabling parallel build.
Change-Id: Ie28e16ed1f15cbc0da0c0d70b2c461e2baa3ff0a
---
gnu/packages/package-management.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index 1763d2d59f..478a74385b 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -199,7 +199,8 @@ (define-public guix
(file-name (string-append "guix-" version "-checkout"))))
(build-system gnu-build-system)
(arguments
- `(#:configure-flags (list
+ `(#:parallel-build? #false ; for reproducibility
+ #:configure-flags (list
;; Provide channel metadata for 'guix describe'.
;; Don't pass '--with-channel-url' and
base-commit: d6f775c30c6f47e174f6110d1089edc6315600e4
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [bug#74112] bug#74204: Guix is not reproducible
2024-10-30 18:06 ` [bug#74112] [PATCH] Fix determinism issue in guix package Jakob Kirsch via Guix-patches via
@ 2024-11-05 10:31 ` Hilton Chain via Guix-patches via
0 siblings, 0 replies; 2+ messages in thread
From: Hilton Chain via Guix-patches via @ 2024-11-05 10:31 UTC (permalink / raw)
To: Jakob Kirsch; +Cc: 74112, 74204
Hi Jakob,
On Tue, 05 Nov 2024 02:38:34 +0800,
Jakob Kirsch via Bug reports for GNU Guix wrote:
>
> I've recently noticed that `guix challenge guix` fails since guix isn't
> reproducible at the moment. As someone pointed out on XMPP, this is due to
> parallelism issues with Guile so running `guix build guix --no-grafts
> --cores=1 --check` reliably produces the same output.
>
> I've sent a simple patch in #74112 to address this and I think this is
> important since the main guix package should definitely be reproducible so it
> can be trusted.
I can confirm the reproducibility issue.
I have two x86_64-linux machines building guix to verify the fix, I'll apply
your patch once they produce matching outputs.
Thanks for reporting!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-05 13:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <ZykUqu7t4WuUF9kj@kernelpanicroom>
2024-10-30 18:06 ` [bug#74112] [PATCH] Fix determinism issue in guix package Jakob Kirsch via Guix-patches via
2024-11-05 10:31 ` [bug#74112] bug#74204: Guix is not reproducible Hilton Chain via Guix-patches via
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).