unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin.
@ 2025-02-03  6:32 iyzsong--- via Guix-patches via
  2025-02-03 13:08 ` Maxim Cournoyer
  0 siblings, 1 reply; 6+ messages in thread
From: iyzsong--- via Guix-patches via @ 2025-02-03  6:32 UTC (permalink / raw)
  To: 76026
  Cc: 宋文武, Liliana Marie Prikler, Maxim Cournoyer,
	Vivien Kraus

From: 宋文武 <iyzsong@member.fsf.org>

Fixes <https://issues.guix.gnu.org/39126>.

The cogl GStreamer sink has been broken:
  <https://gitlab.gnome.org/Archive/cogl/-/issues/15>

* gnu/packages/gnome.scm (cogl)[inputs]: Remove gstreamer and
gst-plugins-base.
[arguments]: Pass "--enable-cogl-gst=no" to configure-flags.

Change-Id: I644da53effb52c6b6d8b1f9b6df293545fab963c
---
 gnu/packages/gnome.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 1225570c3c..1e8d813682 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -6308,12 +6308,10 @@ (define-public cogl
      (list mesa
            cairo
            pango
-           gstreamer
-           gst-plugins-base
            wayland))
     (arguments
      `(#:disallowed-references (,xorg-server-for-tests)
-       #:configure-flags (list "--enable-cogl-gst"
+       #:configure-flags (list "--enable-cogl-gst=no" ;broken and unmaintained
                                "--enable-wayland-egl-platform"
                                "--enable-wayland-egl-server"
 

base-commit: 12619742365b4bc138853ff7d79053e2089ffe1e
-- 
2.48.1





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin.
  2025-02-03  6:32 [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin iyzsong--- via Guix-patches via
@ 2025-02-03 13:08 ` Maxim Cournoyer
  2025-02-03 14:09   ` bug#76026: " 宋文武 via Guix-patches via
  0 siblings, 1 reply; 6+ messages in thread
From: Maxim Cournoyer @ 2025-02-03 13:08 UTC (permalink / raw)
  To: iyzsong
  Cc: 76026, Vivien Kraus, 宋文武,
	Liliana Marie Prikler

Hello!

iyzsong@envs.net writes:

> From: 宋文武 <iyzsong@member.fsf.org>
>
> Fixes <https://issues.guix.gnu.org/39126>.
>
> The cogl GStreamer sink has been broken:
>   <https://gitlab.gnome.org/Archive/cogl/-/issues/15>
>
> * gnu/packages/gnome.scm (cogl)[inputs]: Remove gstreamer and
> gst-plugins-base.
> [arguments]: Pass "--enable-cogl-gst=no" to configure-flags.

Awesome, you are fixing a 5 years old bug :-).  Nitpick, I'd used

--8<---------------cut here---------------start------------->8---
Fixes: <https://issues.guix.gnu.org/39126>
--8<---------------cut here---------------end--------------->8---

at the bottom of your git commit message, next to the Change-Id (these
are git trailers, must be placed at the bottom of the git message, see
'man git-interpret-trailers').

> Change-Id: I644da53effb52c6b6d8b1f9b6df293545fab963c
> ---
>  gnu/packages/gnome.scm | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 1225570c3c..1e8d813682 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -6308,12 +6308,10 @@ (define-public cogl
>       (list mesa
>             cairo
>             pango
> -           gstreamer
> -           gst-plugins-base
>             wayland))
>      (arguments
>       `(#:disallowed-references (,xorg-server-for-tests)
> -       #:configure-flags (list "--enable-cogl-gst"
> +       #:configure-flags (list "--enable-cogl-gst=no" ;broken and unmaintained
>                                 "--enable-wayland-egl-platform"
>                                 "--enable-wayland-egl-server"

That looks good to me, but reading
https://blogs.gnome.org/clutter/2022/02/16/retiring-clutter/, it seems
we should instead be removing cogl from the distribution, or at least
never propagating it, in which case the above flag would become
unnecessary.

Reviewed-by: Maxim Cournoyer <maxim.cournoyer@gmail>

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#76026: [PATCH] gnu: cogl: Disable gstreamer plugin.
  2025-02-03 13:08 ` Maxim Cournoyer
@ 2025-02-03 14:09   ` 宋文武 via Guix-patches via
  2025-02-04  2:21     ` [bug#76026] " Maxim Cournoyer
  0 siblings, 1 reply; 6+ messages in thread
From: 宋文武 via Guix-patches via @ 2025-02-03 14:09 UTC (permalink / raw)
  To: Maxim Cournoyer
  Cc: 76026-done, Vivien Kraus, 宋文武,
	Liliana Marie Prikler

Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:

> Awesome, you are fixing a 5 years old bug :-).  Nitpick, I'd used
>
> Fixes: <https://issues.guix.gnu.org/39126>

Done, thank you!

> [...]
> That looks good to me, but reading
> https://blogs.gnome.org/clutter/2022/02/16/retiring-clutter/, it seems
> we should instead be removing cogl from the distribution, or at least
> never propagating it, in which case the above flag would become
> unnecessary.

Yes, It's propagated and needed by clutter, which still required by 22
packages.  GNOME propagated it by cheese, where cheese.pc does requires
cluster.  So I think remove the cogl gst plugin is right thing to do
here.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin.
  2025-02-03 14:09   ` bug#76026: " 宋文武 via Guix-patches via
@ 2025-02-04  2:21     ` Maxim Cournoyer
  2025-02-04  5:46       ` Vivien Kraus via Guix-patches via
  0 siblings, 1 reply; 6+ messages in thread
From: Maxim Cournoyer @ 2025-02-04  2:21 UTC (permalink / raw)
  To: 宋文武
  Cc: 76026-done, Vivien Kraus, 宋文武,
	Liliana Marie Prikler

Hi,

宋文武 <iyzsong@envs.net> writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
>
>> Awesome, you are fixing a 5 years old bug :-).  Nitpick, I'd used
>>
>> Fixes: <https://issues.guix.gnu.org/39126>
>
> Done, thank you!
>
>> [...]
>> That looks good to me, but reading
>> https://blogs.gnome.org/clutter/2022/02/16/retiring-clutter/, it seems
>> we should instead be removing cogl from the distribution, or at least
>> never propagating it, in which case the above flag would become
>> unnecessary.
>
> Yes, It's propagated and needed by clutter, which still required by 22
> packages.  GNOME propagated it by cheese, where cheese.pc does requires
> cluster.  So I think remove the cogl gst plugin is right thing to do
> here.

cheese has been replaced by snapshot, so we should remove it from the
gnome core applications [0]

[0]  https://gitlab.gnome.org/Teams/Releng/AppOrganization/-/issues/8#note_1820268

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin.
  2025-02-04  2:21     ` [bug#76026] " Maxim Cournoyer
@ 2025-02-04  5:46       ` Vivien Kraus via Guix-patches via
  2025-02-05  1:58         ` Maxim Cournoyer
  0 siblings, 1 reply; 6+ messages in thread
From: Vivien Kraus via Guix-patches via @ 2025-02-04  5:46 UTC (permalink / raw)
  To: Maxim Cournoyer, 宋文武
  Cc: 76026-done, 宋文武, Liliana Marie Prikler

Hello,

Le mardi 04 février 2025 à 11:21 +0900, Maxim Cournoyer a écrit :
> cheese has been replaced by snapshot,

As far as I understand, snapshot is Rust, so I understand why we would
want to keep cheese around also.

Best regards,

Vivien




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin.
  2025-02-04  5:46       ` Vivien Kraus via Guix-patches via
@ 2025-02-05  1:58         ` Maxim Cournoyer
  0 siblings, 0 replies; 6+ messages in thread
From: Maxim Cournoyer @ 2025-02-05  1:58 UTC (permalink / raw)
  To: Vivien Kraus
  Cc: 76026-done, 宋文武, 宋文武,
	Liliana Marie Prikler

Hi,

Vivien Kraus <vivien@planete-kraus.eu> writes:

> Hello,
>
> Le mardi 04 février 2025 à 11:21 +0900, Maxim Cournoyer a écrit :
>> cheese has been replaced by snapshot,
>
> As far as I understand, snapshot is Rust, so I understand why we would
> want to keep cheese around also.

GNOME already pulls librsvg, which is rust-written as well, so it's not
that big of deal; especially since it can be conditionally added via
(supported-package? snapshot).  The bigger deal is getting it packaged
:-).

-- 
Thanks,
Maxim




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-02-05  2:00 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-03  6:32 [bug#76026] [PATCH] gnu: cogl: Disable gstreamer plugin iyzsong--- via Guix-patches via
2025-02-03 13:08 ` Maxim Cournoyer
2025-02-03 14:09   ` bug#76026: " 宋文武 via Guix-patches via
2025-02-04  2:21     ` [bug#76026] " Maxim Cournoyer
2025-02-04  5:46       ` Vivien Kraus via Guix-patches via
2025-02-05  1:58         ` Maxim Cournoyer

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).