From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wNv2EpQJNWJxbgEAgWs5BA (envelope-from ) for ; Fri, 18 Mar 2022 23:37:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id UJBkEJQJNWKR0gAA9RJhRA (envelope-from ) for ; Fri, 18 Mar 2022 23:37:08 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E83FE38566 for ; Fri, 18 Mar 2022 23:37:07 +0100 (CET) Received: from localhost ([::1]:41810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVLDW-0003EZ-Ro for larch@yhetil.org; Fri, 18 Mar 2022 18:37:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47724) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVLDS-0003EB-2W for guix-patches@gnu.org; Fri, 18 Mar 2022 18:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVLDR-00077f-Po for guix-patches@gnu.org; Fri, 18 Mar 2022 18:37:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVLDR-0007yW-MZ for guix-patches@gnu.org; Fri, 18 Mar 2022 18:37:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54309] What is the process from here? Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 18 Mar 2022 22:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54309 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: fesoj000 , 54309@debbugs.gnu.org Received: via spool by 54309-submit@debbugs.gnu.org id=B54309.164764301330638 (code B ref 54309); Fri, 18 Mar 2022 22:37:01 +0000 Received: (at 54309) by debbugs.gnu.org; 18 Mar 2022 22:36:53 +0000 Received: from localhost ([127.0.0.1]:58611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVLDB-0007xw-GF for submit@debbugs.gnu.org; Fri, 18 Mar 2022 18:36:53 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:38616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVLD9-0007xi-1y for 54309@debbugs.gnu.org; Fri, 18 Mar 2022 18:36:43 -0400 Received: by mail-ej1-f68.google.com with SMTP id r13so19622024ejd.5 for <54309@debbugs.gnu.org>; Fri, 18 Mar 2022 15:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=TOIe3xARKDNXgcEXA/tcf+hFdDS/bZNZokuR+y4M01Q=; b=c6n9CV1KqArAZwZbV86vDqAz/Uhc37geRvVK/K4yCMyGiE+XbrQPD5tPZpztQ1yWTV vwYYsuE9WiVVoLXiqRF89OJFywNY1VtL4HtvvJsoJpyhncdJHanmyulUjjQ7UqFp6BqF /8nGpW0qxNGiC96NFf4wuoF6yL1NaXHf3sN6To/YQI5naeZC0LbZ1orxgANonDy7E0Bg m5Hs4n7/1SJVqwdPTnZjAY1szKcyFQdUfxUulviQtxakJlu+/aAIHPC0/m6LYz8HycaB EeW0YJllQ3xrHqAr/IRXVx5FcSwGLjL7pJaqmNjYx3+1IdQkupUKMItbP/YnUnxl1Ioe yBkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=TOIe3xARKDNXgcEXA/tcf+hFdDS/bZNZokuR+y4M01Q=; b=mcQDhzTkEwNK2vVwpW/5IanSsqq8LnY5pE68SGy8j2ATd5/gWCCS9RrS5fJe2/OGlZ XRnTJPIzwRkOslclp6fkKSyhtILu34wAv2VWTQpnl2OihVzkE2NdsoIlG36GdoOds8sk BneAsd13w0K8PluEoXJeBzOK5lQZ9rSGO6/iFCX0YDDjW1tvehGw7Q11yrSrAlKnWB/9 jnKyOUQG5UW3zYAFu2K+TTBOOnstMbZuHTapkS4eVM6mi8V8LfLrlaF6EwLAxK6C+t71 Fk+RmWf5jL3fau3dJwGMpVXbZnJTIKjHEuxFlPS0np/GT7bxVtsaYUVzmawQUXJT99QB Pokg== X-Gm-Message-State: AOAM532+9Jl0kXL9w7iDrGhy/7Xe/Dg80zuHX7TrTVM6yIdkt9ZSMckU +IaFX/i4Xcw8hHuw1oNA0L8= X-Google-Smtp-Source: ABdhPJxhTEiX9Q2CvOfKy71DvbYcqDGhRgo/vtMd9ZE2EwxP8w2TmKbBFaxgnJgqLb2rBbX3gUYvEA== X-Received: by 2002:a17:907:1687:b0:6df:877e:c81d with SMTP id hc7-20020a170907168700b006df877ec81dmr10666915ejc.306.1647642997249; Fri, 18 Mar 2022 15:36:37 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id t14-20020a170906608e00b006d1455acc62sm4223164ejj.74.2022.03.18.15.36.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 15:36:36 -0700 (PDT) Message-ID: <87f117ba35bb40fe063d5cd0bee61039a5f9801e.camel@gmail.com> From: Liliana Marie Prikler Date: Fri, 18 Mar 2022 23:36:35 +0100 In-Reply-To: References: <8640c4e7b1a46e76ea4df8c21a290d1aa72de0d8.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1647643028; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TOIe3xARKDNXgcEXA/tcf+hFdDS/bZNZokuR+y4M01Q=; b=BKN4apz2nO1YVOx/0EuV+Jk3Uf4y+XTpjwb5JtcPA9mMhGJCSvR7WHUwYjiCZ75bqE0g2q jp9FJnBuiOjEw90av0vZTqbqxg8kiWI1scHkYnHjzrUZGc2XxCbj3N9l8hE+/1mU+mCY0G 0fjdf0W86CSD3OkbA2gehU+lAC+QU5ESGJ8vn0pQ7gSjWFrZsinITUKvJQCirypY5dSQzr UNrUOShWNy8nvchERzWICKjWsAAKdDyyNGGoaKyDl+vLmjNtCAoSxy4mo9ta1jdpRmdCHP bYXmtvPAOQ0DWM5Rm11ej0sZ6XiAnDr2QAa77TEV3Ur+BQ0znBNU9OQINF2+6Q== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1647643028; a=rsa-sha256; cv=none; b=Yn7Q1yPOet6l6gnSr7YBWkoBvW+ihA9TpzfoqvB5/DN2pnUuHv1aMJY2WdEpleyXmp48mh N69s8oi3Ogogviby9dgAelt1+Xv1JdVQPl8CVtpNTfcubUNJlT68mObv7pfPQDK6MxhDQG a6zWIXFOn+lpOBeIcax5OVTZtUGBCN/6D0xeYBwsQcrNvAJ+s8GrE6/5h9fpjTzEjMZXuI IRShYFem081OpfKR7EI729AM563OHnUcA6JCfWd/G490eDUyepBgH2BgEAN98qcD+VBd/J QsNF3Hd+tSX0NWCCFqmLPyW0BCVB5OnuHn+CAzEk40jVOPS03JCv8i+byitloQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=c6n9CV1K; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=c6n9CV1K; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: E83FE38566 X-Spam-Score: 6.96 X-Migadu-Scanner: scn1.migadu.com X-TUID: 5aIJ3m5YsRnA Am Freitag, dem 18.03.2022 um 22:48 +0100 schrieb fesoj000: > On 3/18/22 9:06 PM, Liliana Marie Prikler wrote: > > > So, i assume that there has to be interest and time from a guix > > > developer to review, maybe test and then integrate the > > > changes/packages into one of the branches. > > Note that there have already been two people reviewing; you > > currently > > owe me a v2 addressing the TOCTOU "race" of creating the audit > > directory without 700 permissions. > Yes, that is true. But i addressed the rest, i think. New version > inline. For the record, inline patches generate noise that's hard to separate when applying, so you'd probably want to avoid them. If you don't have git send-email set up regular attachments also work for some, though they do become tedious as well with series. > From 0605a2b5cc8beb816e3ff557d7be060a050f91b7 Mon Sep 17 00:00:00 > 2001 > From: fesoj000 > Date: Wed, 9 Mar 2022 20:07:42 +0100 > Subject: [PATCH] services: auditd: use exclusive log directory for > auditd > > Use /var/log/audit for auditd. This is the upstream default. > > Further, rework the config file generated by auditd-service-type. > Only > write values which diverge from the upstream default. > > * gnu/services/auditd.scm: add auditd-activation function and extend > activation-service-type. > --- >   gnu/services/auditd.scm | 20 +++++++++++++++----- >   1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/gnu/services/auditd.scm b/gnu/services/auditd.scm > index abde811f51..602a6c5a48 100644 > --- a/gnu/services/auditd.scm > +++ b/gnu/services/auditd.scm > @@ -31,10 +31,10 @@ (define-module (gnu services auditd) >               %default-auditd-configuration-directory)) >   >   (define auditd.conf > -  (plain-file "auditd.conf" "log_file = > /var/log/audit.log\nlog_format = \ > -ENRICHED\nfreq = 1\nspace_left = 5%\nspace_left_action = \ > -syslog\nadmin_space_left_action = ignore\ndisk_full_action = \ > -ignore\ndisk_error_action = syslog\n")) > +  (plain-file "auditd.conf" "\ > +space_left = 5% > +space_left_action = syslog > +")) I can understand discarding the log_file entry because we now use upstream default, but the rest should remain imo. >   (define %default-auditd-configuration-directory >     (computed-file "auditd" > @@ -50,6 +50,14 @@ (define-record-type* >                              (default audit)) >     (configuration-directory auditd-configuration-configuration- > directory))      ; file-like >   > +(define (auditd-activation config) > +  (with-imported-modules '((guix build utils)) > +    #~(begin > +        (use-modules (guix build utils)) > +        (let ((var-log-audit "/var/log/audit")) > +          (umask #o077) > +          (mkdir-p var-log-audit))))) > + This would also apply umask 077 to /var and /var/log if those don't already exist. More importantly, code executed after that will also inherit the umask, which I don't think is the intended consequence. Cheers