From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cv4Ix-0002aI-MT for guix-patches@gnu.org; Mon, 03 Apr 2017 11:54:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cv4It-0000Xg-Nw for guix-patches@gnu.org; Mon, 03 Apr 2017 11:54:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:32898) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cv4It-0000XB-Jl for guix-patches@gnu.org; Mon, 03 Apr 2017 11:54:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cv4It-00079J-7m for guix-patches@gnu.org; Mon, 03 Apr 2017 11:54:03 -0400 Subject: bug#26343: [PATCH] gnu: audacity: Update to 2.1.3. Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Kei Kebreau References: <20170402155211.23494-1-kei@openmailbox.org> <87y3viv55d.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <87pogu45y3.fsf@openmailbox.org> <87lgrhbr6d.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Date: Mon, 03 Apr 2017 11:52:59 -0400 In-Reply-To: <87lgrhbr6d.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Mon, 03 Apr 2017 14:40:10 +0200") Message-ID: <87efx94hes.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 26343-done@debbugs.gnu.org --=-=-= Content-Type: text/plain Marius Bakke writes: > Kei Kebreau writes: > >> Marius Bakke writes: >> >>>> (build-system gnu-build-system) >>>> (inputs >>>> ;; TODO: Add portSMF and libwidgetextra once they're packaged. In-tree >>>> @@ -73,7 +79,10 @@ >>>> ("lilv" ,lilv) >>>> ("portaudio" ,portaudio))) >>>> (native-inputs >>>> - `(("gettext" ,gettext-minimal) ;for msgfmt >>>> + `(("autoconf" ,autoconf) >>>> + ("automake" ,automake) >>>> + ("gettext" ,gettext-minimal) ;for msgfmt >>>> + ("libtool" ,libtool) >>>> ("pkg-config" ,pkg-config) >>>> ("python" ,python-2) >>>> ("which" ,which))) >>>> @@ -90,6 +99,12 @@ >>>> (string-append "ID3TAG_LIBS=-L" libid3tag "/lib -lid3tag -lz") >>>> (string-append "LIBMAD_CFLAGS=-I" libmad "/include") >>>> (string-append "LIBMAD_LIBS=-L" libmad "/lib -lmad"))) >>>> + #:phases >>>> + (modify-phases %standard-phases >>>> + ;; Ensure the usage of system libraries. >>>> + (add-before 'configure 'autoreconf >>>> + (lambda _ >>>> + (zero? (system* "autoreconf" "-vfi"))))) >>> >>> Can you clarify how autoreconf ensures usage of system libraries? >>> Usually it just re-generates configure scripts and Makefiles from >>> templates, but should not make any functional difference. >> >> FFmpeg is not detected if autoreconf doesn't run for some reason. With >> this phase, everything is detected like normal. > > Oh. Please mention that in the comment then. Thank you! :) Pushed to master. Thanks for the review! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljib9sACgkQ5qXuPBlG eg0AMA//ZB+/bsiBs3KDv5EeMXeKt+KpjjNGRmEZmyLOQyDJspHVAfY2hydU5OGf fT5quqtXykIXWMauZLjsUAHiRenL+F61EZ9FK5NXpilgHIaQlkRCONePbKCNHXN4 5wtpYkQTqVnjXNfphoR0Ei0POrBlWdXCoyOdJVs919WuUx6y9MJbDAgW656B4tYG 2gK1HPUmyI6qTsJgoZDBDTIUV7GKQBYZfnbzmvjY1BlNg7C9RpLnhIp0Zd5YVCvj YUrjnKHQTv4xeIBegEfD8PvytgSNp1pTvZfA1WIa+4P09TEXVCfZlECoMyFe2uFL kE063fJxQvz3vy89ti6GFmBwMx2aFaEzCuZ/ppuKn8QDl/4xwGx4zVACumum7y+M KLoTd3zi2MJCojtiWCqlFQDr6coFOgPu6D96WJjBkHcLKsREhM0IngimFtWt6cdm 8NF/be/hTSHEdD+KNgOKejUJbHro8LoP9Cz69Vpu2S2zuMBjTcW4GYX8UDLXQKP6 mvahZC4Nl+wV9Jx8XDAVDGqOXCH6z6nBje/emKr+ikX1BTZ1V1qLpVgBMkVFrTyA b3Ya3/8FEOqab5AbRx4Fzki3sXO1dHfBf3AExEY5dqxJ3WLhrMfCIiQ/DYSI89bU WoUyTHTQV0U0LQAQoTmDRBUBOdlQEQ9O+g+fS3Fv59lzRsIFQPY= =XWUA -----END PGP SIGNATURE----- --=-=-=--