From: Kei Kebreau <kei@openmailbox.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 26343-done@debbugs.gnu.org
Subject: bug#26343: [PATCH] gnu: audacity: Update to 2.1.3.
Date: Mon, 03 Apr 2017 11:52:59 -0400 [thread overview]
Message-ID: <87efx94hes.fsf@openmailbox.org> (raw)
In-Reply-To: <87lgrhbr6d.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> (Marius Bakke's message of "Mon, 03 Apr 2017 14:40:10 +0200")
[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]
Marius Bakke <mbakke@fastmail.com> writes:
> Kei Kebreau <kei@openmailbox.org> writes:
>
>> Marius Bakke <mbakke@fastmail.com> writes:
>>
>>>> (build-system gnu-build-system)
>>>> (inputs
>>>> ;; TODO: Add portSMF and libwidgetextra once they're packaged. In-tree
>>>> @@ -73,7 +79,10 @@
>>>> ("lilv" ,lilv)
>>>> ("portaudio" ,portaudio)))
>>>> (native-inputs
>>>> - `(("gettext" ,gettext-minimal) ;for msgfmt
>>>> + `(("autoconf" ,autoconf)
>>>> + ("automake" ,automake)
>>>> + ("gettext" ,gettext-minimal) ;for msgfmt
>>>> + ("libtool" ,libtool)
>>>> ("pkg-config" ,pkg-config)
>>>> ("python" ,python-2)
>>>> ("which" ,which)))
>>>> @@ -90,6 +99,12 @@
>>>> (string-append "ID3TAG_LIBS=-L" libid3tag "/lib -lid3tag -lz")
>>>> (string-append "LIBMAD_CFLAGS=-I" libmad "/include")
>>>> (string-append "LIBMAD_LIBS=-L" libmad "/lib -lmad")))
>>>> + #:phases
>>>> + (modify-phases %standard-phases
>>>> + ;; Ensure the usage of system libraries.
>>>> + (add-before 'configure 'autoreconf
>>>> + (lambda _
>>>> + (zero? (system* "autoreconf" "-vfi")))))
>>>
>>> Can you clarify how autoreconf ensures usage of system libraries?
>>> Usually it just re-generates configure scripts and Makefiles from
>>> templates, but should not make any functional difference.
>>
>> FFmpeg is not detected if autoreconf doesn't run for some reason. With
>> this phase, everything is detected like normal.
>
> Oh. Please mention that in the comment then. Thank you! :)
Pushed to master. Thanks for the review!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-04-03 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 15:52 bug#26343: [PATCH] gnu: audacity: Update to 2.1.3 Kei Kebreau
2017-04-02 22:03 ` Marius Bakke
2017-04-02 22:07 ` Marius Bakke
2017-04-03 1:48 ` Kei Kebreau
2017-04-03 12:40 ` Marius Bakke
2017-04-03 15:52 ` Kei Kebreau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efx94hes.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=26343-done@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).