From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57829)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cvser-0001zm-Bv
	for guix-patches@gnu.org; Wed, 05 Apr 2017 17:40:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cvseo-00015j-9o
	for guix-patches@gnu.org; Wed, 05 Apr 2017 17:40:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:35937)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cvseo-00015d-6H
	for guix-patches@gnu.org; Wed, 05 Apr 2017 17:40:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cvsen-0003GB-VY
	for guix-patches@gnu.org; Wed, 05 Apr 2017 17:40:02 -0400
Subject: bug#26341: [PATCH] build: vm: Add missing module.
Resent-Message-ID: <handler.26341.B26341.149142836412481@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170402150157.7149-1-m.othacehe@gmail.com>
	<8760iks5u4.fsf@gnu.org> <86bmsbrvsk.fsf@gmail.com>
	<86a87vrvpd.fsf@gmail.com>
Date: Wed, 05 Apr 2017 23:39:06 +0200
In-Reply-To: <86a87vrvpd.fsf@gmail.com> (Mathieu Othacehe's message of "Wed,
	05 Apr 2017 12:32:30 +0200")
Message-ID: <87efx6lekl.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 26341@debbugs.gnu.org

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm
> index 3fa318df3..2de664aa7 100644
> --- a/guix/build/syscalls.scm
> +++ b/guix/build/syscalls.scm
> @@ -462,51 +462,51 @@ the returned procedure is called."
>  (define UMOUNT_NOFOLLOW 8)
>=20=20
>  (define mount
> -  (let ((proc (if (module-defined? the-scm-module 'mount)
> -                  (module-ref the-scm-module 'mount)
> -                  (syscall->procedure int "mount" `(* * * ,unsigned-long=
 *)))))
> -    (lambda* (source target type #:optional (flags 0) options
> -                     #:key (update-mtab? #f))
> -      "Mount device SOURCE on TARGET as a file system TYPE.  Optionally,=
 FLAGS
> +  (if (module-defined? the-scm-module 'mount)
> +      (module-ref the-scm-module 'mount)
> +      (let ((proc (syscall->procedure int "mount" `(* * * ,unsigned-long=
 *))))
> +        (lambda* (source target type #:optional (flags 0) options
> +                         #:key (update-mtab? #f))
> +          "Mount device SOURCE on TARGET as a file system TYPE.  Optiona=
lly, FLAGS
>  may be a bitwise-or of the MS_* <sys/mount.h> constants, and OPTIONS may=
 be a
>  string.  When FLAGS contains MS_REMOUNT, SOURCE and TYPE are ignored.  W=
hen
>  UPDATE-MTAB? is true, update /etc/mtab.  Raise a 'system-error' exceptio=
n on
>  error."

That introduces a slight difference: in one case #:update-mtab? is not
honored.  That said, it=E2=80=99s probably OK to ignore it; maybe leave an =
=E2=80=9CXXX=E2=80=9D
comment above just in case.  ;-)

Otherwise LGTM.

Can you send a =E2=80=98git format-patch=E2=80=99 thing?  (Otherwise I coul=
d write the
commit log on your behalf.)

Thanks!

Ludo=E2=80=99.