From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43625)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxW4I-0003E4-Nw
	for guix-patches@gnu.org; Mon, 10 Apr 2017 05:57:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxW4E-0000uR-QM
	for guix-patches@gnu.org; Mon, 10 Apr 2017 05:57:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:42410)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cxW4E-0000uN-Mj
	for guix-patches@gnu.org; Mon, 10 Apr 2017 05:57:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cxW4E-0001BD-DL
	for guix-patches@gnu.org; Mon, 10 Apr 2017 05:57:02 -0400
Subject: bug#26373: [PATCH 6/6] import cran: Skip updating when meta data
	cannot be downloaded.
Resent-Message-ID: <handler.26373.B26373.14918181644448@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170405164210.29428-1-rekado@elephly.net>
	<20170405164210.29428-6-rekado@elephly.net>
Date: Mon, 10 Apr 2017 11:55:49 +0200
In-Reply-To: <20170405164210.29428-6-rekado@elephly.net> (Ricardo Wurmus's
	message of "Wed, 5 Apr 2017 18:42:10 +0200")
Message-ID: <87efx0egd6.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 26373@debbugs.gnu.org

Ricardo Wurmus <rekado@elephly.net> skribis:

> * gnu/packages/bioinformatics.scm (latest-cran-release,
> latest-bioconductor-release): Abort early when meta data cannot be downlo=
aded.
> ---
>  guix/import/cran.scm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/guix/import/cran.scm b/guix/import/cran.scm
> index 557d694ad..fc7a1ed84 100644
> --- a/guix/import/cran.scm
> +++ b/guix/import/cran.scm
> @@ -398,7 +398,8 @@ dependencies."
>      (package->upstream-name package))
>=20=20
>    (define meta
> -    (fetch-description 'cran upstream-name))
> +    (false-if-exception
> +     (fetch-description 'cran upstream-name)))

I would prefer catching only the relevant exception.  So I suppose
something like:

  (guard (c ((http-get-error? c)
             (if (=3D 404 (http-get-error-code c))
                 #f
                 (raise c))))
    (fetch-description 'cran upstream-name))

However I see that =E2=80=98fetch-description=E2=80=99 already does that, s=
o what
exceptions are we protecting against?

Thanks,
Ludo=E2=80=99.