unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* bug#27176: [PATCH] gnu: Add python-xsge.
@ 2017-05-31 21:57 Kei Kebreau
  2017-05-31 22:41 ` Danny Milosavljevic
  0 siblings, 1 reply; 3+ messages in thread
From: Kei Kebreau @ 2017-05-31 21:57 UTC (permalink / raw)
  To: 27176; +Cc: Kei Kebreau

* gnu/packages/game-development.scm (python-xsge, python2-xsge): New
variables.
---
 gnu/packages/game-development.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index b7bcdee94..80f56b245 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -249,6 +249,43 @@ levels.")
        `(("python2-pathlib" ,python2-pathlib)
          ,@(package-propagated-inputs python2-tmx))))))
 
+(define-public python-xsge
+  (package
+    (name "python-xsge")
+    (version "2017.04.10")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://savannah/xsge/xsge-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "04il5yx0py6kchxxw6ydbbx0wpiyjf9dgkwsdynirpkczlnid3am"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (replace 'install
+           (lambda* (#:key outputs #:allow-other-keys)
+             (zero?
+              (system* "python" "setup.py" "install"
+                       (string-append "--prefix=" (assoc-ref outputs "out"))
+                       "--root=/")))))
+       #:tests? #f))
+    (propagated-inputs
+     `(("python-sge-pygame" ,python-sge-pygame)
+       ("python-pygame" ,python-pygame)
+       ("python-six" ,python-six)
+       ("python-tmx" ,python-tmx)))
+    (home-page "http://xsge.nongnu.org")
+    (synopsis "Extensions for the SGE Game Engine")
+    (description
+     "xSGE is a collection of modules that make doing certain tasks with the SGE
+Game Engine easier.")
+    (license license:gpl3+)))
+
+(define-public python2-xsge
+  (package-with-python2 python-xsge))
+
 (define-public tiled
   (package
     (name "tiled")
-- 
2.13.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#27176: [PATCH] gnu: Add python-xsge.
  2017-05-31 21:57 bug#27176: [PATCH] gnu: Add python-xsge Kei Kebreau
@ 2017-05-31 22:41 ` Danny Milosavljevic
  2017-06-01  0:50   ` Kei Kebreau
  0 siblings, 1 reply; 3+ messages in thread
From: Danny Milosavljevic @ 2017-05-31 22:41 UTC (permalink / raw)
  To: Kei Kebreau; +Cc: 27176

> +         (replace 'install
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (zero?
> +              (system* "python" "setup.py" "install"
> +                       (string-append "--prefix=" (assoc-ref outputs "out"))
> +                       "--root=/")))))

What's the difference to what the python-build-system does?

> +       #:tests? #f))

Why?

> +    (description
> +     "xSGE is a collection of modules that make doing certain tasks with the SGE
> +Game Engine easier.")

Like what? :)

Otherwise LGTM!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#27176: [PATCH] gnu: Add python-xsge.
  2017-05-31 22:41 ` Danny Milosavljevic
@ 2017-06-01  0:50   ` Kei Kebreau
  0 siblings, 0 replies; 3+ messages in thread
From: Kei Kebreau @ 2017-06-01  0:50 UTC (permalink / raw)
  To: Danny Milosavljevic; +Cc: 27176-done

[-- Attachment #1: Type: text/plain, Size: 1003 bytes --]

Danny Milosavljevic <dannym@scratchpost.org> writes:

>> +         (replace 'install
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (zero?
>> +              (system* "python" "setup.py" "install"
>> +                       (string-append "--prefix=" (assoc-ref outputs "out"))
>> +                       "--root=/")))))
>
> What's the difference to what the python-build-system does?

The python-build-system also uses "--single-version-externally-managed"
which is unsupported by xSGE's setup.py script for some reason. I've
added a comment stating this.

>
>> +       #:tests? #f))
>
> Why?
>

I forgot the "no check target" comment, but I've since added it.

>> +    (description
>> +     "xSGE is a collection of modules that make doing certain tasks with the SGE
>> +Game Engine easier.")
>
> Like what? :)

I added details from the list on the xSGE about page.

>
> Otherwise LGTM!

Pushed to master as e99039b5da6dfbc49a2f8cf0fb523a8049fe5ef8!
Thanks for the review.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-01  0:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-31 21:57 bug#27176: [PATCH] gnu: Add python-xsge Kei Kebreau
2017-05-31 22:41 ` Danny Milosavljevic
2017-06-01  0:50   ` Kei Kebreau

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).