From: ludo@gnu.org (Ludovic Courtès)
To: Kei Kebreau <kei@openmailbox.org>
Cc: 27628@debbugs.gnu.org
Subject: [bug#27628] [PATCH 1/3] gnu: gcl: Ensure gcc and binutils are available at runtime.
Date: Wed, 12 Jul 2017 14:04:35 +0200 [thread overview]
Message-ID: <87eftlg8to.fsf@gnu.org> (raw)
In-Reply-To: <20170709011634.12832-1-kei@openmailbox.org> (Kei Kebreau's message of "Sat, 8 Jul 2017 21:16:32 -0400")
Kei Kebreau <kei@openmailbox.org> skribis:
> * gnu/packages/lisp.scm (gcl)[arguments]: Add -fgnu89-inline to CFLAGS.
> Add GCC path to make-flags. Modify 'pre-conf' phase. Add 'wrap' phase.
> ---
> gnu/packages/lisp.scm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index e92ae2ebf..6bd9e94a7 100644
> --- a/gnu/packages/lisp.scm
> +++ b/gnu/packages/lisp.scm
> @@ -88,6 +88,10 @@
> `(#:parallel-build? #f ; The build system seems not to be thread safe.
> #:tests? #f ; There does not seem to be make check or anything similar.
> #:configure-flags '("--enable-ansi") ; required for use by the maxima package
> + #:make-flags (list
> + "CFLAGS=-fgnu89-inline" ; removes inline function warnings
> + (string-append "GCC=" (assoc-ref %build-inputs "gcc")
> + "/bin/gcc"))
> #:phases (modify-phases %standard-phases
> (add-before 'configure 'pre-conf
> (lambda _
> @@ -104,6 +108,24 @@
> (string-append "SHELL=" (which "bash")))
> (("SHELL=/bin/sh")
> (string-append "SHELL=" (which "sh"))))
> + (substitute* "h/linux.defs"
> + (("#CC") "CC")
> + (("-fwritable-strings") "")
> + (("-Werror") ""))
> + #t))
> + (add-after 'install 'wrap
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + (let* ((gcl (assoc-ref outputs "out"))
> + (input-path (lambda (lib path)
> + (string-append
> + (assoc-ref inputs lib) path)))
> + (binaries '("gcc" "ld-wrapper" "binutils")))
> +
> + (wrap-program (string-append gcl "/bin/gcl")
> + `("PATH" prefix
> + ,(map (lambda (binary)
> + (input-path binary "/bin"))
> + binaries))))
Please add comments explaining why GCC and Binutils need to be available
at run time (and also libc and ld-wrapper?). In the absence of an
explanation, my natural reaction would be to think this is a bug. :-)
OK with this change, thanks!
Ludo’.
prev parent reply other threads:[~2017-07-12 12:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 1:12 [bug#27628] Fix compilation features of GCL and Maxima Kei Kebreau
2017-07-09 1:16 ` [bug#27628] [PATCH 1/3] gnu: gcl: Ensure gcc and binutils are available at runtime Kei Kebreau
2017-07-09 1:16 ` [bug#27628] [PATCH 2/3] Revert "gnu: maxima: Ensure gcc is available at runtime." Kei Kebreau
2017-07-12 12:05 ` Ludovic Courtès
2017-07-09 1:16 ` [bug#27628] [PATCH 3/3] gnu: maxima: Ensure gcc and binutils available at runtime Kei Kebreau
2017-07-12 12:06 ` Ludovic Courtès
2017-07-12 12:07 ` Ludovic Courtès
2017-07-12 23:31 ` Kei Kebreau
2017-07-17 8:19 ` Ludovic Courtès
2017-07-18 14:11 ` Kei Kebreau
2017-07-18 14:53 ` Ludovic Courtès
2017-07-18 22:10 ` Kei Kebreau
2017-07-18 23:34 ` Marius Bakke
2017-07-20 2:03 ` Kei Kebreau
2017-07-24 16:08 ` Kei Kebreau
2017-07-19 8:55 ` Ludovic Courtès
2017-07-25 13:13 ` bug#27628: " Kei Kebreau
2017-07-12 12:04 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eftlg8to.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=27628@debbugs.gnu.org \
--cc=kei@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).