From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49041)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f1CeL-0008DC-FE
	for guix-patches@gnu.org; Wed, 28 Mar 2018 11:06:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f1CeI-0006BS-AW
	for guix-patches@gnu.org; Wed, 28 Mar 2018 11:06:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:49603)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1f1CeI-0006BG-6o
	for guix-patches@gnu.org; Wed, 28 Mar 2018 11:06:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1f1CeH-0006CZ-Rs
	for guix-patches@gnu.org; Wed, 28 Mar 2018 11:06:01 -0400
Subject: [bug#30966] [PATCH] gnu: openssl: Replace with OpenSSL 1.0.2o [fixes
	CVE-2018-0739].
Resent-Message-ID: <handler.30966.B30966.152224954323815@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <97a98c7fe0dfe6f98839e9cabf8e0022d7d2a8c8.1522190671.git.leo@famulari.name>
Date: Wed, 28 Mar 2018 17:05:37 +0200
In-Reply-To: <97a98c7fe0dfe6f98839e9cabf8e0022d7d2a8c8.1522190671.git.leo@famulari.name>
	(Leo Famulari's message of "Tue, 27 Mar 2018 18:44:31 -0400")
Message-ID: <87efk4tf3y.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 30966@debbugs.gnu.org

Hi Leo,

Leo Famulari <leo@famulari.name> skribis:

> * gnu/packages/tls.scm (openssl)[replacement]: New field.
> (openssl-1.0.2o): New variable.

[...]

> +              (uri (list (string-append "https://www.openssl.org/source/=
openssl-"
> +                                        version ".tar.gz")
> +                         (string-append "ftp://ftp.openssl.org/source/"
> +                                        name "-" version ".tar.gz")
> +                         (string-append "ftp://ftp.openssl.org/source/ol=
d/"
> +                                        (string-trim-right version char-=
set:letter)
> +                                        "/" name "-" version ".tar.gz")))

Eventually we should factorize this in an =E2=80=98openssl-source-url=E2=80=
=99 procedure.

> +              (sha256
> +               (base32
> +                "0kcy13l701054nhpbd901mz32v1kn4g311z0nifd83xs2jbmqgzc"))
> +              ;; Erase the inherited snippet, which isn't applicable to
> +              ;; OpenSSL 1.0.2o.
> +              (snippet
> +               '(begin
> +                  #t))))))

Use (snippet #f) to really annihilate the snippet, otherwise you create
a snippet that does nothing, yet entails and unpack-and-repack step.

OK with this change, thank you!

Ludo=E2=80=99.