From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33621)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fDFs6-0005V7-Cm
	for guix-patches@gnu.org; Mon, 30 Apr 2018 16:58:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fDFs2-0005HT-Fo
	for guix-patches@gnu.org; Mon, 30 Apr 2018 16:58:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:36465)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fDFs2-0005HN-Cg
	for guix-patches@gnu.org; Mon, 30 Apr 2018 16:58:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fDFs2-0000PX-5Y
	for guix-patches@gnu.org; Mon, 30 Apr 2018 16:58:02 -0400
Subject: [bug#31298] [PATCH 2/2] gnu: Add yubico-piv-tool.
Resent-Message-ID: <handler.31298.B31298.15251218521540@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180428105713.18157-1-cmmarusich@gmail.com>
	<20180428110241.18273-1-cmmarusich@gmail.com>
	<20180428110241.18273-2-cmmarusich@gmail.com>
Date: Mon, 30 Apr 2018 22:57:27 +0200
In-Reply-To: <20180428110241.18273-2-cmmarusich@gmail.com> (Chris Marusich's
	message of "Sat, 28 Apr 2018 04:02:41 -0700")
Message-ID: <87efiwv2dk.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Chris Marusich <cmmarusich@gmail.com>
Cc: 31298@debbugs.gnu.org

Chris Marusich <cmmarusich@gmail.com> skribis:

> * gnu/packages/security-token.scm (yubico-piv-tool): New variable.

LGTM!

> +    (home-page "https://developers.yubico.com/yubico-piv-tool/")
> +    (synopsis "Interact with the PIV application on a YubiKey")
> +    (description
> +     "The Yubico PIV tool is used for interacting with the Privilege and
> +Identification Card (PIV) application on a YubiKey.  With it you may gen=
erate
> +keys on the device, import keys and certificates, create certificate req=
uests,
> +and other operations.  It includes a library and a command-line tool.")
> +    ;; The file ykcs11/pkcs11.h also declares an additional, very short =
free
> +    ;; license for that one file.  Please see it for details.  The files=
 in
> +    ;; the m4 directory are licensed under either a similarly terse free
> +    ;; license or gpl2+.  The vast majority of files are licensed under =
bsd-2.
> +    (license license:bsd-2)))

I think you can omit the bit about the m4/ directory since it=E2=80=99s pre=
tty
much the same story in many packages.

Thanks,
Ludo=E2=80=99.