From: Kei Kebreau <kkebreau@posteo.net>
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 31733@debbugs.gnu.org
Subject: [bug#31733] [PATCH] gnu: encfs: Update to 1.9.5.
Date: Sat, 16 Jun 2018 11:23:33 -0400 [thread overview]
Message-ID: <87efh63gcq.fsf@posteo.net> (raw)
In-Reply-To: <877emyhlo6.fsf@gmail.com> (Pierre Neidhardt's message of "Sat, 16 Jun 2018 16:04:57 +0200")
[-- Attachment #1: Type: text/plain, Size: 1702 bytes --]
Pierre Neidhardt <ambrevar@gmail.com> writes:
>>> Any particular reason you decided to use '(zero? (system* ...))' rather
>>> than '(invoke ...)' for this phase? I tried it with 'invoke' and it
>>> worked fine.
>
> I did not know about `invoke' :)
> I just found its definition in guix/build/utils.scm.
>
Well now you know! :)
>> Also, do note that the snippet needs to be updated, as bundled libraries
>> (now including googletest) have moved to the "vendor" subdirectory. Once
>> you remove the "vendor" subdirectory, you may have to add 'googletest'
>> from '(gnu packages check)' to the native-inputs.
>
> So the vender directory has 3 dependencies:
>
> - tinyxml which is already used externally, so it's safe to remove the
> embedded version.
>
> - easyloggingpp which is not packaged in Guix I believe. We need to
> package it first before we can remove it.
>
Observation agrees with both of these.
> - googletest: this one does not have an option in CMakeList.txt to be
> used externally. So either we report upstream or we patch the
> CMakeList.txt.
>
I see that while CMakeLists.txt doesn't have an external option to
control this, it *does* look for googletest in the vendor
directory. Perhaps we can add our own googletest as a native input and
remove the bundled googletest and CMakeLists.txt's references to it in a
snippet?
> All things considered, why not sticking to the vendored libraries?
>
We try to unbundle third-party software in our packages in order to ease
the burden of security maintenance and avoid duplication of work in
general. There are probably other reasons that I can't remember right
now, too.
> What do you think?
This sounds actionable to me!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-06-16 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 9:47 [bug#31733] [PATCH] gnu: encfs: Update to 1.9.5 Pierre Neidhardt
2018-06-14 14:53 ` Kei Kebreau
2018-06-14 15:04 ` Kei Kebreau
2018-06-16 14:04 ` Pierre Neidhardt
2018-06-16 15:23 ` Kei Kebreau [this message]
2018-06-16 15:44 ` Pierre Neidhardt
2018-06-16 20:35 ` Kei Kebreau
2018-06-17 17:11 ` Pierre Neidhardt
2018-06-18 2:01 ` bug#31733: " Kei Kebreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efh63gcq.fsf@posteo.net \
--to=kkebreau@posteo.net \
--cc=31733@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).