unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Kei Kebreau <kkebreau@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 35172-done@debbugs.gnu.org
Subject: bug#35172: [PATCH] gnu: Add git-lfs.
Date: Sat, 20 Apr 2019 16:42:00 -0400	[thread overview]
Message-ID: <87ef5wjtnr.fsf@posteo.net> (raw)
In-Reply-To: <877ebrqpyq.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 18 Apr 2019 17:43:09 +0200")

[-- Attachment #1: Type: text/plain, Size: 1675 bytes --]

Ludovic Courtès <ludo@gnu.org> writes:

> Hello,
>
> Kei Kebreau <kkebreau@posteo.net> skribis:
>
>> Kei Kebreau <kkebreau@posteo.net> writes:
>>
>>> +(define-public git-lfs
>>> +  (package
>>> +    (name "git-lfs")
>>> +    (version "2.7.1")
>>> +    (source (origin
>>> +              (method git-fetch)
>>> +              (uri (git-reference
>>> +                    (url "https://github.com/git-lfs/git-lfs")
>>> +                    (commit (string-append "v" version))))
>>> +              (file-name (git-file-name name version))
>>> +              (sha256
>>> +               (base32
>>> +                "10v38w8qfz0x8750kv31n8gg2dimvq4wz40m374pd1xaypfs9670"))))
>>> +    (build-system go-build-system)
>>> +    (arguments
>>> +     '(#:import-path "github.com/git-lfs/git-lfs"))
>>> +    (home-page "https://git-lfs.github.com/")
>>> +    (synopsis "Git extension for versioning large files")
>>> +    (description
>>> + "Git Large File Storage (LFS) replaces large files such as audio
>>> samples,
>>> +videos, datasets, and graphics with text pointers inside Git,
>>> while storing the
>>> +file contents on a remote server like GitHub.com or GitHub Enterprise.")
>>
>> I realize that I can remove the GitHub promotion from the description
>> without any loss of understanding.
>
> Agreed.
>
>>> +    (license license:expat)))
>>
>> This is my first Go package, so any corrections or tips are especially
>> appreciated!
>
> I’m no nothing about Go, but it LGTM!  If something is broken, don’t
> worry, people will tell you.  ;-)
>

:-)

> Thank you,
> Ludo’.

Pushed to master, thank you for reviewing!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2019-04-20 20:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-06 14:35 [bug#35172] [PATCH] gnu: Add git-lfs Kei Kebreau
2019-04-06 14:55 ` Kei Kebreau
2019-04-18 15:43   ` Ludovic Courtès
2019-04-20 20:42     ` Kei Kebreau [this message]
2019-04-21 12:50       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef5wjtnr.fsf@posteo.net \
    --to=kkebreau@posteo.net \
    --cc=35172-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).