unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Timothy Sample <samplet@ngyro.com>
To: Robert Vollmert <rob@vllmrt.net>
Cc: 35930-done@debbugs.gnu.org
Subject: bug#35930: haskell Setup.hs-related changes
Date: Thu, 13 Jun 2019 23:05:35 -0400	[thread overview]
Message-ID: <87ef3w50jk.fsf@ngyro.com> (raw)
In-Reply-To: <A893F259-CD37-41F6-ADD4-E240950903A5@vllmrt.net> (Robert Vollmert's message of "Thu, 13 Jun 2019 18:20:21 +0200")

Hello,

Robert Vollmert <rob@vllmrt.net> writes:

>> On 13. Jun 2019, at 17:57, Timothy Sample <samplet@ngyro.com> wrote:
>>>  https://issues.guix.gnu.org/issue/35930
>> 
>> The first patch breaks “ghc-easyplot”.
>> 
>> I’m currently building some packages to test the other patches, and if
>> everything builds fine, they LGTM with some minor tweaks (which I’ve
>> already made).  Should I push it to master or staging?  It means
>> rebuilding all of our Haskell packages, which is a few hundered
>> packages.
>> 
>> Robert, do you know why the first patch doesn’t work?  Should I just
>> omit it?
>
> Yes go head, I thought it worked at some point but am very doubtful
> right now. I’ll look into it again, but it’s not a necessary part here
> I think.

Pushed to staging, since ~550 packages is well over the manual’s
recommended limit of 300.

I omitted the first patch and merged the last two together (doing so is
consistent with similar changes in the past).

Thanks Robert!


-- Tim

      reply	other threads:[~2019-06-14  3:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 19:52 [bug#35930] haskell Setup.hs-related changes Robert Vollmert
2019-05-27 19:52 ` [bug#35934] [PATCH 1/4] gnu: ghc-easy-plot: remove superfluous Setup.hs rename step Robert Vollmert
2019-05-27 19:52 ` [bug#35931] [PATCH 2/4] guix: haskell-build-system: correct haddock phase documentation Robert Vollmert
2019-05-27 19:52 ` [bug#35932] [PATCH 3/4] guix: haskell-build-system: generate Setup.hs if not exists Robert Vollmert
2019-05-27 19:52 ` [bug#35933] [PATCH 4/4] gnu: haskell: leave Setup.hs generation to build system Robert Vollmert
2019-05-27 19:56 ` [bug#35930] [PATCH 1/4] gnu: ghc-easy-plot: remove superfluous Setup.hs rename step Robert Vollmert
2019-05-27 19:56   ` [bug#35930] [PATCH 2/4] guix: haskell-build-system: correct haddock phase documentation Robert Vollmert
2019-05-27 19:56   ` [bug#35930] [PATCH 3/4] guix: haskell-build-system: generate Setup.hs if not exists Robert Vollmert
2019-05-27 19:56   ` [bug#35930] [PATCH 4/4] gnu: haskell: leave Setup.hs generation to build system Robert Vollmert
2019-06-13  8:36 ` [bug#35930] haskell Setup.hs-related changes Ludovic Courtès
2019-06-13 15:57   ` Timothy Sample
2019-06-13 16:20     ` Robert Vollmert
2019-06-14  3:05       ` Timothy Sample [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef3w50jk.fsf@ngyro.com \
    --to=samplet@ngyro.com \
    --cc=35930-done@debbugs.gnu.org \
    --cc=rob@vllmrt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).