From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:35169)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iGIMi-0002GG-AL
 for guix-patches@gnu.org; Fri, 04 Oct 2019 03:51:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iGIMh-0000MO-16
 for guix-patches@gnu.org; Fri, 04 Oct 2019 03:51:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:32843)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iGIMg-0000MK-Un
 for guix-patches@gnu.org; Fri, 04 Oct 2019 03:51:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iGIMg-0002At-Sr
 for guix-patches@gnu.org; Fri, 04 Oct 2019 03:51:02 -0400
Subject: [bug#37598] [PATCH 1/4] gnu: Add python-jinja2-time.
Resent-Message-ID: <handler.37598.B37598.15701754528337@debbugs.gnu.org>
References: <20191003121316.irq3vdmu4ov6dygb@rafflesia>
 <20191004072040.fpwcb2lmeih2mvsv@rafflesia>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <20191004072040.fpwcb2lmeih2mvsv@rafflesia>
Date: Fri, 04 Oct 2019 09:50:40 +0200
Message-ID: <87eezt3q5r.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: 37598@debbugs.gnu.org


Hello Tanguy,

Thanks for your patches. A few remarks (more details at
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html):

> Subject: [PATCH 1/4] gnu: Add python-jinja2-time.
>

You need to add a commit message, compliant with ChangeLog format. You
can find examples in commit history.

> +    (description
> +     "Jinja2 Extension for Dates and Times")

Description should follow the rules dictated at
https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html#Synopses-and-Descriptions,
most specifically "Descriptions should take between five and ten
lines. Use full sentences, and avoid using acronyms without first
introducing them".

Otherwise, your serie seems fine :)

Thanks,

Mathieu