unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 37908@debbugs.gnu.org, Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#37908] [PATCH 0/2] Remove monolithic qt5 (and other unused package)
Date: Fri, 01 Nov 2019 15:14:08 +0100	[thread overview]
Message-ID: <87eeyrd6q7.fsf@gnu.org> (raw)
In-Reply-To: <531d87da-8ad9-e6e9-cfce-9d447e9b5233@crazy-compilers.com> (Hartmut Goebel's message of "Fri, 1 Nov 2019 13:18:58 +0100")

Hi Hartmut,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> From: Hartmut Goebel <h.goebel@crazy-compilers.com>
> Date: Thu, 24 Oct 2019 20:28:26 +0200
> Subject: [Patch v2 2/2] gnu: Deprecate monolithic qt5.
>
> This package was not used anywhere but as a based for qt-4.
>
> * gnu/packages/qt.scm (qt-4): Copy all relevant package definition
>   parts from 'qt'.
>   (qt): Define as a deprecated alias for 'qtbase`.

Please ensure that “guix build qt@4 -nd” returns the same derivation
before and after the change.

> +(define-deprecated qt qtbase qtbase)

Perhaps add a comment above saying that ‘qt’ used to refer to the
monolithic Qt 5.x package?

Otherwise LGTM!  Efraim, can you say if this is fine with you?
When Efraim agrees to the change, I guess you can go ahead.

Thank you,
Ludo’.

  reply	other threads:[~2019-11-01 14:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 19:20 [bug#37908] [PATCH 0/2] Remove monolithic qt5 (and other unused package) Hartmut Goebel
2019-10-24 19:23 ` [bug#37908] [PATCH 1/2] gnu: Remove qtdeclarative-render2d Hartmut Goebel
2019-10-24 19:23   ` [bug#37908] [PATCH 2/2] gnu: Remove monolithic qt5 Hartmut Goebel
2019-10-25 10:34 ` [bug#37908] [PATCH 0/2] Remove monolithic qt5 (and other unused package) Efraim Flashner
2019-10-25 10:43   ` Efraim Flashner
2019-10-25 21:33     ` Ludovic Courtès
2019-10-28  9:06       ` Hartmut Goebel
2019-11-01 10:49         ` Ludovic Courtès
2019-11-01 12:18           ` Hartmut Goebel
2019-11-01 14:14             ` Ludovic Courtès [this message]
2019-11-01 14:39               ` Efraim Flashner
2019-11-01 16:09                 ` bug#37908: " Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeyrd6q7.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=37908@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=h.goebel@crazy-compilers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).