From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: 39269@debbugs.gnu.org
Subject: [bug#39269] [PATCH 1/2] guix: qt-build-system: Add phase `check-setup`.
Date: Sat, 25 Jan 2020 20:34:39 +0100 [thread overview]
Message-ID: <87eevnpbxs.fsf@nckx> (raw)
In-Reply-To: <1430436b83e4aaea89de3d1cdd4613b935e39cb5.1579880425.git.h.goebel@crazy-compilers.com>
[-- Attachment #1: Type: text/plain, Size: 353 bytes --]
Hartmut Goebel 写道：
> * guix/build/qt-build-system.scm (check-setup): New function.
> (%standard-phases): Add as new phase `check-setup before
> `check.
LGTM with one tweak: please rename this to ‘set-up-tests’ or
similar.
Guix's phase naming implies that ‘check-setup’ checks something
called setup.
Thanks!
T G-R
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-01-25 19:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 16:22 [bug#39268] [PATCH 0/2] Add phase `check-setup` to qt-build-system Hartmut Goebel
2020-01-24 16:22 ` [bug#39269] [PATCH 1/2] guix: qt-build-system: Add phase `check-setup` Hartmut Goebel
2020-01-25 11:07 ` Danny Milosavljevic
2020-01-25 13:29 ` Hartmut Goebel
2020-01-28 12:05 ` bug#39269: " Hartmut Goebel
2020-01-25 19:34 ` Tobias Geerinckx-Rice via Guix-patches via [this message]
2020-01-24 16:22 ` [bug#39270] [PATCH 2/2] gnu: Cleanup KDE packages to use the update qt-build-system Hartmut Goebel
2020-01-25 11:07 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eevnpbxs.fsf@nckx \
--to=guix-patches@gnu.org \
--cc=39269@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).