From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:53591)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jGgrn-0002yi-44
 for guix-patches@gnu.org; Tue, 24 Mar 2020 06:33:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jGgrm-0004Lx-5V
 for guix-patches@gnu.org; Tue, 24 Mar 2020 06:33:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:47960)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jGgrm-0004Lr-2h
 for guix-patches@gnu.org; Tue, 24 Mar 2020 06:33:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jGgrl-0003Fw-W0
 for guix-patches@gnu.org; Tue, 24 Mar 2020 06:33:01 -0400
Subject: [bug#40207] [PATCH 1/2] installer: tests: Use a filter to select
 desktop-environments.
Resent-Message-ID: <handler.40207.B40207.158504592712444@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20200324083443.30544-1-m.othacehe@gmail.com>
 <20200324083626.30650-1-m.othacehe@gmail.com>
Date: Tue, 24 Mar 2020 11:31:58 +0100
In-Reply-To: <20200324083626.30650-1-m.othacehe@gmail.com> (Mathieu Othacehe's
 message of "Tue, 24 Mar 2020 09:36:25 +0100")
Message-ID: <87eetiniw1.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: 40207@debbugs.gnu.org

Hi Mathieu,

Mathieu Othacehe <m.othacehe@gmail.com> skribis:

> * gnu/installer/tests.scm (choose-services): Turn desktop-environments li=
st
> into a choose-desktop-environment procedure. This way, it is easier to se=
lect
> all desktop-environments or none, in the same way as choose-network-servi=
ce?
> and choose-network-management-tool? arguments.

[...]

> +     (let ((services* (filter choose-desktop-environment? services)))
> +       (set! desktop-environments services*)
> +       services*))

Maybe rename =E2=80=98services*=E2=80=99 to =E2=80=98desktops=E2=80=99?

=E2=80=98set!=E2=80=99 hurts my eyes :-) but let=E2=80=99s get over it.  Ev=
entually we can
change convert to run expressions in =E2=80=98%state-monad=E2=80=99 or some=
thing.

Ludo=E2=80=99.