From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 40307@debbugs.gnu.org
Subject: [bug#40307] gnu: packages: telephony: Add spandsp
Date: Tue, 31 Mar 2020 01:21:03 -0400 [thread overview]
Message-ID: <87eet9xfpc.fsf@gmail.com> (raw)
In-Reply-To: <f684e597826a57564ddbbcc16cb3d480@disroot.org> (Raghav Gururajan's message of "Sun, 29 Mar 2020 03:37:04 +0000")
Hello again :-)
"Raghav Gururajan" <raghavgururajan@disroot.org> writes:
> Hello Guix!
>
> Please find the attached patch to add "spandsp" package.
>
> Regards,
> RG.
>
> From 68e093007f2c5678895a5cbe29f2b1ac2c357ba2 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Sat, 28 Mar 2020 23:32:57 -0400
> Subject: [PATCH 13/13] gnu: packages: telephony: Add spandsp
This prefix also need to be adjusted to just "gnu: Add ...".
> * gnu/packages/telephony.scm (spandsp): New variable.
> ---
> gnu/packages/telephony.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
> index fe6c230693..c68f80669c 100644
> --- a/gnu/packages/telephony.scm
> +++ b/gnu/packages/telephony.scm
> @@ -52,6 +52,7 @@
> #:use-module (gnu packages gnome)
> #:use-module (gnu packages gnupg)
> #:use-module (gnu packages gtk)
> + #:use-module (gnu packages image)
> #:use-module (gnu packages libcanberra)
> #:use-module (gnu packages linux)
> #:use-module (gnu packages multiprecision)
> @@ -84,6 +85,35 @@
> #:use-module (guix build-system gnu)
> #:use-module (guix build-system qt))
>
> +(define-public spandsp
> + (package
> + (name "spandsp")
> + (version "0.0.6")
> + (source
> + (origin
> + (method url-fetch)
> + (uri
> + (string-append "https://www.soft-switch.org/downloads/" name "/"
> + name "-" version ".tar.gz"))
> + (sha256
> + (base32 "0rclrkyspzk575v8fslzjpgp4y2s4x7xk3r55ycvpi4agv33l1fc"))))
> + (build-system gnu-build-system)
The check phase doesn't seem to run anything; it just passes. Perhaps
we don't start it the correct way?
> + (native-inputs
> + `(("libtiff" ,libtiff)
> + ("zlib" ,zlib)))
> + (synopsis "DSP library for telephony")
> + (description "SpanDSP is a library of DSP functions for telephony, in the 8000 sample
> +per second world of E1s, T1s, and higher order PCM channels. It contains low level
> +functions, such as basic filters. It also contains higher level functions, such as
> +cadenced supervisory tone detection, and a complete software FAX
> machine.")
This body of text is a bit too wide. We limit our column width at 80
characters. You can use M-q in Emacs to automatically re-flow the
paragraph. I kind of like the concise description from Debian, because
it gives me a better idea of what the package can be used for: "SpanDSP
is a low-level signal processing library that modulate and demodulate
signals commonly used in telephony, such as the "noise" generated by a
fax modem or DTMF touchpad."
> + (home-page "https://www.soft-switch.org/index.html")
> + (license
> + (list
> + ;; For Library
> + license:lgpl2.1+
> + ;; For Test Suites and Support Programs
> + license:gpl2+))))
> +
My preferred style for formatting the license list would be:
(license (list license:lgpl2.1+ ;for the library
license:gpl2+)))) ;for the test suites and support programs
The indentation of the package is off. Please use Emacs or the
indent-code.el script :-).
Maxim
next prev parent reply other threads:[~2020-03-31 5:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 3:37 [bug#40307] gnu: packages: telephony: Add spandsp Raghav Gururajan
2020-03-31 5:21 ` Maxim Cournoyer [this message]
2020-03-31 5:25 ` Maxim Cournoyer
2020-03-31 16:29 ` [bug#40307] Alternative Source for TarBall Raghav Gururajan
2020-03-31 16:37 ` Raghav Gururajan
2020-03-31 21:03 ` bug#40307: gnu: packages: telephony: Add spandsp Maxim Cournoyer
2020-04-02 4:00 ` [bug#40307] gnu: Add spandsp (v2) Raghav Gururajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eet9xfpc.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=40307@debbugs.gnu.org \
--cc=raghavgururajan@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).