From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qLcZMXwG0F4hSAAA0tVLHw (envelope-from ) for ; Thu, 28 May 2020 18:44:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OJoyLXwG0F49GwAA1q6Kng (envelope-from ) for ; Thu, 28 May 2020 18:44:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1D6F19402D1 for ; Thu, 28 May 2020 18:44:12 +0000 (UTC) Received: from localhost ([::1]:58070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeNVh-00079I-Kh for larch@yhetil.org; Thu, 28 May 2020 14:44:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jeNVa-000781-UL for guix-patches@gnu.org; Thu, 28 May 2020 14:44:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jeNVa-0006kz-JO for guix-patches@gnu.org; Thu, 28 May 2020 14:44:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jeNVa-0000Kz-Gz for guix-patches@gnu.org; Thu, 28 May 2020 14:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41579] [PATCH 0/2] Introduce 'cc-for-target'. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 28 May 2020 18:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41579 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 41579@debbugs.gnu.org Received: via spool by 41579-submit@debbugs.gnu.org id=B41579.15906914351249 (code B ref 41579); Thu, 28 May 2020 18:44:02 +0000 Received: (at 41579) by debbugs.gnu.org; 28 May 2020 18:43:55 +0000 Received: from localhost ([127.0.0.1]:53031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeNVT-0000K4-HO for submit@debbugs.gnu.org; Thu, 28 May 2020 14:43:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jeNVR-0000Jp-Gp for 41579@debbugs.gnu.org; Thu, 28 May 2020 14:43:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:38885) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jeNVM-0006dh-7v for 41579@debbugs.gnu.org; Thu, 28 May 2020 14:43:48 -0400 Received: from [2a01:e0a:fa:a50:9d06:5008:a301:87e5] (port=33690 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jeNVK-00089E-RF; Thu, 28 May 2020 14:43:47 -0400 From: Mathieu Othacehe References: <20200528171137.29146-1-marius@gnu.org> Date: Thu, 28 May 2020 20:43:44 +0200 In-Reply-To: <20200528171137.29146-1-marius@gnu.org> (Marius Bakke's message of "Thu, 28 May 2020 19:11:37 +0200") Message-ID: <87eer3zyqn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: bZXKv0jzgWQ0 Hello Marius, > To reduce duplication, the following patch introduces a 'cc-for-target' > procedure, so one can instead do: > > (string-append "CC=" ,(cc-for-target)) > > ...and it will DTRT. This is definitely a nice improvement! Sometimes the issue also extends to AR and LD for instance. This has been discussed here[1]. Maybe we should deal with that directly in the build system, and provide suitable default values for CC, AR, LD & friends, when cross-compiling. Anyway, your patch is already a big improvement and it LGTM. Thanks, Mathieu [1]: https://lists.gnu.org/archive/html/guix-patches/2020-05/msg00423.html