From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WCMnHIw3Vl/VIQAA0tVLHw (envelope-from ) for ; Mon, 07 Sep 2020 13:37:16 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 2Of/F4w3Vl8nKQAAB5/wlQ (envelope-from ) for ; Mon, 07 Sep 2020 13:37:16 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D13539400C7 for ; Mon, 7 Sep 2020 13:37:15 +0000 (UTC) Received: from localhost ([::1]:59564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kFHKc-0001k0-Kh for larch@yhetil.org; Mon, 07 Sep 2020 09:37:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFHKQ-0001jX-5D for guix-patches@gnu.org; Mon, 07 Sep 2020 09:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kFHKP-000112-So for guix-patches@gnu.org; Mon, 07 Sep 2020 09:37:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kFHKP-000071-QI for guix-patches@gnu.org; Mon, 07 Sep 2020 09:37:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43204] [PATCH] gnu: taglib: Propagate zlib. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 07 Sep 2020 13:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43204 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: mike@rohleder.de, Pierre Langlois , 43204@debbugs.gnu.org Received: via spool by 43204-submit@debbugs.gnu.org id=B43204.1599485803409 (code B ref 43204); Mon, 07 Sep 2020 13:37:01 +0000 Received: (at 43204) by debbugs.gnu.org; 7 Sep 2020 13:36:43 +0000 Received: from localhost ([127.0.0.1]:48426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFHK7-00006W-HM for submit@debbugs.gnu.org; Mon, 07 Sep 2020 09:36:43 -0400 Received: from mout.gmx.net ([212.227.15.19]:41971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFHK5-00006H-4h for 43204@debbugs.gnu.org; Mon, 07 Sep 2020 09:36:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599485792; bh=U+G1HKpkuSz4fwWwrAIqeepUp0XqlbLIoCmhw/n+bYk=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=OVwx1BQPdVwYEeEK53lRlgr/NtkdeaH7jLwL5m+MTzIqsx0qc2Yl47D6HcOt4MhS9 f2y3bIA962Srlhe2uEGHKFqyXQyganP8JI5V8VXX2SlTqmHz/Pc/M4vRFo1fsn0Bx0 +S2Dc2HGibFBZZuT/vpfYuCyBc62g/SDHW8Tcx0E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from e120243-lin ([82.69.64.142]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1M1psI-1kHUFM0Wlc-002JjM; Mon, 07 Sep 2020 15:36:32 +0200 References: <20200904153824.27164-1-mike@rohleder.de> <87363xmsfx.fsf@gmx.com> <87wo18piv4.fsf@gmx.com> <875z8pkck2.fsf@gnu.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois In-reply-to: <875z8pkck2.fsf@gnu.org> Message-ID: <87eendpuvl.fsf@gmx.com> Date: Mon, 07 Sep 2020 14:41:02 +0100 MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:VYXxf2mvZwqLavYn3pOOr9JolGMfFjOaZEsJrqyJABv0beoQ3wQ 3Ru5vEK9Irv5eLehJ+B15tAs1Ixicl65lscjG8AF6PcQclHyfLnpKWcbObn4z4pEn7b7e6J 57OQDyN+MTkgFa/FZRJ02lpGSt0NKeA4ZIxc7MHD2phKS6TkduZ3alo5V+YEa8x5+Cp71Jx wuGRUAhlDNtUSs23Vj9/A== X-UI-Out-Filterresults: notjunk:1;V03:K0:7OxV2BOzaCI=:w8ufSdpoUUP2jc4gpO5hsA TsahadOnYm3jzKLPGtBixeXgKyCvBBpWGSzL6CtgvYz1wp6ly4pFrdlfA3HNhoAvtsdvtonWe GXW+T/0Ed6JEQ7kWl0qhRUgtUPwFBcG2MML520QoP/n9swysB3zH/L/Ybn9DDYJqJWraDRSo9 nWo3lDWrxKZ/k9Tgi+4331XCpvdQxHkb1OPrNwrjcZ0qTVFct2m7Arh4WY4zNeF2bEoz4H3Ac eqUytbWy3+cQMBRb7yPHftMW7vuHuWU8B4rNUh/SiNAh5UbbcCj+jhkM0a/iE5cDYvLLbwLUW csicO8SABpI70Rx8nAZ4ASpfvWtsaRNET9qzOXjP6RFUxLxDPghhVreStyMrRDaMNkKYhOWkC W0rVOBoYH2X1JVxv5kbuIJUwZKnvQzwv/nvCSGd91cEXYAyxUiXj5ON2bsvQ7Cb6CUZF5xtMl E2FG74EjurdIDaKJTOSuKBgAM58qdPPzG9+IAWBmGNdGfZuDu1xjeqO05CGpL3iWEFCrc3pbd hYO5nWY/SQDp2Q86BI/0kXEFuNXMV4DT/M+qXtZfGAKaF8383UMzvf6oIiNyVbbKEVx77EY+y bnoqimqX+k8zhiSTVMYwNw+syBfCbAeMJoR+yPBi0dXTKqVCMBjHRLmjcAi1nKaAkNO2kG1Ot RKl+UTYLyH62MPv/Iwfsb0wbiU92LrsjYPdeoMa1oXKOYHX/HVQhIjJ6eYaagX7xLmbcxwJyE D7BoWoHdiz+VTcUU9vC+oAuGSvDmpYtlKJj9uE1wr2+NNKppc8XpmWk9rpdW7EBNbaGfK6ZgL qqd3gypu1vTWUxj2ffs304cDQOKzeQZXeZ+jl+WcgXAguh8Jjvukmjg9DlH6D0bvRLqMaa55j 6UU1BlnoLIHpygnwItAidBtW9Yn6u21DQ8+p43wSvxdJcenlbsl3Ix3/cDtDd7m17B5Xoiqe9 J1nVOkRtTVrqWxxMfX8OPsyjMkoBgJwrj+ZPlAxyvU28AWJTM1vRx1n6UVDDZb3nfuMMqygw0 CKQb97PeHLhBng9wZaXRkWT9l+miYvPnq7MttmnS8IniWvGQdzJiJ96uuJiTU0MzDK5khTyuh U4Cjs1kDjuJV4vN3zt3NuUWCJB/AZ07gzJdYrcWkH9C/wLhJhjqdCFgU/S8CmfZpbq8b7W8Ya MfdgdDwcgDeiDtlM3LXsdYQymbgCN4KQ+6+J58e91OFK/PxHeI2yt0Pi8FUPClhXIb4lnxgJt kIXTuWu485yaP0PWCrjsXLTuQxzD7518lbSIrAg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmx.net header.s=badeba3b8450 header.b=OVwx1BQP; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -2.11 X-TUID: AosjrZi8ZCHv --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: > Hi! > > Pierre Langlois skribis: > >> Actually, thinking about this a little more, I'm not sure I understand >> upstream decision to propagate -lz. The commit fixes [0] which indicates >> it's so that taglib can be linked statically, but then that means if >> we're dynamically linking, the application will also dynamically link >> with zlib when it doesn't need to (at least not directly). And in guix >> we only build shared libs for taglib so we're never statically linking >> it AFAIK. >> >> So, here I'm a bit torn here, should we just follow what upstream is >> indicating? Even it doesn't look right to me, but I might be wrong! Or, >> should we revert the change that propagates -lz? > > I had the following patch that I intended to push, to avoid propagation. > > WDYT? > > Ludo=E2=80=99. > > commit d8124a707602980556fd33c7dbf9f7483fe1d0df > Author: Ludovic Court=C3=A8s > Date: Mon Sep 7 09:56:08 2020 +0200 > > gnu: taglib: 'taglib-config --libs' shows -L flag for zlib. >=20=20=20=20=20 > Fixes compilation of emacs-emms-print-metadata. >=20=20=20=20=20 > * gnu/packages/mp3.scm (taglib)[arguments]: Add #:phases. LGTM! I was originally thinking we could just drop the `-lz`, since it /should/ only be needed for people who statically link with taglib, and we only ship shared libs. But actually, it's probably safer to follow what upstream is doing. Thanks, Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCAA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9WOG4YHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31UxnUIAK5lzRBIWA6e2gltYGSBIgw6 Sjy36KME6/TBu8D2uT5009wJGLaHNYHrGEg7kO8hDvoEt4AiomV0fbIdt+LEIY+O EBbtrSNyuc2tS1PLF2clf/sPjIOomzM+MiST0Fq0SizQBjHL8Ohw/MDl6YG/1l5Y KP2vJGh21g0KY5IVtY3FRA/KVjzTVev/TNkFJqNjvrniEEwb4DLoZ/ngYZ5sw9Pu 302KHsMXgkm8TrrZty+573Qdz11mm/gqhZnuj4/NSVdrQbq5NUvxqTZg7p6fuemZ cZ7auXP9WSIREg3bv7ZgLH3NNVs8tUFP6C9HemA/4rCdy0hpoUBjGauN5oQQHoc= =TnBV -----END PGP SIGNATURE----- --=-=-=--