From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CkrvGlDEe19FaQAA0tVLHw (envelope-from ) for ; Tue, 06 Oct 2020 01:11:44 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oKBJFlDEe1+3CgAAbx9fmQ (envelope-from ) for ; Tue, 06 Oct 2020 01:11:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 13A589402A9 for ; Tue, 6 Oct 2020 01:11:44 +0000 (UTC) Received: from localhost ([::1]:34332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kPbW3-0002uW-0h for larch@yhetil.org; Mon, 05 Oct 2020 21:11:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57492) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kPbVQ-0002uK-3f for guix-patches@gnu.org; Mon, 05 Oct 2020 21:11:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39331) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kPbVO-0001OB-Lb for guix-patches@gnu.org; Mon, 05 Oct 2020 21:11:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kPbVO-00030T-Gk for guix-patches@gnu.org; Mon, 05 Oct 2020 21:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43823] [PATCH 2/3] gnu: knot: Build the Info manual. Resent-From: Tobias Geerinckx-Rice Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Oct 2020 01:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43823 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon South Cc: 43823@debbugs.gnu.org Received: via spool by 43823-submit@debbugs.gnu.org id=B43823.160194662211502 (code B ref 43823); Tue, 06 Oct 2020 01:11:02 +0000 Received: (at 43823) by debbugs.gnu.org; 6 Oct 2020 01:10:22 +0000 Received: from localhost ([127.0.0.1]:50875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbUk-0002zS-GU for submit@debbugs.gnu.org; Mon, 05 Oct 2020 21:10:22 -0400 Received: from tobias.gr ([80.241.217.52]:57716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kPbUh-0002zJ-Ve for 43823@debbugs.gnu.org; Mon, 05 Oct 2020 21:10:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tobias.gr; s=2018; bh=Cw28hN9Z/tz5k54NHsF22uT9BGPB0orgwjqwHjVb3UA=; h=date:in-reply-to: references:subject:cc:to:from; b=T5bSI9skKIE+kNy1HHhm5wm8Mt2SjnpnskuhF gu0F8g+II6npFJiRq18g79+4Kjp+TIeYuWc4YWCc8ehE7u4Z0AtGEGJH9kUpjxmUYz1Gmz J9tho7qwlO2B1Kh2V7ZHjq23tfGEz7hExTyDMi2zBb/wpqv4ODwKWvC8EVn0C5Bmh5PULX 3GVDnScBP7YXIJ+PHS+4jHor/U1vlc77jvB42Zox7AVsT5Pb8iRjnwpfv/baWNLjGAq5Wc nMLgSxDyAHB7lrHgjJl5b/sEtSxcBur7aib0VDhmLBLAvrJ3MacG58A6j1xYKacef01i04 CvHCxPsoheGabztcmnQ9AZQzA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 33a69591 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Tue, 6 Oct 2020 01:10:27 +0000 (UTC) BIMI-Selector: v=BIMI1; s=default; References: <201a17b6e4fe8abb50cf759fe50db1b339b17657.1601941844.git.simon@simonsouth.net> In-reply-to: <201a17b6e4fe8abb50cf759fe50db1b339b17657.1601941844.git.simon@simonsouth.net> Date: Tue, 06 Oct 2020 03:10:17 +0200 Message-ID: <87eemc88hy.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=tobias.gr header.s=2018 header.b=T5bSI9sk; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.61 X-TUID: 6gaocq/IjUsY --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Simon, Simon South =E5=86=99=E9=81=93=EF=BC=9A > This also silences a configure warning about the "sphinx-build" > command being unavailable. ./configure is a noisy boy; not every =E2=80=98warning=E2=80=99 warrants ac= tion.=20 A GNU info manual is definitely nice to have though! > + ("makeinfo" ,texinfo) > ("pkg-config" ,pkg-config) > - ("ragel" ,ragel))) > + ("ragel" ,ragel) > + ("sphinx-build" ,python-sphinx))) It's a subjective line but I'd prefer the labels match the package=20 here. Nitpick, can be fixed up in post. Otherwise LGTM, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCX3vD+Q0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15lw8BAPT6pMXV1Fw2suVDVGexDqQLHdw/FUmlrflpxaWF gxS9AQCwRfvoYxlKuBBznKUnFUgpGGaEeg7lBHElHF2Hu7hNBQ== =W/6M -----END PGP SIGNATURE----- --=-=-=--