From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +AiAOIOUhF/IHwAA0tVLHw (envelope-from ) for ; Mon, 12 Oct 2020 17:38:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sP9cNIOUhF+vEAAA1q6Kng (envelope-from ) for ; Mon, 12 Oct 2020 17:38:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 74365940149 for ; Mon, 12 Oct 2020 17:38:11 +0000 (UTC) Received: from localhost ([::1]:49632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS1ly-0005C9-9K for larch@yhetil.org; Mon, 12 Oct 2020 13:38:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS1lq-0005Aw-UN for guix-patches@gnu.org; Mon, 12 Oct 2020 13:38:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kS1lq-0006Pl-GG for guix-patches@gnu.org; Mon, 12 Oct 2020 13:38:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kS1lq-0004vh-9E for guix-patches@gnu.org; Mon, 12 Oct 2020 13:38:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43080] [PATCH] gnu: add j version 902. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 12 Oct 2020 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43080 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Joseph Novakovich Cc: 43080@debbugs.gnu.org Received: via spool by 43080-submit@debbugs.gnu.org id=B43080.160252423718895 (code B ref 43080); Mon, 12 Oct 2020 17:38:02 +0000 Received: (at 43080) by debbugs.gnu.org; 12 Oct 2020 17:37:17 +0000 Received: from localhost ([127.0.0.1]:43895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS1l7-0004uh-BN for submit@debbugs.gnu.org; Mon, 12 Oct 2020 13:37:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS1l5-0004uU-CO for 43080@debbugs.gnu.org; Mon, 12 Oct 2020 13:37:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47483) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS1l0-0006IT-2d; Mon, 12 Oct 2020 13:37:10 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=54258 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kS1kz-000311-JD; Mon, 12 Oct 2020 13:37:09 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Mon, 12 Oct 2020 19:37:07 +0200 In-Reply-To: (Joseph Novakovich's message of "Fri, 28 Aug 2020 00:05:45 +0000") Message-ID: <87eem3ny64.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: 7d7oSEhtc/R5 Hi Joseph, Joseph Novakovich skribis: > From 798d0e3c2b635cfe3a936937fd3dd3ea1b8c5812 Mon Sep 17 00:00:00 2001 > From: Joseph Novakovich > Date: Thu, 27 Aug 2020 19:16:16 -0400 > Subject: [PATCH] gnu: add j version 902. > > --- > gnu/packages/j.scm | 180 +++++++++++++++++++++++++++++++++++++++++++++ Sorry for the loooong delay! A few comments=E2=80=94if needed we can make those changes on your behalf, = let us know. Could you add j.scm to =E2=80=98gnu/local.mk=E2=80=99? > + (name "j") > + (version "902") > + (source > + (origin > + (method git-fetch) > + (uri > + (git-reference > + (url "https://github.com/jsoftware/jsource") > + (commit "59324abbc6c9c3709d39096f5a41e0a4ef28e9f6"))) Why this commit? If there=E2=80=99s a tag, it would be clearer to refer to= the tag (the =E2=80=98commit=E2=80=99 field can name a tag). > + (outputs '("out")) Unnecessary, you can remove it. > + `(#:modules > + ((guix build gnu-build-system) > + (guix build utils)) Likewise. > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let ((jplatform "linux") > + (j64x "j64avx2")) > + (chdir "make2") > + (system > + (format #f > + "jplatform=3D~a j64x=3D~a USE_SLEEF=3D1 ./build_= jconsole.sh" > + jplatform j64x)) Note that we cannot assume AVX2 support (on x86_64, but especially on non-Intel platforms). Can you check this doesn=E2=80=99t create binaries t= hat require AVX2? Also, it would be more robust to replace =E2=80=98system=E2=80=99 by someth= ing like: (Seton "jplatform" "linux") (setenv "USE_SLEEF" "1") =E2=80=A6 (invoke "./build_jconsole.sh") since =E2=80=98invoke=E2=80=99 checks the exit code of the given command. > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((bin-out (string-append (assoc-ref %outputs "out") "= /bin")) > + (share-out (string-append (assoc-ref %outputs "out") > + "/share/j")) > + (jconsole "jlibrary/bin/jconsole") > + (libj.so "jlibrary/bin/libj.so")) I=E2=80=99d omit =E2=80=98-out=E2=80=99 from variable names. > + (synopsis "APL Dialect") What about =E2=80=9CDialect of the APL programming language=E2=80=9D for cl= arity? > + (description "J is a programming language that works with arrays, > +verbs, adverbs, and conjunctions. For example, +/x sums array x and > +/:~x sorts it.") Please use @code markup for code snippets. Bonus points if you can expound a bit! https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html > + (license gpl3))) I confirm that this is =E2=80=9Cversion 3 only=E2=80=9D per =E2=80=98licens= e.txt=E2=80=99. Could you send an updated patch? Thanks, Ludo=E2=80=99.