From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oBEhMtZRlV9MdwAA0tVLHw (envelope-from ) for ; Sun, 25 Oct 2020 10:22:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EKn6LdZRlV/EeQAAB5/wlQ (envelope-from ) for ; Sun, 25 Oct 2020 10:22:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1FAC59403E7 for ; Sun, 25 Oct 2020 10:22:14 +0000 (UTC) Received: from localhost ([::1]:52042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWdAD-0001YU-3l for larch@yhetil.org; Sun, 25 Oct 2020 06:22:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45604) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWdA3-0001YL-07 for guix-patches@gnu.org; Sun, 25 Oct 2020 06:22:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:52472) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWdA2-0007eo-LK for guix-patches@gnu.org; Sun, 25 Oct 2020 06:22:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWdA2-00012p-Gj for guix-patches@gnu.org; Sun, 25 Oct 2020 06:22:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44207] [PATCH] doc: Document the postgresql-config-file. Resent-From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 25 Oct 2020 10:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44207 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 44207@debbugs.gnu.org Received: via spool by 44207-submit@debbugs.gnu.org id=B44207.16036212943971 (code B ref 44207); Sun, 25 Oct 2020 10:22:02 +0000 Received: (at 44207) by debbugs.gnu.org; 25 Oct 2020 10:21:34 +0000 Received: from localhost ([127.0.0.1]:35785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWd9Z-00011z-UZ for submit@debbugs.gnu.org; Sun, 25 Oct 2020 06:21:34 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWd9W-00011j-Hf for 44207@debbugs.gnu.org; Sun, 25 Oct 2020 06:21:32 -0400 Received: by mail-wm1-f68.google.com with SMTP id l15so9315593wmi.3 for <44207@debbugs.gnu.org>; Sun, 25 Oct 2020 03:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QopWx/r4pqTbwbgg88l6iOvusoegX3cm1OlA71zkREs=; b=b1znIVZare3HNtQtib+Gfc99fHl5u4j6FAc6Li/0CPZao3v5B6Waygr19hweCZDQLI G35LS3hR3b0Qm0gLQzEe+qMiJ0xXmcEPUSK2qWyE4x0KvAYx8YH1kwYzaP20A34/7AU7 7BxW/M4WRJ83fygP/filgXW3maLnPVoKk7qVvjC6rIvd1R2io19DKmwBAYLhIrWuxZ29 YkZE/Pi7OXUSduPJBEfeNWtezAJpXLmCz3aFpjKHE3BelOBD4o077XGlM695JW9e8mt+ S4bv/Qz18GaLxhzhkMjmu97r/jcv1ZWsGRzvHQEvC0UyWAsGxxHoPidUqAg3tdWAV5CH sfGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QopWx/r4pqTbwbgg88l6iOvusoegX3cm1OlA71zkREs=; b=R38o3it5I29kjhQEnbqOt1pL0kmxlW9OFFwEgBPtiIXiFpMzRQFRygRSacn583g3mu qT72B3lf7bFX4tA9+1lOHXsIrAyt7mmr36uQEw5yixj3HreXjxwYb9cwn6fCQbyhHf/q 2S1Jw09SQQPnaWm4veoWxHjdDu3CeJlRi3JZi8bfKisIc0uFXXdkY2exVdw15vR1ArQn jCdzdONt4EmSXHcRvjByZtzK8YQvA7Q7wS2WLhf3hfchlnjEvV3a95FSpUcBN+TJaNfP 390PfqSCjm6r0vuN5cLvn+TDsdkZI6WlhEBt0fAxyDKcwOfR1QBx9Bng3bvwQhnk52EY 7O9g== X-Gm-Message-State: AOAM533woGKqcfJ9dV8k00mZWnrJj0Mkr4bR4drO8JUBjIh2jvuFtF8R 8+NitsijWH10/kvIdlnNrSopAySqSpyBGA== X-Google-Smtp-Source: ABdhPJwAuxNB7dPyCC0deAFHrh0D1svMHboua9vbQN5xz7JoST4mlTbX/r87pFOcGZg/ZmypxX5z6g== X-Received: by 2002:a1c:e2c1:: with SMTP id z184mr2884091wmg.36.1603621284530; Sun, 25 Oct 2020 03:21:24 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id s2sm14033260wmh.9.2020.10.25.03.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Oct 2020 03:21:23 -0700 (PDT) From: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas References: <20201025085134.14378-1-mail@cbaines.net> Date: Sun, 25 Oct 2020 11:21:23 +0100 In-Reply-To: <20201025085134.14378-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 25 Oct 2020 08:51:34 +0000") Message-ID: <87eelm7gik.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.8 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=b1znIVZa; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: l8Fyg29Oi9iw Hi! Some comments inline. Christopher Baines writes: > +@deftp {Data Type} postgresql-config-file > +Data type representing the PostgreSQL configuration file. As shown in > +the following example, this can be used to customise the configuration > +of PostgreSQL. Note that you can use any G-expression or filename in > +place of this record, if you already have a configuration file you'd > +like to use for example. I'm pretty sure you should s/customise/customize/, as the manual is written in US English. Also, I'd move the last sentence to the hba-file description as an example there, something like: "Filename or G-expression for the host-based authentication configuration. If you already have a configuration file, you can use it here." [...] > +@item @var{log-destination} (default: @code{"syslog"}) [...] > +@item @var{hba-file} (default: @code{%default-postgres-hba}) [...] > +@item @var{ident-file} (default: @code{%default-postgres-ident}) [...] > +@item @var{extra-config} (default: @code{'()}) These should be @code, not @var, because they represent symbols from the configuration. The typical use of @var is for arguments---e.g. @code{(call-something @var{param1} @var{param2})}---, whose names don't have a meaning outside the actual implementation, but these identifiers are symbols included in the API. Apart from that, LGTM. :-) Happy hacking! Miguel