From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id kA5HAbD2ql+BPAAA0tVLHw (envelope-from ) for ; Tue, 10 Nov 2020 20:23:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 4La3OK/2ql8SCgAAbx9fmQ (envelope-from ) for ; Tue, 10 Nov 2020 20:23:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3B5149404E0 for ; Tue, 10 Nov 2020 20:23:11 +0000 (UTC) Received: from localhost ([::1]:46278 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcaAY-000766-61 for larch@yhetil.org; Tue, 10 Nov 2020 15:23:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcaAQ-00074r-Np for guix-patches@gnu.org; Tue, 10 Nov 2020 15:23:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:55708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kcaAQ-00071c-CJ for guix-patches@gnu.org; Tue, 10 Nov 2020 15:23:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kcaAQ-0002qb-8R for guix-patches@gnu.org; Tue, 10 Nov 2020 15:23:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#44269] [PATCH] gnu: Add eosio-cdt. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 10 Nov 2020 20:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44269 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jesse@unraveled.tech, 44269@debbugs.gnu.org Received: via spool by 44269-submit@debbugs.gnu.org id=B44269.160503972610869 (code B ref 44269); Tue, 10 Nov 2020 20:23:02 +0000 Received: (at 44269) by debbugs.gnu.org; 10 Nov 2020 20:22:06 +0000 Received: from localhost ([127.0.0.1]:39021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kca9W-0002pE-Hf for submit@debbugs.gnu.org; Tue, 10 Nov 2020 15:22:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kca9V-0002oJ-2O for 44269@debbugs.gnu.org; Tue, 10 Nov 2020 15:22:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40099) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kca9P-0006vR-Jq; Tue, 10 Nov 2020 15:21:59 -0500 Received: from host-37-191-236-253.lynet.no ([37.191.236.253]:51002 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kca9N-00036x-Qv; Tue, 10 Nov 2020 15:21:59 -0500 From: Marius Bakke In-Reply-To: <20201027211246.573113-1-jesse@unraveled.tech> References: <20201027211246.573113-1-jesse@unraveled.tech> Date: Tue, 10 Nov 2020 21:21:54 +0100 Message-ID: <87eel1dkt9.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.11 X-TUID: UYJ67NWQWWrE --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable jesse@unraveled.tech writes: > Hi all! > > This is my first patch, I hope I'm doing it correctly. Cool, welcome! The patch is lacking a proper commit message, but looks pretty good overall. Some comments follow. > The patch below adds the Contract Development Toolkit (compiler) for smart > contracts on the EOS blockchain. I also have a package for EOS itself tha= t is > a bit more involved, so I'll submit separately. > > Total package size is 607MB of which self is 329MB. It takes a while to > compile (about an hour on my i7 laptop). I suppose some of that time is because of the bundled LLVM, libcxx, etc. Do you know if it's possible to remove those, or at least build them separately? > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm > index 4397cf8ba8..0e661c4b56 100644 > --- a/gnu/packages/finance.scm > +++ b/gnu/packages/finance.scm Can you also add your name to the list of authors at the top of the file? > @@ -59,6 +59,7 @@ > #:use-module (gnu packages compression) > #:use-module (gnu packages crypto) > #:use-module (gnu packages curl) > + #:use-module (gnu packages cmake) I believe this import is unused. [...] =20=20 > +(define-public eosio-cdt > + (package > + (name "eosio-cdt") > + (version "1.7.0") > + (source > + (origin > + (method git-fetch) > + (uri (git-reference (url "https://github.com/EOSIO/eosio.cdt") > + (commit (string-append "v" version)) > + (recursive? #t))) > + (sha256 > + (base32 > + "1mrc8dn7sf086456c63rlha4j3fh0g1a59dbd6in6nyhan712xps")) > + (file-name (git-file-name name version)))) > + (build-system cmake-build-system) > + (native-inputs > + `(("git" ,git) It looks like the git dependency comes from "modules/ClangExternalProject.txt". Though I don't see it being used. Can you try to substitute* out the "find_package(Git ...)" statement and see if it's possible to make it work without it? It's not uncommon that build scripts look for git even when it's not strictly needed. By removing the dependency we avoid needlessly rebuilding this package every time git is updated. > + ("doxygen" ,doxygen) > + ("pkg-config" ,pkg-config) > + ("curl" ,curl))) > + (inputs > + `(("gmp" ,gmp) > + ("openssl" ,openssl) > + ("python" ,python-3))) > + (arguments > + `(#:build-type "Release")) Is there a particular reason to use a "Release" build here (as opposed to the default "RelWithDebInfo")? Guix is a hackers distro, and debugging symbols are nice. :-) > + (home-page "https://developers.eos.io/manuals/eosio.cdt/latest/index= ") > + (synopsis "EOSIO.CDT is a suite of tools used to build EOSIO contrac= ts") Just "Suite of tools to build EOSIO contracts". Otherwise the patch looks great. Can you send an updated version? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFDBAEBCgAtFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl+q9mMPHG1hcml1c0Bn bnUub3JnAAoJEKKgbfKjOlT67qEIAJdjG2CpIQ8KuB6EEAcx7HPYlZ3uK+3EFA7d ptueRw6tbFJMLIsJjoNoZ+iaUZSHsfUtNeVra9wU70oBL7cX1j6VgFXolKPMRQh9 QmZnTD2A+HqVGhLUL53b9cGiyWyEfS7sgPerE1iDOeMz662LHKoKDJ4PQcC056zE H1Ah9exbG6uB6VAobNb5U55hMaGjSKHH/rRxN1Cb6kYZ7YrNXUMlTVx8cCcmIHzu ema6n4n8V553oWqewkUXO0v8/6LNwNbxsyW5/+haAlSSaFibFggVn+din85L98qV vk0V8+WpckfG5BFKSzAkYSAp7QqW1gpdb5Cq9DbNGehT7AqVhnA= =oZdf -----END PGP SIGNATURE----- --=-=-=--