From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 8D9LAihW318SVgAA0tVLHw (envelope-from ) for ; Sun, 20 Dec 2020 13:48:24 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id JJiSOSdW318QcwAAbx9fmQ (envelope-from ) for ; Sun, 20 Dec 2020 13:48:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BFFF6940438 for ; Sun, 20 Dec 2020 13:48:23 +0000 (UTC) Received: from localhost ([::1]:60354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqz4Q-0000Xk-LG for larch@yhetil.org; Sun, 20 Dec 2020 08:48:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqz46-0000X6-2j for guix-patches@gnu.org; Sun, 20 Dec 2020 08:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:60569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqz45-0006dO-Rr for guix-patches@gnu.org; Sun, 20 Dec 2020 08:48:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqz45-0004XF-PV for guix-patches@gnu.org; Sun, 20 Dec 2020 08:48:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45327] [PATCH] git: Periodically delete least-recently-used cached checkouts. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 20 Dec 2020 13:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45327 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Guillaume Le Vaillant Received: via spool by 45327-submit@debbugs.gnu.org id=B45327.160847204317382 (code B ref 45327); Sun, 20 Dec 2020 13:48:01 +0000 Received: (at 45327) by debbugs.gnu.org; 20 Dec 2020 13:47:23 +0000 Received: from localhost ([127.0.0.1]:43882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqz3T-0004WI-1O for submit@debbugs.gnu.org; Sun, 20 Dec 2020 08:47:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqz3R-0004W7-SI for 45327@debbugs.gnu.org; Sun, 20 Dec 2020 08:47:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46468) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqz3M-0006PO-Ab; Sun, 20 Dec 2020 08:47:16 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=34152 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kqz3L-0002Yi-B8; Sun, 20 Dec 2020 08:47:16 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20201219220630.24605-1-ludo@gnu.org> <87pn34n4ab.fsf@yamatai> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 Frimaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 20 Dec 2020 14:47:13 +0100 In-Reply-To: <87pn34n4ab.fsf@yamatai> (Guillaume Le Vaillant's message of "Sun, 20 Dec 2020 11:46:36 +0100") Message-ID: <87eejk8u8u.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45327@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.82 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: BFFF6940438 X-Spam-Score: -2.82 X-Migadu-Scanner: scn0.migadu.com X-TUID: u3wuyn2MPPof Hi, Guillaume Le Vaillant skribis: > Ludovic Court=C3=A8s skribis: > >> Hi! >> >> I noticed that my ~/.cache/guix/checkouts directory had accumulated >> a lot of cruft from channels, playing with =E2=80=98--with-branch=E2=80= =99 and such, >> and that it would be nice to clean it up once in a while. >> >> This is what this patch does. It uses the (guix cache) default >> strategy, which consists in deleting least-recently-used items by >> looking at their atime. >> >> Thoughts? > > How does it behave when the cache is on a file system mounted with the > 'noatime' option? I guess the worst that could happen is that checkouts are removed too frequently (because the atime is not updated), meaning that users find themselves making full clones more often than we=E2=80=99d like. Perhaps we could use the mtime instead, since when checkouts are updated, the mtime is presumably updated too. Thoughts? Ludo=E2=80=99.