From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SL4HFS70BmAaCAAA0tVLHw (envelope-from ) for ; Tue, 19 Jan 2021 15:01:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iFLOEC70BmClMgAAB5/wlQ (envelope-from ) for ; Tue, 19 Jan 2021 15:01:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E5B3894021E for ; Tue, 19 Jan 2021 15:01:01 +0000 (UTC) Received: from localhost ([::1]:37252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1sVA-00022Y-Rp for larch@yhetil.org; Tue, 19 Jan 2021 10:01:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l1sRK-0006QP-4y for guix-patches@gnu.org; Tue, 19 Jan 2021 09:57:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:39650) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l1sRJ-0007Kf-PJ for guix-patches@gnu.org; Tue, 19 Jan 2021 09:57:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l1sRJ-0007Gh-Nl for guix-patches@gnu.org; Tue, 19 Jan 2021 09:57:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45725] [PATCH] gnu: Add gutenprint. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Jan 2021 14:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45725 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: John Doe Received: via spool by 45725-submit@debbugs.gnu.org id=B45725.161106821827930 (code B ref 45725); Tue, 19 Jan 2021 14:57:01 +0000 Received: (at 45725) by debbugs.gnu.org; 19 Jan 2021 14:56:58 +0000 Received: from localhost ([127.0.0.1]:51196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1sRG-0007GQ-3w for submit@debbugs.gnu.org; Tue, 19 Jan 2021 09:56:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l1sRD-0007G6-V2 for 45725@debbugs.gnu.org; Tue, 19 Jan 2021 09:56:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53257) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l1sR8-0007JV-6D; Tue, 19 Jan 2021 09:56:50 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43646 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1l1sR7-00085S-4s; Tue, 19 Jan 2021 09:56:49 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20210108113822.24978-1-dftxbs3e@free.fr> <20210109111236.31405-1-dftxbs3e@free.fr> Date: Tue, 19 Jan 2021 15:56:47 +0100 In-Reply-To: <20210109111236.31405-1-dftxbs3e@free.fr> (John Doe's message of "Sat, 9 Jan 2021 12:12:36 +0100") Message-ID: <87eeihht5c.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45725@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E5B3894021E X-Spam-Score: -2.85 X-Migadu-Scanner: scn1.migadu.com X-TUID: U76UI29U/VGm Hi, John Doe skribis: > * gnu/packages/cups.scm (gutenprint): New variable. [...] > + (synopsis "Printer drivers for CUPS on GNU/Linux") You can remove =E2=80=9Con GNU/Linux=E2=80=9D, it=E2=80=99s implicit (I don= =E2=80=99t see how it could be non-portable actually!). > + ;; Supported printers list from: > + ;; http://gimp-print.sourceforge.net/p_Supported_Printers.php > + ;; Remember to update on version bumps with this command: > + ;; $ curl http://gimp-print.sourceforge.net/p_Supported_Printers.php= | \ > + ;; grep -Po '(?<=3D^).+?(?=3D)' | sed 's/^/@item /g' > + (description "Printer drivers for ^ Please make it a full sentence, as per: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html > +CUPS on GNU/Linux, Macintosh OS X, and other POSIX-compliant operating s= ystems. > +This project also maintains an enhanced Print plug-in for GIMP 2.x from > +the same code base. This driver claims to support these printers: > + > +@enumerate > +@item Canon BJ-30 > +@item Canon BJC-50 I think we shouldn=E2=80=99t have such lists, even with the comment above o= n how to update it. It=E2=80=99s not the right place for that and it would scare= away translators (who are already shy enough when it comes to translating package descriptions :-)). What you could do is write a sentence like: =E2=80=9CThis driver supports widespread inkjet printers by major vendors, including Canon, Epson, Fujitsu, and SONY.=E2=80=9D (arbitrary choice) That way people will at least see the vendor names, but the description remains human-readable. Otherwise LGTM. Could you send an updated patch? Thanks, Ludo=E2=80=99.